----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45974/#review128099 -----------------------------------------------------------
ambari-server/src/main/resources/alerts.json (line 43) <https://reviews.apache.org/r/45974/#comment191483> The display name is how this value should be displayed in the web client; not the description. For example, this could easily have been something like "Warning Response Time" instead of just "Warning". I'm fine changing this to something similar, but it should not be a duplicate of the description field. - Jonathan Hurley On April 8, 2016, 10:14 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45974/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 10:14 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Richard Zang, and > Yusaku Sako. > > > Bugs: AMBARI-15787 > https://issues.apache.org/jira/browse/AMBARI-15787 > > > Repository: ambari > > > Description > ------- > > For SERVER alerts, change display_name to the text from description field, as > it's used for label of the config field. > > > Diffs > ----- > > ambari-server/src/main/resources/alerts.json 3b6ebbb > > Diff: https://reviews.apache.org/r/45974/diff/ > > > Testing > ------- > > > Thanks, > > Zhe (Joe) Wang > >
