Re: Review Request 45989: Blueprint: Presence/absence of HiveServer2 Interactive component in the template should be validated against related configurations

2016-04-11 Thread Sumit Mohanty 


> On April 11, 2016, 5:46 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, 
> > line 40
> > 
> >
> > What's this print for?

Secret code :-) Remains of a debugging attempt. Will clean this up. Thanks


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45989/#review128179
---


On April 10, 2016, 6:56 p.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45989/
> ---
> 
> (Updated April 10, 2016, 6:56 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15793
> https://issues.apache.org/jira/browse/AMBARI-15793
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack advisor should be modified to perform the above validations and 
> blueprint calls into stack advisor.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 9050092 
>   ambari-server/src/test/python/stacks/2.5/common/host-3-hosts.json 
> PRE-CREATION 
>   
> ambari-server/src/test/python/stacks/2.5/common/services-normal-his-2-hosts.json
>  PRE-CREATION 
>   
> ambari-server/src/test/python/stacks/2.5/common/services-normal-his-valid.json
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45989/diff/
> 
> 
> Testing
> ---
> 
> Modifications to only the stack unit tests. Manually tested using API calls 
> and cluster deployment.
> 
> OK
> --
> Total run:946
> Total errors:0
> Total failures:0
> OK
> [smohanty@HW12158 python (trunk)]$
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 45989: Blueprint: Presence/absence of HiveServer2 Interactive component in the template should be validated against related configurations

2016-04-11 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45989/#review128179
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
40)


What's this print for?


- Alejandro Fernandez


On April 10, 2016, 6:56 p.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45989/
> ---
> 
> (Updated April 10, 2016, 6:56 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15793
> https://issues.apache.org/jira/browse/AMBARI-15793
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack advisor should be modified to perform the above validations and 
> blueprint calls into stack advisor.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 9050092 
>   ambari-server/src/test/python/stacks/2.5/common/host-3-hosts.json 
> PRE-CREATION 
>   
> ambari-server/src/test/python/stacks/2.5/common/services-normal-his-2-hosts.json
>  PRE-CREATION 
>   
> ambari-server/src/test/python/stacks/2.5/common/services-normal-his-valid.json
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45989/diff/
> 
> 
> Testing
> ---
> 
> Modifications to only the stack unit tests. Manually tested using API calls 
> and cluster deployment.
> 
> OK
> --
> Total run:946
> Total errors:0
> Total failures:0
> OK
> [smohanty@HW12158 python (trunk)]$
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 45989: Blueprint: Presence/absence of HiveServer2 Interactive component in the template should be validated against related configurations

2016-04-10 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45989/#review128052
---


Ship it!




LGTM.

- Swapan Shridhar


On April 10, 2016, 6:56 p.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45989/
> ---
> 
> (Updated April 10, 2016, 6:56 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15793
> https://issues.apache.org/jira/browse/AMBARI-15793
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack advisor should be modified to perform the above validations and 
> blueprint calls into stack advisor.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 9050092 
>   ambari-server/src/test/python/stacks/2.5/common/host-3-hosts.json 
> PRE-CREATION 
>   
> ambari-server/src/test/python/stacks/2.5/common/services-normal-his-2-hosts.json
>  PRE-CREATION 
>   
> ambari-server/src/test/python/stacks/2.5/common/services-normal-his-valid.json
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45989/diff/
> 
> 
> Testing
> ---
> 
> Modifications to only the stack unit tests. Manually tested using API calls 
> and cluster deployment.
> 
> OK
> --
> Total run:946
> Total errors:0
> Total failures:0
> OK
> [smohanty@HW12158 python (trunk)]$
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Review Request 45989: Blueprint: Presence/absence of HiveServer2 Interactive component in the template should be validated against related configurations

2016-04-10 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45989/
---

Review request for Ambari, Srimanth Gunturi and Swapan Shridhar.


Bugs: AMBARI-15793
https://issues.apache.org/jira/browse/AMBARI-15793


Repository: ambari


Description
---

Stack advisor should be modified to perform the above validations and blueprint 
calls into stack advisor.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
9050092 
  ambari-server/src/test/python/stacks/2.5/common/host-3-hosts.json 
PRE-CREATION 
  
ambari-server/src/test/python/stacks/2.5/common/services-normal-his-2-hosts.json
 PRE-CREATION 
  
ambari-server/src/test/python/stacks/2.5/common/services-normal-his-valid.json 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/45989/diff/


Testing
---

Modifications to only the stack unit tests. Manually tested using API calls and 
cluster deployment.

OK
--
Total run:946
Total errors:0
Total failures:0
OK
[smohanty@HW12158 python (trunk)]$


Thanks,

Sumit Mohanty