Re: Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-12 Thread Aravindan Vijayan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46037/
---

(Updated April 12, 2016, 11:53 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-15698
https://issues.apache.org/jira/browse/AMBARI-15698


Repository: ambari


Description
---

PROBLEM
Metrics with aggregation function do not show up on Ambari Web.

BUG & FIX
API did not return any data because of issues in Property Provider and a bug in 
AMS.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 51cacf3 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java
 bec103a 

Diff: https://reviews.apache.org/r/46037/diff/


Testing
---

Manually tested.

Unit tests pass.

[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [10.569s]
[INFO] Apache Ambari Project POM . SUCCESS [0.032s]
[INFO] Ambari Web  SUCCESS [42.410s]
[INFO] Ambari Views .. SUCCESS [2.469s]
[INFO] Ambari Admin View . SUCCESS [26.923s]
[INFO] ambari-metrics  SUCCESS [1.148s]
[INFO] Ambari Metrics Common . SUCCESS [2.506s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [5.348s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [2.694s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [4.014s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.381s]
[INFO] Ambari Metrics Collector .. SUCCESS [2:18.952s]
[INFO] Ambari Metrics Monitor  SUCCESS [3.226s]
[INFO] Ambari Metrics Grafana  SUCCESS [5.796s]
[INFO] Ambari Metrics Assembly ... SUCCESS [14.233s]
[INFO] Ambari Server . SUCCESS [58:44.785s]
[INFO] Ambari Agent .. SUCCESS [9.778s]
[INFO] Ambari Client . SUCCESS [0.062s]
[INFO] Ambari Python Client .. SUCCESS [0.379s]
[INFO] Ambari Groovy Client .. SUCCESS [10.368s]
[INFO] Ambari Shell .. SUCCESS [0.041s]
[INFO] Ambari Python Shell ... SUCCESS [0.036s]
[INFO] Ambari Groovy Shell ... SUCCESS [7.090s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:03:35.031s
[INFO] Finished at: Mon Apr 11 11:03:19 PDT 2016
[INFO] Final Memory: 102M/1015M
[INFO] 


Thanks,

Aravindan Vijayan



Re: Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-11 Thread Aravindan Vijayan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46037/
---

(Updated April 11, 2016, 6:03 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-15698
https://issues.apache.org/jira/browse/AMBARI-15698


Repository: ambari


Description
---

PROBLEM
Metrics with aggregation function do not show up on Ambari Web.

BUG & FIX
API did not return any data because of issues in Property Provider and a bug in 
AMS.


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 cd0a0fd 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 ecd9d70 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
 87a1ab1 

Diff: https://reviews.apache.org/r/46037/diff/


Testing (updated)
---

Manually tested.

Unit tests pass.

[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [10.569s]
[INFO] Apache Ambari Project POM . SUCCESS [0.032s]
[INFO] Ambari Web  SUCCESS [42.410s]
[INFO] Ambari Views .. SUCCESS [2.469s]
[INFO] Ambari Admin View . SUCCESS [26.923s]
[INFO] ambari-metrics  SUCCESS [1.148s]
[INFO] Ambari Metrics Common . SUCCESS [2.506s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [5.348s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [2.694s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [4.014s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.381s]
[INFO] Ambari Metrics Collector .. SUCCESS [2:18.952s]
[INFO] Ambari Metrics Monitor  SUCCESS [3.226s]
[INFO] Ambari Metrics Grafana  SUCCESS [5.796s]
[INFO] Ambari Metrics Assembly ... SUCCESS [14.233s]
[INFO] Ambari Server . SUCCESS [58:44.785s]
[INFO] Ambari Agent .. SUCCESS [9.778s]
[INFO] Ambari Client . SUCCESS [0.062s]
[INFO] Ambari Python Client .. SUCCESS [0.379s]
[INFO] Ambari Groovy Client .. SUCCESS [10.368s]
[INFO] Ambari Shell .. SUCCESS [0.041s]
[INFO] Ambari Python Shell ... SUCCESS [0.036s]
[INFO] Ambari Groovy Shell ... SUCCESS [7.090s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:03:35.031s
[INFO] Finished at: Mon Apr 11 11:03:19 PDT 2016
[INFO] Final Memory: 102M/1015M
[INFO] 


Thanks,

Aravindan Vijayan



Re: Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-11 Thread Dmytro Sen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46037/#review128172
---


Ship it!




Ship It!

- Dmytro Sen


On Апрель 11, 2016, 4:57 п.п., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46037/
> ---
> 
> (Updated Апрель 11, 2016, 4:57 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15698
> https://issues.apache.org/jira/browse/AMBARI-15698
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Metrics with aggregation function do not show up on Ambari Web.
> 
> BUG & FIX
> API did not return any data because of issues in Property Provider and a bug 
> in AMS.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  cd0a0fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  ecd9d70 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
>  87a1ab1 
> 
> Diff: https://reviews.apache.org/r/46037/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>



Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-11 Thread Aravindan Vijayan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46037/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-15698
https://issues.apache.org/jira/browse/AMBARI-15698


Repository: ambari


Description
---

PROBLEM
Metrics with aggregation function do not show up on Ambari Web.

BUG & FIX
API did not return any data because of issues in Property Provider and a bug in 
AMS.


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 cd0a0fd 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 ecd9d70 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
 87a1ab1 

Diff: https://reviews.apache.org/r/46037/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan