Re: Review Request 46136: Unit Test Coverage For Alert Caching

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46136/#review128682
---


Ship it!





ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java
 (line 47)


Why not `extend` `EasyMockSupport`?



ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java
 (line 182)


If extending EasyMockSupport, than this would be 

```
replayAll();
```


- Robert Levas


On April 12, 2016, 11:28 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46136/
> ---
> 
> (Updated April 12, 2016, 11:28 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-13569
> https://issues.apache.org/jira/browse/AMBARI-13569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add unit tests for the caching of AlertCurrentEntity in the DAO.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/services/CachedAlertFlushServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46136/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 46136: Unit Test Coverage For Alert Caching

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46136/
---

Review request for Ambari, Nate Cole and Robert Levas.


Bugs: AMBARI-13569
https://issues.apache.org/jira/browse/AMBARI-13569


Repository: ambari


Description
---

Add unit tests for the caching of AlertCurrentEntity in the DAO.


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/services/CachedAlertFlushServiceTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/46136/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley