Re: Review Request 46337: Upgrading Ambari should delete any pyc files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46337/#review129511 --- Ship it! Ship It! - Andrew Onischuk On April 19, 2016, 11:57 a.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46337/ > --- > > (Updated April 19, 2016, 11:57 a.m.) > > > Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi. > > > Bugs: AMBARI-15947 > https://issues.apache.org/jira/browse/AMBARI-15947 > > > Repository: ambari > > > Description > --- > > A python file owned by ambari agent had a swp file open during the ambari > agent upgrade. For that reason, the pyc file never got recreated, which led > to seeing the bug again for that Jira even though the source code was correct. > > Upgrading ambari agent or server should always delete any pyc files in > /var/lib/ambari-agent > /var/lib/ambari-server > /usr/lib/python2.6/site-packages/ambari-agent > /usr/lib/python2.6/site-packages/ambari-server > /usr/lib/python2.6/site-packages/ambari-commons > /usr/lib/python2.7/site-packages/ambari-agent > /usr/lib/python2.7/site-packages/ambari-server > /usr/lib/python2.7/site-packages/ambari-commons > > > Diffs > - > > ambari-agent/conf/unix/install-helper.sh 2495080 > ambari-server/conf/unix/install-helper.sh 25a10d6 > > Diff: https://reviews.apache.org/r/46337/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
Re: Review Request 46337: Upgrading Ambari should delete any pyc files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46337/ --- (Updated April 19, 2016, 2:56 p.m.) Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15947 https://issues.apache.org/jira/browse/AMBARI-15947 Repository: ambari Description --- A python file owned by ambari agent had a swp file open during the ambari agent upgrade. For that reason, the pyc file never got recreated, which led to seeing the bug again for that Jira even though the source code was correct. Upgrading ambari agent or server should always delete any pyc files in /var/lib/ambari-agent /var/lib/ambari-server /usr/lib/python2.6/site-packages/ambari-agent /usr/lib/python2.6/site-packages/ambari-server /usr/lib/python2.6/site-packages/ambari-commons /usr/lib/python2.7/site-packages/ambari-agent /usr/lib/python2.7/site-packages/ambari-server /usr/lib/python2.7/site-packages/ambari-commons Diffs (updated) - ambari-agent/conf/unix/install-helper.sh 2495080 ambari-server/conf/unix/install-helper.sh 25a10d6 Diff: https://reviews.apache.org/r/46337/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko
Re: Review Request 46337: Upgrading Ambari should delete any pyc files
> On April 19, 2016, 7:25 a.m., Andrew Onischuk wrote: > > I think re-remove is that rigth place to do it. > > > > Ps: prerm is also called during upgrade. Please do the change and than commit it. Didn't mean to ship. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46337/#review129490 --- On April 18, 2016, 5:35 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46337/ > --- > > (Updated April 18, 2016, 5:35 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-15947 > https://issues.apache.org/jira/browse/AMBARI-15947 > > > Repository: ambari > > > Description > --- > > A python file owned by ambari agent had a swp file open during the ambari > agent upgrade. For that reason, the pyc file never got recreated, which led > to seeing the bug again for that Jira even though the source code was correct. > > Upgrading ambari agent or server should always delete any pyc files in > /var/lib/ambari-agent > /var/lib/ambari-server > /usr/lib/python2.6/site-packages/ambari-agent > /usr/lib/python2.6/site-packages/ambari-server > /usr/lib/python2.6/site-packages/ambari-commons > /usr/lib/python2.7/site-packages/ambari-agent > /usr/lib/python2.7/site-packages/ambari-server > /usr/lib/python2.7/site-packages/ambari-commons > > > Diffs > - > > ambari-agent/conf/unix/install-helper.sh 2495080 > ambari-server/conf/unix/install-helper.sh 25a10d6 > > Diff: https://reviews.apache.org/r/46337/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
Re: Review Request 46337: Upgrading Ambari should delete any pyc files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46337/#review129490 --- Ship it! I think re-remove is that rigth place to do it. Ps: prerm is also called during upgrade. - Andrew Onischuk On April 18, 2016, 5:35 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46337/ > --- > > (Updated April 18, 2016, 5:35 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-15947 > https://issues.apache.org/jira/browse/AMBARI-15947 > > > Repository: ambari > > > Description > --- > > A python file owned by ambari agent had a swp file open during the ambari > agent upgrade. For that reason, the pyc file never got recreated, which led > to seeing the bug again for that Jira even though the source code was correct. > > Upgrading ambari agent or server should always delete any pyc files in > /var/lib/ambari-agent > /var/lib/ambari-server > /usr/lib/python2.6/site-packages/ambari-agent > /usr/lib/python2.6/site-packages/ambari-server > /usr/lib/python2.6/site-packages/ambari-commons > /usr/lib/python2.7/site-packages/ambari-agent > /usr/lib/python2.7/site-packages/ambari-server > /usr/lib/python2.7/site-packages/ambari-commons > > > Diffs > - > > ambari-agent/conf/unix/install-helper.sh 2495080 > ambari-server/conf/unix/install-helper.sh 25a10d6 > > Diff: https://reviews.apache.org/r/46337/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
Re: Review Request 46337: Upgrading Ambari should delete any pyc files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46337/#review129379 --- Ship it! Ship It! - Alejandro Fernandez On April 18, 2016, 5:35 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46337/ > --- > > (Updated April 18, 2016, 5:35 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-15947 > https://issues.apache.org/jira/browse/AMBARI-15947 > > > Repository: ambari > > > Description > --- > > A python file owned by ambari agent had a swp file open during the ambari > agent upgrade. For that reason, the pyc file never got recreated, which led > to seeing the bug again for that Jira even though the source code was correct. > > Upgrading ambari agent or server should always delete any pyc files in > /var/lib/ambari-agent > /var/lib/ambari-server > /usr/lib/python2.6/site-packages/ambari-agent > /usr/lib/python2.6/site-packages/ambari-server > /usr/lib/python2.6/site-packages/ambari-commons > /usr/lib/python2.7/site-packages/ambari-agent > /usr/lib/python2.7/site-packages/ambari-server > /usr/lib/python2.7/site-packages/ambari-commons > > > Diffs > - > > ambari-agent/conf/unix/install-helper.sh 2495080 > ambari-server/conf/unix/install-helper.sh 25a10d6 > > Diff: https://reviews.apache.org/r/46337/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
Review Request 46337: Upgrading Ambari should delete any pyc files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46337/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15947 https://issues.apache.org/jira/browse/AMBARI-15947 Repository: ambari Description --- A python file owned by ambari agent had a swp file open during the ambari agent upgrade. For that reason, the pyc file never got recreated, which led to seeing the bug again for that Jira even though the source code was correct. Upgrading ambari agent or server should always delete any pyc files in /var/lib/ambari-agent /var/lib/ambari-server /usr/lib/python2.6/site-packages/ambari-agent /usr/lib/python2.6/site-packages/ambari-server /usr/lib/python2.6/site-packages/ambari-commons /usr/lib/python2.7/site-packages/ambari-agent /usr/lib/python2.7/site-packages/ambari-server /usr/lib/python2.7/site-packages/ambari-commons Diffs - ambari-agent/conf/unix/install-helper.sh 2495080 ambari-server/conf/unix/install-helper.sh 25a10d6 Diff: https://reviews.apache.org/r/46337/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko
