Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Alexandr Antonenko]

> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote:
> > if we will ask BE and create task for them, this will mean move this out of 
> > 2.4. As BE is pretty heavy loaded with tasks
> 
> Zhe (Joe) Wang wrote:
> Agree. That's why I use FE to set the initial value.
> 
> Alexandr Antonenko wrote:
> This is pretty clear as for me, I say let's commit it. After this I will 
> create ticket that will do a little refactoring of this. Andrii T will handle 
> it

Discussed that with Andrii T


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130129
---


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Zhe (Joe) Wang]

> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote:
> > if we will ask BE and create task for them, this will mean move this out of 
> > 2.4. As BE is pretty heavy loaded with tasks
> 
> Zhe (Joe) Wang wrote:
> Agree. That's why I use FE to set the initial value.
> 
> Alexandr Antonenko wrote:
> This is pretty clear as for me, I say let's commit it. After this I will 
> create ticket that will do a little refactoring of this. Andrii T will handle 
> it
> 
> Alexandr Antonenko wrote:
> Discussed that with Andrii T

Cool. Thanks.


- Zhe (Joe)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130129
---


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Zhe (Joe) Wang]

> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote:
> > if we will ask BE and create task for them, this will mean move this out of 
> > 2.4. As BE is pretty heavy loaded with tasks

Agree. That's why I use FE to set the initial value.


- Zhe (Joe)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130129
---


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130129
---



if we will ask BE and create task for them, this will mean move this out of 
2.4. As BE is pretty heavy loaded with tasks

- Alexandr Antonenko


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Zhe (Joe) Wang]

> On April 22, 2016, 4 p.m., Andrii Tkach wrote:
> > ambari-web/app/controllers/wizard.js, line 749
> > 
> >
> > I don't think that's good approach to set maintenance_state to not 
> > installed hosts, it may cause confusion in the future.

1. Well, maintenance_state is OFF means that the host is not in maintainance, 
which is technically true in installation scenario.
2. We could, of course, ask BE to send the maintainance_state, while they are 
sending other properties (i.e. cpu, memory, os_type).
3. However, since we know that BE will always send maintenance_state: "OFF" 
during the installation, I think we could set it directly without create 
another BE JIRA to ask them to provide it.
4. After all, this tempprary model will be discarded after the installation. 
And it's quite safe to say, the host will remain the maintenance_state to be 
OFF during the installation.


- Zhe (Joe)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130109
---


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130111
---




ambari-web/app/mixins/wizard/assign_master_components.js (line 979)


We can check that maintenance_state is OFF, only when host has this 
property.


- Andrii Tkach


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130109
---




ambari-web/app/controllers/wizard.js (line 749)


I don't think that's good approach to set maintenance_state to not 
installed hosts, it may cause confusion in the future.


- Andrii Tkach


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130071
---


Ship it!




Ship It!

- Alexandr Antonenko


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Alexandr Antonenko]

> On April 21, 2016, 11:23 a.m., Alexandr Antonenko wrote:
> > ambari-web/app/mixins/wizard/assign_master_components.js, line 978
> > 
> >
> > This check can be simplified, after you added: 
> > "(this.get('hosts').filterProperty('host_name', 
> > selectedHost).filterProperty('maintenance_state', 'OFF').length > 0)" 
> > 
> > there is no need in :
> > 
> > "this.get('hosts').mapProperty('host_name').contains(selectedHost)"
> > 
> > 
> > This is because : "this.get('hosts').filterProperty('host_name', 
> > selectedHost)" will do the same thing as 
> > this.get('hosts').mapProperty('host_name').contains(selectedHost)

Sorry for bringing this up after review, saw this only after looking on 
committed changes. This can have bad effect if we have huge cluster with 
hundreds of hosts. So it's better to remove unnecessary check.


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review129878
---


On April 19, 2016, 8:36 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 19, 2016, 8:36 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg 
> Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js adce5ff 
>   ambari-web/app/mixins/wizard/assign_master_components.js cd8ef14 
>   ambari-web/app/utils/ajax/ajax.js a1d3f5f 
>   ambari-web/test/controllers/main/service/add_controller_test.js 90670a8 
>   ambari-web/test/controllers/wizard/step5_test.js 935d76d 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review129716
---


Ship it!




Ship It!

- Alexandr Antonenko


On April 19, 2016, 8:36 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 19, 2016, 8:36 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg 
> Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js adce5ff 
>   ambari-web/app/mixins/wizard/assign_master_components.js cd8ef14 
>   ambari-web/app/utils/ajax/ajax.js a1d3f5f 
>   ambari-web/test/controllers/main/service/add_controller_test.js 90670a8 
>   ambari-web/test/controllers/wizard/step5_test.js 935d76d 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>