Re: Review Request 46899: Disable alternate user search functionality by default

2016-05-03 Thread Laszlo Puskas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46899/#review131493
---


Ship it!




Ship It!

- Laszlo Puskas


On May 2, 2016, 8:01 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46899/
> ---
> 
> (Updated May 2, 2016, 8:01 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Laszlo Puskas, 
> Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-16205
> https://issues.apache.org/jira/browse/AMBARI-16205
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added `authentication.ldap.alternateUserSearchEnabled` configuration property 
> through which it can be controlled if the ldap alternate user search is 
> enabled or not. The default value for this property is `false.`
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  87f40d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  7b2a95c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  99ec786 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
>  f5d1412 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  b076e85 
> 
> Diff: https://reviews.apache.org/r/46899/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> Unit test results:
> Results :
> 
> Tests run: 4305, Failures: 0, Errors: 0, Skipped: 32
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>



Re: Review Request 46899: Disable alternate user search functionality by default

2016-05-03 Thread Sandor Magyari

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46899/#review131487
---


Ship it!




Ship It!

- Sandor Magyari


On May 2, 2016, 8:01 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46899/
> ---
> 
> (Updated May 2, 2016, 8:01 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Laszlo Puskas, 
> Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-16205
> https://issues.apache.org/jira/browse/AMBARI-16205
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added `authentication.ldap.alternateUserSearchEnabled` configuration property 
> through which it can be controlled if the ldap alternate user search is 
> enabled or not. The default value for this property is `false.`
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  87f40d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  7b2a95c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  99ec786 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
>  f5d1412 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  b076e85 
> 
> Diff: https://reviews.apache.org/r/46899/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> Unit test results:
> Results :
> 
> Tests run: 4305, Failures: 0, Errors: 0, Skipped: 32
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>



Re: Review Request 46899: Disable alternate user search functionality by default

2016-05-03 Thread Balázs Bence Sári

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46899/#review131486
---


Ship it!




Ship It!

- Balázs Bence Sári


On May 2, 2016, 8:01 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46899/
> ---
> 
> (Updated May 2, 2016, 8:01 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Laszlo Puskas, 
> Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-16205
> https://issues.apache.org/jira/browse/AMBARI-16205
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added `authentication.ldap.alternateUserSearchEnabled` configuration property 
> through which it can be controlled if the ldap alternate user search is 
> enabled or not. The default value for this property is `false.`
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  87f40d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  7b2a95c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  99ec786 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
>  f5d1412 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  b076e85 
> 
> Diff: https://reviews.apache.org/r/46899/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> Unit test results:
> Results :
> 
> Tests run: 4305, Failures: 0, Errors: 0, Skipped: 32
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>



Review Request 46899: Disable alternate user search functionality by default

2016-05-02 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46899/
---

Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Laszlo Puskas, 
Robert Levas, and Sandor Magyari.


Bugs: AMBARI-16205
https://issues.apache.org/jira/browse/AMBARI-16205


Repository: ambari


Description
---

Added `authentication.ldap.alternateUserSearchEnabled` configuration property 
through which it can be controlled if the ldap alternate user search is enabled 
or not. The default value for this property is `false.`


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 87f40d5 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
 7b2a95c 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 99ec786 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
 f5d1412 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
 b076e85 

Diff: https://reviews.apache.org/r/46899/diff/


Testing
---

Performed manual testing.

Unit test results:
Results :

Tests run: 4305, Failures: 0, Errors: 0, Skipped: 32


Thanks,

Sebastian Toader