Re: Review Request 46998: AMBARI-16264 Clean up local DB when get back to step 0 of installer wizard

2016-05-04 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46998/#review131780
---


Ship it!




Ship It!

- Jaimin Jetly


On May 5, 2016, 12:44 a.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46998/
> ---
> 
> (Updated May 5, 2016, 12:44 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi 
> Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16264
> https://issues.apache.org/jira/browse/AMBARI-16264
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After setting some options and then go back and next, all user inputs should 
> be reset to default values, but now some settings are restored and some are 
> reset. For example try to enable Skip Repository Base URL validation 
> (Advanced) and Use RedHat Satellite/Spacewalk checkboxes, then go back and 
> next and you will see, that first checkbox is still checked and second one is 
> unchecked, this is confusing.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step1_controller.js dc95a45 
>   ambari-web/app/routes/installer.js f280049 
> 
> Diff: https://reviews.apache.org/r/46998/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 27529 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>



Review Request 46998: AMBARI-16264 Clean up local DB when get back to step 0 of installer wizard

2016-05-04 Thread Zhe (Joe) Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46998/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi 
Wang, and Yusaku Sako.


Bugs: AMBARI-16264
https://issues.apache.org/jira/browse/AMBARI-16264


Repository: ambari


Description
---

After setting some options and then go back and next, all user inputs should be 
reset to default values, but now some settings are restored and some are reset. 
For example try to enable Skip Repository Base URL validation (Advanced) and 
Use RedHat Satellite/Spacewalk checkboxes, then go back and next and you will 
see, that first checkbox is still checked and second one is unchecked, this is 
confusing.


Diffs
-

  ambari-web/app/controllers/wizard/step1_controller.js dc95a45 
  ambari-web/app/routes/installer.js f280049 

Diff: https://reviews.apache.org/r/46998/diff/


Testing
---

Local ambari-web test passed.
27529 tests complete (23 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang