Re: Review Request 47009: Falcon server start fails

2016-05-12 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132953
---


Ship it!




Ship It!

- Sumit Mohanty


On May 11, 2016, 8:52 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
> 
> (Updated May 11, 2016, 8:52 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deployed HDP-2.5 and Falcon server failed to start.
> 
> 
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> 
> 
> The command to start, in Ambari is:
> 
> 
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
> 
> 
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for 
> falcon webapp itself. That step should not be done and we should change it to 
> add falcon hook into webapp.jar itself post deployment like what we do for 
> Oozie with prepare-war or added to server classpath explicitly
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  3fdf2e6 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  bf7f437 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
>  4b7c0c3 
> 
> Diff: https://reviews.apache.org/r/47009/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47009: Falcon server start fails

2016-05-11 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132824
---


Ship it!




Ship It!

- Venkat Ranganathan


On May 11, 2016, 1:52 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
> 
> (Updated May 11, 2016, 1:52 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deployed HDP-2.5 and Falcon server failed to start.
> 
> 
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> 
> 
> The command to start, in Ambari is:
> 
> 
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
> 
> 
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for 
> falcon webapp itself. That step should not be done and we should change it to 
> add falcon hook into webapp.jar itself post deployment like what we do for 
> Oozie with prepare-war or added to server classpath explicitly
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  3fdf2e6 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  bf7f437 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
>  4b7c0c3 
> 
> Diff: https://reviews.apache.org/r/47009/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47009: Falcon server start fails

2016-05-11 Thread Tom Beerbower 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/
---

(Updated May 11, 2016, 8:52 p.m.)


Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.


Changes
---

Updated diff


Bugs: AMBARI-16263
https://issues.apache.org/jira/browse/AMBARI-16263


Repository: ambari


Description
---

Deployed HDP-2.5 and Falcon server failed to start.


cat /var/log/falcon/falcon.out.20160504002*
Error: Could not find or load main class org.apache.falcon.FalconServer
Error: Could not find or load main class org.apache.falcon.FalconServer
Error: Could not find or load main class org.apache.falcon.FalconServer


The command to start, in Ambari is:


Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
{'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}


Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
/server/webapp/falcon/WEB-INF/lib/'
is what is causing it. If falcon webapp is already exploded it will fail for 
falcon webapp itself. That step should not be done and we should change it to 
add falcon hook into webapp.jar itself post deployment like what we do for 
Oozie with prepare-war or added to server classpath explicitly


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
 3fdf2e6 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 bf7f437 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
 4b7c0c3 

Diff: https://reviews.apache.org/r/47009/diff/


Testing
---

mvn clean test


Thanks,

Tom Beerbower

Re: Review Request 47009: Falcon server start fails

2016-05-10 Thread Tom Beerbower 


> On May 9, 2016, 9:49 p.m., Venkat Ranganathan wrote:
> >
> 
> Venkat Ranganathan wrote:
> We have committed a change as part of FALCON-1942 to add a environment 
> variable called FALCON_EXTRA_CLASS_PATH - this will be appended to the Falcon 
> server classpath.  Please use it

Great!  Thanks Venkat.


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132337
---


On May 5, 2016, 12:07 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
> 
> (Updated May 5, 2016, 12:07 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deployed HDP-2.5 and Falcon server failed to start.
> 
> 
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> 
> 
> The command to start, in Ambari is:
> 
> 
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
> 
> 
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for 
> falcon webapp itself. That step should not be done and we should change it to 
> add falcon hook into webapp.jar itself post deployment like what we do for 
> Oozie with prepare-war or added to server classpath explicitly
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  3fdf2e6 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  bf7f437 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
>  4b7c0c3 
> 
> Diff: https://reviews.apache.org/r/47009/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47009: Falcon server start fails

2016-05-10 Thread Venkat Ranganathan 


> On May 9, 2016, 2:49 p.m., Venkat Ranganathan wrote:
> >

We have committed a change as part of FALCON-1942 to add a environment variable 
called FALCON_EXTRA_CLASS_PATH - this will be appended to the Falcon server 
classpath.  Please use it


> On May 9, 2016, 2:49 p.m., Venkat Ranganathan wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml,
> >  line 162
> > 
> >
> > Don't we want the server classpath to be changed in falcon-config?
> 
> Tom Beerbower wrote:
> Thanks for the review.  I'm not familiar with falcon-config.  Could you 
> give more details?

I am thinking we should make Falcon server and client path to be customizable 
so that we can accommodate the hook easily.   This way the Atlas hook and 
dependent jars can be in their own location and the path customized.

Let me work through the Falcon side of things.   What needs to be done here is 
in your customization of falcon-env.sh, instead of setting HADOOP_CLASSPATH, 
you need to set a falcon env variable.   Will update the variable after fixing 
the falcon side of things


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132337
---


On May 5, 2016, 5:07 a.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
> 
> (Updated May 5, 2016, 5:07 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deployed HDP-2.5 and Falcon server failed to start.
> 
> 
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> 
> 
> The command to start, in Ambari is:
> 
> 
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
> 
> 
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for 
> falcon webapp itself. That step should not be done and we should change it to 
> add falcon hook into webapp.jar itself post deployment like what we do for 
> Oozie with prepare-war or added to server classpath explicitly
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  3fdf2e6 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  bf7f437 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
>  4b7c0c3 
> 
> Diff: https://reviews.apache.org/r/47009/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47009: Falcon server start fails

2016-05-10 Thread Tom Beerbower 


> On May 9, 2016, 9:49 p.m., Venkat Ranganathan wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml,
> >  line 162
> > 
> >
> > Don't we want the server classpath to be changed in falcon-config?

Thanks for the review.  I'm not familiar with falcon-config.  Could you give 
more details?


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132337
---


On May 5, 2016, 12:07 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
> 
> (Updated May 5, 2016, 12:07 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deployed HDP-2.5 and Falcon server failed to start.
> 
> 
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> 
> 
> The command to start, in Ambari is:
> 
> 
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
> 
> 
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for 
> falcon webapp itself. That step should not be done and we should change it to 
> add falcon hook into webapp.jar itself post deployment like what we do for 
> Oozie with prepare-war or added to server classpath explicitly
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  3fdf2e6 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  bf7f437 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
>  4b7c0c3 
> 
> Diff: https://reviews.apache.org/r/47009/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47009: Falcon server start fails

2016-05-09 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132337
---




ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
 (line 162)


Don't we want the server classpath to be changed in falcon-config?


- Venkat Ranganathan


On May 5, 2016, 5:07 a.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
> 
> (Updated May 5, 2016, 5:07 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deployed HDP-2.5 and Falcon server failed to start.
> 
> 
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> 
> 
> The command to start, in Ambari is:
> 
> 
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
> 
> 
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for 
> falcon webapp itself. That step should not be done and we should change it to 
> add falcon hook into webapp.jar itself post deployment like what we do for 
> Oozie with prepare-war or added to server classpath explicitly
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  3fdf2e6 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  bf7f437 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
>  4b7c0c3 
> 
> Diff: https://reviews.apache.org/r/47009/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Review Request 47009: Falcon server start fails

2016-05-05 Thread Tom Beerbower 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/
---

Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.


Bugs: AMBARI-16263
https://issues.apache.org/jira/browse/AMBARI-16263


Repository: ambari


Description
---

Deployed HDP-2.5 and Falcon server failed to start.


cat /var/log/falcon/falcon.out.20160504002*
Error: Could not find or load main class org.apache.falcon.FalconServer
Error: Could not find or load main class org.apache.falcon.FalconServer
Error: Could not find or load main class org.apache.falcon.FalconServer


The command to start, in Ambari is:


Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
{'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}


Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
/server/webapp/falcon/WEB-INF/lib/'
is what is causing it. If falcon webapp is already exploded it will fail for 
falcon webapp itself. That step should not be done and we should change it to 
add falcon hook into webapp.jar itself post deployment like what we do for 
Oozie with prepare-war or added to server classpath explicitly


Diffs
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
 3fdf2e6 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 bf7f437 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
 4b7c0c3 

Diff: https://reviews.apache.org/r/47009/diff/


Testing
---

mvn clean test


Thanks,

Tom Beerbower