Re: Review Request 47156: More information for Standby sync alert

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132557
---


Ship it!




Ship It!

- Lav Jain


On May 10, 2016, 10:22 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
> 
> (Updated May 10, 2016, 10:22 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Standby master is down (actually I removed it through API, and it got 
> deleted but somehow the configuration has the old IP) the hawq alert pops 
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with 
> HAWQMASTER".
> 
> If you take a close look at gp_master_mirroring table, it has more detailed 
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
> gp_master_mirroring;"
>   summary_state   |   detail_state   |log_time|   
>error_message
> --+--++--
>  Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error 
> received sending data to standby master: server closed the connection 
> unexpectedly
>   : This 
> probably means the server terminated abnormally
>   : 
> before or while processing the request.
>   :
> (1 row)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
>  c94be9e 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 
> 7d030dc 
> 
> Diff: https://reviews.apache.org/r/47156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 47156: More information for Standby sync alert

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/
---

(Updated May 10, 2016, 10:22 p.m.)


Review request for Ambari.


Bugs: AMBARI-16417
https://issues.apache.org/jira/browse/AMBARI-16417


Repository: ambari


Description
---

When Standby master is down (actually I removed it through API, and it got 
deleted but somehow the configuration has the old IP) the hawq alert pops up(, 
which is good) but only saying "HAWQSTANDBY is not in sync with HAWQMASTER".

If you take a close look at gp_master_mirroring table, it has more detailed 
information. (in this case, connection issue)
{code}
[gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
gp_master_mirroring;"
  summary_state   |   detail_state   |log_time| 
 error_message
--+--++--
 Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error received 
sending data to standby master: server closed the connection unexpectedly
  : This 
probably means the server terminated abnormally
  : before 
or while processing the request.
  :
(1 row)
{code}


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
 c94be9e 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 
7d030dc 

Diff: https://reviews.apache.org/r/47156/diff/


Testing
---


Thanks,

jun aoki

Re: Review Request 47156: More information for Standby sync alert

[jun aoki]

> On May 10, 2016, 9:53 p.m., Lav Jain wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py,
> >  line 93
> > 
> >
> > Please try to use one SQL statement. Delimiter can be defined using -F 
> > option. E.g.:
> > ```
> > source /usr/local/hawq/greenplum_path.sh && psql -F $'##' --no-align -t 
> > -d template1 -c "SELECT summary_state, error_message FROM 
> > gp_master_mirroring"
> > Not Synchronized##error received sending data to standby master: server 
> > closed the connection unexpectedly
> > This probably means the server terminated abnormally
> > before or while processing the request.
> > ```

Lav, this is a good stuff. I actually have to use --no-align option to not to 
be aligned.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132547
---


On May 10, 2016, 9:54 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
> 
> (Updated May 10, 2016, 9:54 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Standby master is down (actually I removed it through API, and it got 
> deleted but somehow the configuration has the old IP) the hawq alert pops 
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with 
> HAWQMASTER".
> 
> If you take a close look at gp_master_mirroring table, it has more detailed 
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
> gp_master_mirroring;"
>   summary_state   |   detail_state   |log_time|   
>error_message
> --+--++--
>  Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error 
> received sending data to standby master: server closed the connection 
> unexpectedly
>   : This 
> probably means the server terminated abnormally
>   : 
> before or while processing the request.
>   :
> (1 row)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
>  c94be9e 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 
> 7d030dc 
> 
> Diff: https://reviews.apache.org/r/47156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 47156: More information for Standby sync alert

[jun aoki]

> On May 10, 2016, 7:10 a.m., Matt wrote:
> >
> 
> Matt wrote:
> Please double check if any unit tests have to be updated.

will do


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132384
---


On May 10, 2016, 9:54 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
> 
> (Updated May 10, 2016, 9:54 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Standby master is down (actually I removed it through API, and it got 
> deleted but somehow the configuration has the old IP) the hawq alert pops 
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with 
> HAWQMASTER".
> 
> If you take a close look at gp_master_mirroring table, it has more detailed 
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
> gp_master_mirroring;"
>   summary_state   |   detail_state   |log_time|   
>error_message
> --+--++--
>  Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error 
> received sending data to standby master: server closed the connection 
> unexpectedly
>   : This 
> probably means the server terminated abnormally
>   : 
> before or while processing the request.
>   :
> (1 row)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
>  c94be9e 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 
> 7d030dc 
> 
> Diff: https://reviews.apache.org/r/47156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 47156: More information for Standby sync alert

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/
---

(Updated May 10, 2016, 9:54 p.m.)


Review request for Ambari.


Changes
---

Feedback applied


Bugs: AMBARI-16417
https://issues.apache.org/jira/browse/AMBARI-16417


Repository: ambari


Description
---

When Standby master is down (actually I removed it through API, and it got 
deleted but somehow the configuration has the old IP) the hawq alert pops up(, 
which is good) but only saying "HAWQSTANDBY is not in sync with HAWQMASTER".

If you take a close look at gp_master_mirroring table, it has more detailed 
information. (in this case, connection issue)
{code}
[gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
gp_master_mirroring;"
  summary_state   |   detail_state   |log_time| 
 error_message
--+--++--
 Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error received 
sending data to standby master: server closed the connection unexpectedly
  : This 
probably means the server terminated abnormally
  : before 
or while processing the request.
  :
(1 row)
{code}


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
 c94be9e 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 
7d030dc 

Diff: https://reviews.apache.org/r/47156/diff/


Testing
---


Thanks,

jun aoki

Re: Review Request 47156: More information for Standby sync alert

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132547
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
 (line 93)


Please try to use one SQL statement. Delimiter can be defined using -F 
option. E.g.:
```
source /usr/local/hawq/greenplum_path.sh && psql -F $'##' --no-align -t -d 
template1 -c "SELECT summary_state, error_message FROM gp_master_mirroring"
Not Synchronized##error received sending data to standby master: server 
closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
```


- Lav Jain


On May 10, 2016, 4:27 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
> 
> (Updated May 10, 2016, 4:27 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Standby master is down (actually I removed it through API, and it got 
> deleted but somehow the configuration has the old IP) the hawq alert pops 
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with 
> HAWQMASTER".
> 
> If you take a close look at gp_master_mirroring table, it has more detailed 
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
> gp_master_mirroring;"
>   summary_state   |   detail_state   |log_time|   
>error_message
> --+--++--
>  Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error 
> received sending data to standby master: server closed the connection 
> unexpectedly
>   : This 
> probably means the server terminated abnormally
>   : 
> before or while processing the request.
>   :
> (1 row)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
>  c94be9e 
> 
> Diff: https://reviews.apache.org/r/47156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 47156: More information for Standby sync alert

[jun aoki]

> On May 10, 2016, 7:10 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py,
> >  line 68
> > 
> >
> > Would be better to have **'HAWQSTANDBY is not in sync with HAWQMASTER. 
> > ERROR: ' + error_message**

will fix


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132384
---


On May 10, 2016, 4:27 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
> 
> (Updated May 10, 2016, 4:27 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Standby master is down (actually I removed it through API, and it got 
> deleted but somehow the configuration has the old IP) the hawq alert pops 
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with 
> HAWQMASTER".
> 
> If you take a close look at gp_master_mirroring table, it has more detailed 
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
> gp_master_mirroring;"
>   summary_state   |   detail_state   |log_time|   
>error_message
> --+--++--
>  Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error 
> received sending data to standby master: server closed the connection 
> unexpectedly
>   : This 
> probably means the server terminated abnormally
>   : 
> before or while processing the request.
>   :
> (1 row)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
>  c94be9e 
> 
> Diff: https://reviews.apache.org/r/47156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 47156: More information for Standby sync alert

[Matt]

> On May 10, 2016, 12:10 a.m., Matt wrote:
> >

Please double check if any unit tests have to be updated.


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132384
---


On May 9, 2016, 9:27 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47156/
> ---
> 
> (Updated May 9, 2016, 9:27 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16417
> https://issues.apache.org/jira/browse/AMBARI-16417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Standby master is down (actually I removed it through API, and it got 
> deleted but somehow the configuration has the old IP) the hawq alert pops 
> up(, which is good) but only saying "HAWQSTANDBY is not in sync with 
> HAWQMASTER".
> 
> If you take a close look at gp_master_mirroring table, it has more detailed 
> information. (in this case, connection issue)
> {code}
> [gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
> gp_master_mirroring;"
>   summary_state   |   detail_state   |log_time|   
>error_message
> --+--++--
>  Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error 
> received sending data to standby master: server closed the connection 
> unexpectedly
>   : This 
> probably means the server terminated abnormally
>   : 
> before or while processing the request.
>   :
> (1 row)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
>  c94be9e 
> 
> Diff: https://reviews.apache.org/r/47156/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Review Request 47156: More information for Standby sync alert

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/
---

Review request for Ambari.


Bugs: AMBARI-16417
https://issues.apache.org/jira/browse/AMBARI-16417


Repository: ambari


Description
---

When Standby master is down (actually I removed it through API, and it got 
deleted but somehow the configuration has the old IP) the hawq alert pops up(, 
which is good) but only saying "HAWQSTANDBY is not in sync with HAWQMASTER".

If you take a close look at gp_master_mirroring table, it has more detailed 
information. (in this case, connection issue)
{code}
[gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
gp_master_mirroring;"
  summary_state   |   detail_state   |log_time| 
 error_message
--+--++--
 Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error received 
sending data to standby master: server closed the connection unexpectedly
  : This 
probably means the server terminated abnormally
  : before 
or while processing the request.
  :
(1 row)
{code}


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
 c94be9e 

Diff: https://reviews.apache.org/r/47156/diff/


Testing
---


Thanks,

jun aoki