Re: Review Request 47184: AMBARI-16435 : Change Namenode Total File operations widget to request rate metric instead of actual metric.

2016-05-10 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47184/#review132539
---


Ship it!




Ship It!

- Jaimin Jetly


On May 10, 2016, 7:45 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47184/
> ---
> 
> (Updated May 10, 2016, 7:45 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-16435
> https://issues.apache.org/jira/browse/AMBARI-16435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change since Total File operations is a counter metric and is useful as a 
> rate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  8c49ab4 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> 98c1f86 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  11f3865 
> 
> Diff: https://reviews.apache.org/r/47184/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade. 
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>



Re: Review Request 47184: AMBARI-16435 : Change Namenode Total File operations widget to request rate metric instead of actual metric.

2016-05-10 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47184/#review132534
---


Ship it!




Ship It!

- Sumit Mohanty


On May 10, 2016, 7:45 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47184/
> ---
> 
> (Updated May 10, 2016, 7:45 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-16435
> https://issues.apache.org/jira/browse/AMBARI-16435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change since Total File operations is a counter metric and is useful as a 
> rate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  8c49ab4 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> 98c1f86 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  11f3865 
> 
> Diff: https://reviews.apache.org/r/47184/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade. 
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>



Review Request 47184: AMBARI-16435 : Change Namenode Total File operations widget to request rate metric instead of actual metric.

2016-05-10 Thread Aravindan Vijayan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47184/
---

Review request for Ambari, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Sid 
Wagle.


Bugs: AMBARI-16435
https://issues.apache.org/jira/browse/AMBARI-16435


Repository: ambari


Description
---

Change since Total File operations is a counter metric and is useful as a rate.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 8c49ab4 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
98c1f86 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 11f3865 

Diff: https://reviews.apache.org/r/47184/diff/


Testing
---

Manually tested upgrade. 
Unit tests pass.


Thanks,

Aravindan Vijayan