---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47206/#review132589
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 11, 2016, 12:30 a.m., Richard Zang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47206/
> ---
>
> (Updated May 11, 2016, 12:30 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang.
>
>
> Bugs: AMBARI-16441
> https://issues.apache.org/jira/browse/AMBARI-16441
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Add help page popup on user listing page as well.
> Add close button on help page header.
>
>
> Diffs
> -
>
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js
> c92374b
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
> 32f46c1
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RoleDetailsModal.js
> eced664
>
> ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html
> e3bbcdc
>
> ambari-admin/src/main/resources/ui/admin-web/app/views/modals/RoleDetailsModal.html
> 74a1807
>
> Diff: https://reviews.apache.org/r/47206/diff/
>
>
> Testing
> ---
>
> Manually tested on live cluster.
> All unit tests passed.
>
> PhantomJS 1.9.7 (Mac OS X): Executed 64 of 64 SUCCESS (0.211 secs / 0.418
> secs)
>
>
> Thanks,
>
> Richard Zang
>
>