Re: Review Request 47513: AMBARI-16723 Stack id needs to be handled differently according to its source
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47513/#review133787 --- Ship it! Ship It! - Jaimin Jetly On May 18, 2016, 6:24 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47513/ > --- > > (Updated May 18, 2016, 6:24 p.m.) > > > Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, > and Yusaku Sako. > > > Bugs: AMBARI-16723 > https://issues.apache.org/jira/browse/AMBARI-16723 > > > Repository: ambari > > > Description > --- > > For default stacks, stack id contains stack name and stack version, while for > others, it should be "stack + "-" + stack_version + "-" + vdf_version" > > > Diffs > - > > ambari-web/app/controllers/installer.js 421f2dc > ambari-web/app/mappers/stack_mapper.js 473c466 > > Diff: https://reviews.apache.org/r/47513/diff/ > > > Testing > --- > > Local ambari-web test passed. > 27819 tests complete (23 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 47513: AMBARI-16723 Stack id needs to be handled differently according to its source
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47513/ --- (Updated May 18, 2016, 6:24 p.m.) Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-16723 https://issues.apache.org/jira/browse/AMBARI-16723 Repository: ambari Description --- For default stacks, stack id contains stack name and stack version, while for others, it should be "stack + "-" + stack_version + "-" + vdf_version" Diffs (updated) - ambari-web/app/controllers/installer.js 421f2dc ambari-web/app/mappers/stack_mapper.js 473c466 Diff: https://reviews.apache.org/r/47513/diff/ Testing --- Local ambari-web test passed. 27819 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Review Request 47513: AMBARI-16723 Stack id needs to be handled differently according to its source
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47513/ --- Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-16723 https://issues.apache.org/jira/browse/AMBARI-16723 Repository: ambari Description --- For default stacks, stack id contains stack name and stack version, while for others, it should be "stack + "-" + stack_version + "-" + vdf_version" Diffs - ambari-web/app/controllers/installer.js 421f2dc ambari-web/app/mappers/stack_mapper.js 473c466 Diff: https://reviews.apache.org/r/47513/diff/ Testing --- Local ambari-web test passed. 27819 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang