Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133935
---


Ship it!




Ship It!

- Andrew Onischuk


On May 19, 2016, 11:56 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 19, 2016, 11:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> eca7825 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/
---

(Updated May 19, 2016, 11:56 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Address Andrew's comment


Bugs: AMBARI-16727
https://issues.apache.org/jira/browse/AMBARI-16727


Repository: ambari


Description
---

Adding sleep time of 15 seconds after execution of stop command as Ranger Admin 
process requires time to stop. Once the logic for pid is available from Ranger 
code, will update the code.


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
eca7825 

Diff: https://reviews.apache.org/r/47529/diff/


Testing
---

Tested Ranger on centos 6


Thanks,

Mugdha Varadkar

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133933
---




ambari-common/src/main/python/resource_management/libraries/script/script.py 
(line 661)


let's call it services_to_skip


- Andrew Onischuk


On May 19, 2016, 11:30 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 19, 2016, 11:30 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> eca7825 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/
---

(Updated May 19, 2016, 11:30 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Address Alejandro Fernandez comment and Adding Ranger KMS also to skip 
self.status(env)


Bugs: AMBARI-16727
https://issues.apache.org/jira/browse/AMBARI-16727


Repository: ambari


Description
---

Adding sleep time of 15 seconds after execution of stop command as Ranger Admin 
process requires time to stop. Once the logic for pid is available from Ranger 
code, will update the code.


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
eca7825 

Diff: https://reviews.apache.org/r/47529/diff/


Testing
---

Tested Ranger on centos 6


Thanks,

Mugdha Varadkar

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Mugdha Varadkar]

> On May 18, 2016, 6:14 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py,
> >  line 661
> > 
> >
> > No need to check for None.
> > 
> > Is there already a Jira to track the fix for the pid for Ranger?

https://issues.apache.org/jira/browse/AMBARI-16756


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133779
---


On May 18, 2016, 11:59 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 18, 2016, 11:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> cbf313e 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 98a0b38 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133779
---




ambari-common/src/main/python/resource_management/libraries/script/script.py 
(line 661)


No need to check for None.

Is there already a Jira to track the fix for the pid for Ranger?


- Alejandro Fernandez


On May 18, 2016, 11:59 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 18, 2016, 11:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> cbf313e 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 98a0b38 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133726
---


Ship it!




Ship It!

- Andrew Onischuk


On May 18, 2016, 11:59 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 18, 2016, 11:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> cbf313e 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 98a0b38 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/
---

(Updated May 18, 2016, 11:59 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Address Andrew Onishuk comment For adding service_name=="RANGER" check in 
script.py for calling self.status(env)


Bugs: AMBARI-16727
https://issues.apache.org/jira/browse/AMBARI-16727


Repository: ambari


Description
---

Adding sleep time of 15 seconds after execution of stop command as Ranger Admin 
process requires time to stop. Once the logic for pid is available from Ranger 
code, will update the code.


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
cbf313e 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
98a0b38 

Diff: https://reviews.apache.org/r/47529/diff/


Testing
---

Tested Ranger on centos 6


Thanks,

Mugdha Varadkar

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Andrew Onischuk]

> On May 18, 2016, 10:27 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py,
> >  line 56
> > 
> >
> > Can we monitor self.status until the stop is done. Or skip the check in 
> > script.py.
> > 
> > This we be a major slownload for 'Stop all' considering it takes ~40s 
> > as of now.

Another solution is to skip that check in script.py if service_name=="RANGER". 
If that is acceptable to stop afterwards Ambari stop command.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133721
---


On May 18, 2016, 10:22 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 18, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  1ffbbde 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c015367 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133721
---




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 (line 56)


Can we monitor self.status until the stop is done. Or skip the check in 
script.py.

This we be a major slownload for 'Stop all' considering it takes ~40s as of 
now.


- Andrew Onischuk


On May 18, 2016, 10:22 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 18, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  1ffbbde 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c015367 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-16727
https://issues.apache.org/jira/browse/AMBARI-16727


Repository: ambari


Description
---

Adding sleep time of 15 seconds after execution of stop command as Ranger Admin 
process requires time to stop. Once the logic for pid is available from Ranger 
code, will update the code.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
 1ffbbde 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 c015367 

Diff: https://reviews.apache.org/r/47529/diff/


Testing
---

Tested Ranger on centos 6


Thanks,

Mugdha Varadkar