Re: Review Request 47537: View log files should pickup ambari-server log directory path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47537/#review134015 --- Ship it! Ship It! - Rohit Choudhary On May 18, 2016, 3:07 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47537/ > --- > > (Updated May 18, 2016, 3:07 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16734 > https://issues.apache.org/jira/browse/AMBARI-16734 > > > Repository: ambari > > > Description > --- > > Earlier : views had to hardcode the log directory as the variable > ambari.log.dir was not available inside view.log4j.properties file. > > In this patch : view.log4j.properties of view can now use all the ambari > properties including ambari.log.dir of ambari's log4j.properties > > > Diffs > - > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 6d4ef82 > > Diff: https://reviews.apache.org/r/47537/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47537: View log files should pickup ambari-server log directory path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47537/#review133917 --- Ship it! Ship It! - Pallav Kulshreshtha On May 18, 2016, 3:07 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47537/ > --- > > (Updated May 18, 2016, 3:07 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16734 > https://issues.apache.org/jira/browse/AMBARI-16734 > > > Repository: ambari > > > Description > --- > > Earlier : views had to hardcode the log directory as the variable > ambari.log.dir was not available inside view.log4j.properties file. > > In this patch : view.log4j.properties of view can now use all the ambari > properties including ambari.log.dir of ambari's log4j.properties > > > Diffs > - > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 6d4ef82 > > Diff: https://reviews.apache.org/r/47537/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Review Request 47537: View log files should pickup ambari-server log directory path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47537/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-16734 https://issues.apache.org/jira/browse/AMBARI-16734 Repository: ambari Description --- Earlier : views had to hardcode the log directory as the variable ambari.log.dir was not available inside view.log4j.properties file. In this patch : view.log4j.properties of view can now use all the ambari properties including ambari.log.dir of ambari's log4j.properties Diffs - ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 6d4ef82 Diff: https://reviews.apache.org/r/47537/diff/ Testing --- manual testing done. Thanks, Nitiraj Rathore
