Re: Review Request 47540: [Hive View]Unavailable Column Search should throw 'No Match' message

2016-05-21 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47540/#review134237
---


Ship it!




Ship It!

- Nitiraj Rathore


On May 20, 2016, 6:21 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47540/
> ---
> 
> (Updated May 20, 2016, 6:21 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16738
> https://issues.apache.org/jira/browse/AMBARI-16738
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a boolean variable for showing 'no columns match' alert.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js
>  b76bca3 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
> d2f6aaf 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases-search-results.hbs
>  007d9ca 
> 
> Diff: https://reviews.apache.org/r/47540/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 47540: [Hive View]Unavailable Column Search should throw 'No Match' message

2016-05-20 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47540/
---

(Updated May 20, 2016, 6:21 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16738
https://issues.apache.org/jira/browse/AMBARI-16738


Repository: ambari


Description
---

Added a boolean variable for showing 'no columns match' alert.


Diffs (updated)
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js 
b76bca3 
  contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
d2f6aaf 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases-search-results.hbs
 007d9ca 

Diff: https://reviews.apache.org/r/47540/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha



Re: Review Request 47540: [Hive View]Unavailable Column Search should throw 'No Match' message

2016-05-19 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47540/#review133906
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 18, 2016, 4:15 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47540/
> ---
> 
> (Updated May 18, 2016, 4:15 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16738
> https://issues.apache.org/jira/browse/AMBARI-16738
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a boolean variable for showing 'no columns match' alert.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js
>  b76bca3 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
> d2f6aaf 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases-search-results.hbs
>  007d9ca 
> 
> Diff: https://reviews.apache.org/r/47540/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Review Request 47540: [Hive View]Unavailable Column Search should throw 'No Match' message

2016-05-18 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47540/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16738
https://issues.apache.org/jira/browse/AMBARI-16738


Repository: ambari


Description
---

Added a boolean variable for showing 'no columns match' alert.


Diffs
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js 
b76bca3 
  contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
d2f6aaf 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases-search-results.hbs
 007d9ca 

Diff: https://reviews.apache.org/r/47540/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha