subject:"Review Request 47579\: Spark2 service definition for Ambari"

Re: Review Request 47579: Spark2 service definition for Ambari

2016-06-02 Thread Jayush Luniya



> On May 25, 2016, 8:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py,
> >  line 25
> > 
> >
> > Use explicit import
> 
> Jayush Luniya wrote:
> Sorry I missed these. Saisai, can you include these changes with 
> AMBARI-16864

@Saisai can you close this review?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/#review134827
---


On May 23, 2016, 2:55 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47579/
> ---
> 
> (Updated May 23, 2016, 2:55 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16753
> https://issues.apache.org/jira/browse/AMBARI-16753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Spark2 service definition for Ambari
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47579/diff/
> 
> 
> Testing
> ---
> 
> Local manual test
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 47579: Spark2 service definition for Ambari

2016-05-26 Thread Jayush Luniya



> On May 25, 2016, 8:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py,
> >  line 25
> > 
> >
> > Use explicit import

Sorry I missed these. Saisai, can you include these changes with AMBARI-16864


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/#review134827
---


On May 23, 2016, 2:55 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47579/
> ---
> 
> (Updated May 23, 2016, 2:55 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16753
> https://issues.apache.org/jira/browse/AMBARI-16753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Spark2 service definition for Ambari
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47579/diff/
> 
> 
> Testing
> ---
> 
> Local manual test
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 47579: Spark2 service definition for Ambari

2016-05-25 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/#review134827
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
 (line 42)


Good



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
 (line 33)


Use explicit import



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
 (line 21)


Use explicit import



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
 (line 25)


Use explicit import


- Alejandro Fernandez


On May 23, 2016, 2:55 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47579/
> ---
> 
> (Updated May 23, 2016, 2:55 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16753
> https://issues.apache.org/jira/browse/AMBARI-16753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Spark2 service definition for Ambari
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47579/diff/
> 
> 
> Testing
> ---
> 
> Local manual test
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 47579: Spark2 service definition for Ambari

2016-05-22 Thread Saisai Shao



> On May 22, 2016, 1:28 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml,
> >  line 71
> > 
> >
> > spark2-env

Same as above.


- Saisai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/#review134269
---


On May 23, 2016, 2:55 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47579/
> ---
> 
> (Updated May 23, 2016, 2:55 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16753
> https://issues.apache.org/jira/browse/AMBARI-16753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Spark2 service definition for Ambari
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47579/diff/
> 
> 
> Testing
> ---
> 
> Local manual test
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 47579: Spark2 service definition for Ambari

2016-05-22 Thread Saisai Shao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/
---

(Updated May 23, 2016, 2:55 a.m.)


Review request for Ambari, Jayush Luniya and Sumit Mohanty.


Bugs: AMBARI-16753
https://issues.apache.org/jira/browse/AMBARI-16753


Repository: ambari


Description
---

Add Spark2 service definition for Ambari


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47579/diff/


Testing
---

Local manual test


Thanks,

Saisai Shao

Re: Review Request 47579: Spark2 service definition for Ambari

2016-05-22 Thread Saisai Shao



> On May 22, 2016, 1:28 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml,
> >  line 63
> > 
> >
> > spark2-env

Actually we don't change the generated spark env file name, still 
"spark-env.sh", so I don't think it is necessary to change here.


> On May 22, 2016, 1:28 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml,
> >  line 66
> > 
> >
> > spark2-env

Same as above


> On May 22, 2016, 1:28 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml,
> >  line 78
> > 
> >
> > Does this need to be defined as Spark2?

Not necessary.


> On May 22, 2016, 1:28 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml,
> >  line 26
> > 
> >
> > Make sure metrics for Spark and Spark2 are separated out.

There's no problem from my understanding.


- Saisai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/#review134269
---


On May 19, 2016, 5:50 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47579/
> ---
> 
> (Updated May 19, 2016, 5:50 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16753
> https://issues.apache.org/jira/browse/AMBARI-16753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Spark2 service definition for Ambari
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47579/diff/
> 
> 
> Testing
> ---
> 
> Local manual test
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 47579: Spark2 service definition for Ambari

2016-05-22 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/#review134269
---




ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json (line 
13)


should be spark2-defaults?



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
 (line 50)


spark2-history instead?



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
 (line 82)


spark2-history instead?



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 (line 63)


spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 (line 66)


spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 (line 71)


spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 (line 78)


Does this need to be defined as Spark2?



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
 (line 25)


spark2-log4j-properties



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
 (line 24)


spark2-metrics-properties



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
 (line 26)


Make sure metrics for Spark and Spark2 are separated out.



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
(line 12)


spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
(line 14)


spark2-defaults



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
(line 15)


spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
(line 20)


spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
(line 27)


spark2-defaults


- Jayush Luniya


On May 19, 2016, 5:50 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47579/
> ---
> 
> (Updated May 19, 2016, 5:50 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16753
> https://issues.apache.org/jira/browse/AMBARI-16753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Spark2 service definition for Ambari
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
>

Review Request 47579: Spark2 service definition for Ambari

2016-05-18 Thread Saisai Shao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/
---

Review request for Ambari, Jayush Luniya and Sumit Mohanty.


Bugs: AMBARI-16753
https://issues.apache.org/jira/browse/AMBARI-16753


Repository: ambari


Description
---

Add Spark2 service definition for Ambari


Diffs
-

  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47579/diff/


Testing
---

Local manual test


Thanks,

Saisai Shao

Re: Review Request 47579: Spark2 service definition for Ambari

Re: Review Request 47579: Spark2 service definition for Ambari

Re: Review Request 47579: Spark2 service definition for Ambari

Re: Review Request 47579: Spark2 service definition for Ambari

Re: Review Request 47579: Spark2 service definition for Ambari

Re: Review Request 47579: Spark2 service definition for Ambari

Re: Review Request 47579: Spark2 service definition for Ambari

Review Request 47579: Spark2 service definition for Ambari

8 matches

Site Navigation

Mail list logo

Footer information