Re: Review Request 47604: View URLs: UX edits #4

2016-05-20 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47604/#review134126
---


Ship it!




Ship It!

- Nitiraj Rathore


On May 20, 2016, 6:57 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47604/
> ---
> 
> (Updated May 20, 2016, 6:57 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16771
> https://issues.apache.org/jira/browse/AMBARI-16771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> minor UX changes for short URL
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
>  2b1fb3b 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> 3ed2687 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> 3a69a50 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  2481d59 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
>  e0b8a4e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
> c98ec3e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 
> 9e0ef4c 
> 
> Diff: https://reviews.apache.org/r/47604/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47604: View URLs: UX edits #4

2016-05-19 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47604/
---

(Updated May 20, 2016, 6:57 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Ashwin Rajeev.


Bugs: AMBARI-16771
https://issues.apache.org/jira/browse/AMBARI-16771


Repository: ambari


Description
---

minor UX changes for short URL


Diffs (updated)
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
 2b1fb3b 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
3ed2687 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c 
  ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
3a69a50 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
 2481d59 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
 e0b8a4e 
  ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
c98ec3e 
  ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 9e0ef4c 

Diff: https://reviews.apache.org/r/47604/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 47604: View URLs: UX edits #4

2016-05-19 Thread Ashwin Rajeev 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47604/#review133993
---


Ship it!




Fix it then ship it

- Ashwin Rajeev


On May 19, 2016, 4:38 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47604/
> ---
> 
> (Updated May 19, 2016, 4:38 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16771
> https://issues.apache.org/jira/browse/AMBARI-16771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> minor UX changes for short URL
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
>  2b1fb3b 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> d7dc9c7 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> 3a69a50 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  2481d59 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
>  e0b8a4e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
> c98ec3e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 
> 9e0ef4c 
> 
> Diff: https://reviews.apache.org/r/47604/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47604: View URLs: UX edits #4

2016-05-19 Thread Ashwin Rajeev 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47604/#review133992
---




ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
 (line 446)


pls remove console.log


- Ashwin Rajeev


On May 19, 2016, 4:38 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47604/
> ---
> 
> (Updated May 19, 2016, 4:38 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16771
> https://issues.apache.org/jira/browse/AMBARI-16771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> minor UX changes for short URL
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
>  2b1fb3b 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> d7dc9c7 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> 3a69a50 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  2481d59 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
>  e0b8a4e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
> c98ec3e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 
> 9e0ef4c 
> 
> Diff: https://reviews.apache.org/r/47604/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 47604: View URLs: UX edits #4

2016-05-19 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47604/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16771
https://issues.apache.org/jira/browse/AMBARI-16771


Repository: ambari


Description
---

minor UX changes for short URL


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
 2b1fb3b 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
d7dc9c7 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c 
  ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
3a69a50 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
 2481d59 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
 e0b8a4e 
  ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
c98ec3e 
  ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 9e0ef4c 

Diff: https://reviews.apache.org/r/47604/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha