Re: Review Request 47673: Wrong memory conf in spark-env.xml

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47673/#review136915
---



Pushed to trunk, commit 9b116fb28db774bb30a2d0c8e2f070e3b7c6d55d
branch-2.4, commit 078833a360bd32c26349ba11b684f8344d173b84

- Alejandro Fernandez


On June 3, 2016, 11:01 p.m., Weiqing Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47673/
> ---
> 
> (Updated June 3, 2016, 11:01 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16715
> https://issues.apache.org/jira/browse/AMBARI-16715
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In spark-env.xml, the memory value should not have space and a extra "b" 
> character. "SPARK_DRIVER_MEMORY="512 Mb" #Memory for Master (e.g. 1000M, 2G) 
> (Default: 512 Mb)", by default this line is commented but in case user 
> uncommented it to change the memory settings then it will show a below error, 
> so it's better to change it in the default template.
> Error:
> ./bin/spark-shell
> Error: Could not find or load main class Mb
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  34c5462 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  c5fcc85 
> 
> Diff: https://reviews.apache.org/r/47673/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Weiqing Yang
> 
>

Re: Review Request 47673: Wrong memory conf in spark-env.xml

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47673/#review136884
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 3, 2016, 11:01 p.m., Weiqing Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47673/
> ---
> 
> (Updated June 3, 2016, 11:01 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16715
> https://issues.apache.org/jira/browse/AMBARI-16715
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In spark-env.xml, the memory value should not have space and a extra "b" 
> character. "SPARK_DRIVER_MEMORY="512 Mb" #Memory for Master (e.g. 1000M, 2G) 
> (Default: 512 Mb)", by default this line is commented but in case user 
> uncommented it to change the memory settings then it will show a below error, 
> so it's better to change it in the default template.
> Error:
> ./bin/spark-shell
> Error: Could not find or load main class Mb
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  34c5462 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  c5fcc85 
> 
> Diff: https://reviews.apache.org/r/47673/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Weiqing Yang
> 
>

Re: Review Request 47673: Wrong memory conf in spark-env.xml

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47673/#review136129
---




ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
 (line 92)


For existing clusters with HDP 2.x, should they change this value when they 
upgrade Ambari and/or the stack to HDP 2.(x+1)?


- Alejandro Fernandez


On June 3, 2016, 11:01 p.m., Weiqing Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47673/
> ---
> 
> (Updated June 3, 2016, 11:01 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16715
> https://issues.apache.org/jira/browse/AMBARI-16715
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In spark-env.xml, the memory value should not have space and a extra "b" 
> character. "SPARK_DRIVER_MEMORY="512 Mb" #Memory for Master (e.g. 1000M, 2G) 
> (Default: 512 Mb)", by default this line is commented but in case user 
> uncommented it to change the memory settings then it will show a below error, 
> so it's better to change it in the default template.
> Error:
> ./bin/spark-shell
> Error: Could not find or load main class Mb
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  34c5462 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  c5fcc85 
> 
> Diff: https://reviews.apache.org/r/47673/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Weiqing Yang
> 
>

Re: Review Request 47673: Wrong memory conf in spark-env.xml

[Weiqing Yang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47673/
---

(Updated June 3, 2016, 11:01 p.m.)


Review request for Ambari and Sumit Mohanty.


Changes
---

Make change to Spark2


Bugs: AMBARI-16715
https://issues.apache.org/jira/browse/AMBARI-16715


Repository: ambari


Description
---

In spark-env.xml, the memory value should not have space and a extra "b" 
character. "SPARK_DRIVER_MEMORY="512 Mb" #Memory for Master (e.g. 1000M, 2G) 
(Default: 512 Mb)", by default this line is commented but in case user 
uncommented it to change the memory settings then it will show a below error, 
so it's better to change it in the default template.
Error:
./bin/spark-shell
Error: Could not find or load main class Mb


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
 34c5462 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 c5fcc85 

Diff: https://reviews.apache.org/r/47673/diff/


Testing
---

N/A


Thanks,

Weiqing Yang

Re: Review Request 47673: Wrong memory conf in spark-env.xml

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47673/#review134213
---


Ship it!




Ship It!

- Sumit Mohanty


On May 20, 2016, 10:15 p.m., Weiqing Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47673/
> ---
> 
> (Updated May 20, 2016, 10:15 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16715
> https://issues.apache.org/jira/browse/AMBARI-16715
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In spark-env.xml, the memory value should not have space and a extra "b" 
> character. "SPARK_DRIVER_MEMORY="512 Mb" #Memory for Master (e.g. 1000M, 2G) 
> (Default: 512 Mb)", by default this line is commented but in case user 
> uncommented it to change the memory settings then it will show a below error, 
> so it's better to change it in the default template.
> Error:
> ./bin/spark-shell
> Error: Could not find or load main class Mb
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  8a5117a 
> 
> Diff: https://reviews.apache.org/r/47673/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Weiqing Yang
> 
>

Review Request 47673: Wrong memory conf in spark-env.xml

[Weiqing Yang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47673/
---

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-16715
https://issues.apache.org/jira/browse/AMBARI-16715


Repository: ambari


Description
---

In spark-env.xml, the memory value should not have space and a extra "b" 
character. "SPARK_DRIVER_MEMORY="512 Mb" #Memory for Master (e.g. 1000M, 2G) 
(Default: 512 Mb)", by default this line is commented but in case user 
uncommented it to change the memory settings then it will show a below error, 
so it's better to change it in the default template.
Error:
./bin/spark-shell
Error: Could not find or load main class Mb


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
 8a5117a 

Diff: https://reviews.apache.org/r/47673/diff/


Testing
---

N/A


Thanks,

Weiqing Yang