Re: Review Request 47767: Hive view : Upload table view throws exception but does not shows what is wrong with the submitted table creation.

2016-05-25 Thread Rohit Choudhary

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47767/#review134722
---


Ship it!




Ship It!

- Rohit Choudhary


On May 24, 2016, 10:38 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47767/
> ---
> 
> (Updated May 24, 2016, 10:38 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-16428
> https://issues.apache.org/jira/browse/AMBARI-16428
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In this patch : more appropriate exception messages are shown ui by calling 
> /jobs REST api instead of /jobStatus API.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  7a46fd0 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  f2e2f5e 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/job.js 
> 6cb4170 
> 
> Diff: https://reviews.apache.org/r/47767/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 47767: Hive view : Upload table view throws exception but does not shows what is wrong with the submitted table creation.

2016-05-24 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47767/#review134568
---


Ship it!




Ship It!

- Gaurav Nagar


On May 24, 2016, 10:38 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47767/
> ---
> 
> (Updated May 24, 2016, 10:38 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-16428
> https://issues.apache.org/jira/browse/AMBARI-16428
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In this patch : more appropriate exception messages are shown ui by calling 
> /jobs REST api instead of /jobStatus API.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  7a46fd0 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  f2e2f5e 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/job.js 
> 6cb4170 
> 
> Diff: https://reviews.apache.org/r/47767/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Review Request 47767: Hive view : Upload table view throws exception but does not shows what is wrong with the submitted table creation.

2016-05-24 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47767/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
and Rohit Choudhary.


Bugs: AMBARI-16428
https://issues.apache.org/jira/browse/AMBARI-16428


Repository: ambari


Description
---

In this patch : more appropriate exception messages are shown ui by calling 
/jobs REST api instead of /jobStatus API.


Diffs
-

  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
 7a46fd0 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 f2e2f5e 
  contrib/views/hive/src/main/resources/ui/hive-web/app/services/job.js 6cb4170 

Diff: https://reviews.apache.org/r/47767/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore