Re: Review Request 47811: AMBARI-16862 : [Grafana] Rename "HBase - Performance" dashboard to "HBase - RegionServers"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47811/#review134770 --- Ship it! Looks like the lookup API does not return originalTitle. - Sumit Mohanty On May 25, 2016, 2:56 a.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47811/ > --- > > (Updated May 25, 2016, 2:56 a.m.) > > > Review request for Ambari, Dmytro Sen, Prajwal Rao, Sumit Mohanty, Sid Wagle, > and Yusaku Sako. > > > Bugs: AMBARI-16862 > https://issues.apache.org/jira/browse/AMBARI-16862 > > > Repository: ambari > > > Description > --- > > Rename dashboard > > Add special logic in Grafana start script. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-performance.json > 50e20a3 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-regionservers.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py > a02c100 > > Diff: https://reviews.apache.org/r/47811/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Aravindan Vijayan > >
Re: Review Request 47811: AMBARI-16862 : [Grafana] Rename "HBase - Performance" dashboard to "HBase - RegionServers"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47811/#review134691 --- Just wondering if we modified title to originalTitle in this code and if dashboard.title == dashboard_def['title']: if version not in dashboard.tags: # Found existing dashboard with wrong version - update dashboard update_def = True else: update_def = False # Skip update e.g. if dashboard.originalTitle == dashboard_def['originalTitle']: then would it have worked? If it worked, then title remains to be something that can be changed anytime. - Sumit Mohanty On May 25, 2016, 2:56 a.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47811/ > --- > > (Updated May 25, 2016, 2:56 a.m.) > > > Review request for Ambari, Dmytro Sen, Prajwal Rao, Sumit Mohanty, Sid Wagle, > and Yusaku Sako. > > > Bugs: AMBARI-16862 > https://issues.apache.org/jira/browse/AMBARI-16862 > > > Repository: ambari > > > Description > --- > > Rename dashboard > > Add special logic in Grafana start script. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-performance.json > 50e20a3 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-regionservers.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py > a02c100 > > Diff: https://reviews.apache.org/r/47811/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Aravindan Vijayan > >
Review Request 47811: AMBARI-16862 : [Grafana] Rename "HBase - Performance" dashboard to "HBase - RegionServers"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47811/ --- Review request for Ambari, Dmytro Sen, Prajwal Rao, Sumit Mohanty, Sid Wagle, and Yusaku Sako. Bugs: AMBARI-16862 https://issues.apache.org/jira/browse/AMBARI-16862 Repository: ambari Description --- Rename dashboard Add special logic in Grafana start script. Diffs - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-performance.json 50e20a3 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-regionservers.json PRE-CREATION ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py a02c100 Diff: https://reviews.apache.org/r/47811/diff/ Testing --- Manually tested. Thanks, Aravindan Vijayan