Re: Review Request 47923: clean up import * for SPARK service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47923/#review135942 --- Ship it! Ship It! - Jayush Luniya On May 26, 2016, 11:04 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47923/ > --- > > (Updated May 26, 2016, 11:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16797 > https://issues.apache.org/jira/browse/AMBARI-16797 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py > bccd714 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py > c5f3eb6 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py > eca8534 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py > 3838061 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py > 9311454 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py > 86e7f7d > > Diff: https://reviews.apache.org/r/47923/diff/ > > > Testing > --- > > Passed mvn clean test -DskipSurefireTests > PIG fresh installation and service check > > Hadoop QA added a comment - 1 hour ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 47923: clean up import * for SPARK service scripts in common-services
> On June 1, 2016, 2:53 a.m., Jayush Luniya wrote: > > Patch doesnt apply cleanly. Can you rebase the patch? > > Juanjo Marron wrote: > Patch submitted to https://issues.apache.org/jira/browse/AMBARI-16797. > Waiting for Hadoop QA review Patch applied cleanly by Hadoop QA Hadoop QA added a comment - 6 minutes ago -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12807525/AMBARI-16797.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7124//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7124//console This message is automatically generated. - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47923/#review135754 --- On May 26, 2016, 11:04 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47923/ > --- > > (Updated May 26, 2016, 11:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16797 > https://issues.apache.org/jira/browse/AMBARI-16797 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py > bccd714 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py > c5f3eb6 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py > eca8534 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py > 3838061 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py > 9311454 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py > 86e7f7d > > Diff: https://reviews.apache.org/r/47923/diff/ > > > Testing > --- > > Passed mvn clean test -DskipSurefireTests > PIG fresh installation and service check > > Hadoop QA added a comment - 1 hour ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 47923: clean up import * for SPARK service scripts in common-services
> On June 1, 2016, 2:53 a.m., Jayush Luniya wrote: > > Patch doesnt apply cleanly. Can you rebase the patch? Patch submitted to https://issues.apache.org/jira/browse/AMBARI-16797. Waiting for Hadoop QA review - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47923/#review135754 --- On May 26, 2016, 11:04 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47923/ > --- > > (Updated May 26, 2016, 11:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16797 > https://issues.apache.org/jira/browse/AMBARI-16797 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py > bccd714 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py > c5f3eb6 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py > eca8534 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py > 3838061 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py > 9311454 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py > 86e7f7d > > Diff: https://reviews.apache.org/r/47923/diff/ > > > Testing > --- > > Passed mvn clean test -DskipSurefireTests > PIG fresh installation and service check > > Hadoop QA added a comment - 1 hour ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 47923: clean up import * for SPARK service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47923/#review135754 --- Patch doesnt apply cleanly. Can you rebase the patch? - Jayush Luniya On May 26, 2016, 11:04 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47923/ > --- > > (Updated May 26, 2016, 11:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16797 > https://issues.apache.org/jira/browse/AMBARI-16797 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py > bccd714 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py > c5f3eb6 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py > eca8534 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py > 3838061 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py > 9311454 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py > 86e7f7d > > Diff: https://reviews.apache.org/r/47923/diff/ > > > Testing > --- > > Passed mvn clean test -DskipSurefireTests > PIG fresh installation and service check > > Hadoop QA added a comment - 1 hour ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 47923: clean up import * for SPARK service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47923/#review135270 --- Ship it! Ship It! - Alejandro Fernandez On May 26, 2016, 11:04 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47923/ > --- > > (Updated May 26, 2016, 11:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16797 > https://issues.apache.org/jira/browse/AMBARI-16797 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py > bccd714 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py > c5f3eb6 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py > eca8534 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py > 3838061 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py > 9311454 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py > 86e7f7d > > Diff: https://reviews.apache.org/r/47923/diff/ > > > Testing > --- > > Passed mvn clean test -DskipSurefireTests > PIG fresh installation and service check > > Hadoop QA added a comment - 1 hour ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Review Request 47923: clean up import * for SPARK service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47923/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. Bugs: AMBARI-16797 https://issues.apache.org/jira/browse/AMBARI-16797 Repository: ambari Description --- Python code at at common-services level used generic imports form resource_management (from resource_management import *) Ideally, for easier code tracking and performance, these import should be more specific, such as: from resource_management.libraries.script.script import Script from resource_management.core.resources.system import Directory This patch cleans up import * from resource_management for SPARK service scripts in common-services Diffs - ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py bccd714 ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py c5f3eb6 ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py 694f046 ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py eca8534 ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py 3838061 ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py 9311454 ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py 86e7f7d Diff: https://reviews.apache.org/r/47923/diff/ Testing --- Passed mvn clean test -DskipSurefireTests PIG fresh installation and service check Hadoop QA added a comment - 1 hour ago -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console This message is automatically generated. Thanks, Juanjo Marron
