Re: Review Request 47967: Atlas server start failed after Ambari upgrade due to missing solrCloudCli.sh script

2016-05-27 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47967/#review135312
---


Ship it!




Ship It!

- Robert Levas


On May 27, 2016, 1 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47967/
> ---
> 
> (Updated May 27, 2016, 1 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Levas.
> 
> 
> Bugs: AMBARI-16932
> https://issues.apache.org/jira/browse/AMBARI-16932
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps
> 
> 1.Deploy HDP-2.4.2.0 cluster with Ambari 2.2.2.0 (including Atlas)
> 2.Upgrade Ambari to 2.4.0.0
> 3.Stop and start all services
> 
> Result
> 
> Atlas Metadata server start fails with below error:
>   Traceback (most recent call last):
> File 
> "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
>  line 165, in 
>   MetadataServer().execute()
>   raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'export 
> JAVA_HOME=/usr/jdk64/jdk1.7.0_67 ; 
> /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh -z 
> os-r6-tgvuks-dgm10toeriedwngdha-r6-4.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-3.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-2.openstacklocal:2181None
>  --upload-config -d 
> /usr/lib/ambari-logsearch-solr/server/solr/configsets/basic_configs/conf -cs 
> basic_configs -rt 5 -i 10' returned 127. -bash: 
> /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh: No such file or 
> directory
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  6f287dc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3a9c614 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json ef04248 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 166fd6f 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 0077280 
> 
> Diff: https://reviews.apache.org/r/47967/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> 
> Adjust unit tests
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



Re: Review Request 47967: Atlas server start failed after Ambari upgrade due to missing solrCloudCli.sh script

2016-05-27 Thread Robert Levas


> On May 27, 2016, 4:08 p.m., Robert Levas wrote:
> > Its not clear how the patch helps to prevent:
> > 
> > ```
> >   Traceback (most recent call last):
> > File 
> > "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
> >  line 165, in 
> >   MetadataServer().execute()
> >   raise Fail(err_msg)
> > resource_management.core.exceptions.Fail: Execution of 'export 
> > JAVA_HOME=/usr/jdk64/jdk1.7.0_67 ; 
> > /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh -z 
> > os-r6-tgvuks-dgm10toeriedwngdha-r6-4.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-3.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-2.openstacklocal:2181None
> >  --upload-config -d 
> > /usr/lib/ambari-logsearch-solr/server/solr/configsets/basic_configs/conf 
> > -cs basic_configs -rt 5 -i 10' returned 127. -bash: 
> > /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh: No such file or 
> > directory
> > ```
> 
> Tom Beerbower wrote:
> Hey Rob.  Thanks for reviewing!
> 
> Sorry about that.  
> 
> The problem is that after the upgrade the LogSearch script is being 
> called unconditionally and Logsearch is not installed.
> 
> The stack trace in the review description is truncated.  The complete 
> stack is in the Jira, but here is where the script is being called from in 
> metadata.py...
> 
> 
> File 
> "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
>  line 51, in configure
>   metadata()
> File 
> "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py",
>  line 113, in metadata
>   upload_conf_set('basic_configs', random_num)
> File 
> "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py",
>  line 135, in upload_conf_set
>   group=params.user_group)
>   
> Line 113 in metadata.py is where I added the if check to make sure that 
> the configuration was set for Solr and that the LogSearch Solr is actually 
> installed.
> 
> if type == 'server' and params.search_backend_solr and 
> params.has_logsearch_solr:

Hey Tom... thanks for the clarification. I was just making sure something 
wasn't lost.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47967/#review135302
---


On May 27, 2016, 1 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47967/
> ---
> 
> (Updated May 27, 2016, 1 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Levas.
> 
> 
> Bugs: AMBARI-16932
> https://issues.apache.org/jira/browse/AMBARI-16932
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps
> 
> 1.Deploy HDP-2.4.2.0 cluster with Ambari 2.2.2.0 (including Atlas)
> 2.Upgrade Ambari to 2.4.0.0
> 3.Stop and start all services
> 
> Result
> 
> Atlas Metadata server start fails with below error:
>   Traceback (most recent call last):
> File 
> "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
>  line 165, in 
>   MetadataServer().execute()
>   raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'export 
> JAVA_HOME=/usr/jdk64/jdk1.7.0_67 ; 
> /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh -z 
> os-r6-tgvuks-dgm10toeriedwngdha-r6-4.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-3.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-2.openstacklocal:2181None
>  --upload-config -d 
> /usr/lib/ambari-logsearch-solr/server/solr/configsets/basic_configs/conf -cs 
> basic_configs -rt 5 -i 10' returned 127. -bash: 
> /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh: No such file or 
> directory
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  6f287dc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3a9c614 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json ef04248 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 166fd6f 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 0077280 
> 
> Diff: https://reviews.apache.org/r/47967/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> 
> Adjust unit tests
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



Re: Review Request 47967: Atlas server start failed after Ambari upgrade due to missing solrCloudCli.sh script

2016-05-27 Thread Tom Beerbower


> On May 27, 2016, 8:08 p.m., Robert Levas wrote:
> > Its not clear how the patch helps to prevent:
> > 
> > ```
> >   Traceback (most recent call last):
> > File 
> > "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
> >  line 165, in 
> >   MetadataServer().execute()
> >   raise Fail(err_msg)
> > resource_management.core.exceptions.Fail: Execution of 'export 
> > JAVA_HOME=/usr/jdk64/jdk1.7.0_67 ; 
> > /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh -z 
> > os-r6-tgvuks-dgm10toeriedwngdha-r6-4.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-3.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-2.openstacklocal:2181None
> >  --upload-config -d 
> > /usr/lib/ambari-logsearch-solr/server/solr/configsets/basic_configs/conf 
> > -cs basic_configs -rt 5 -i 10' returned 127. -bash: 
> > /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh: No such file or 
> > directory
> > ```

Hey Rob.  Thanks for reviewing!

Sorry about that.  

The problem is that after the upgrade the LogSearch script is being called 
unconditionally and Logsearch is not installed.

The stack trace in the review description is truncated.  The complete stack is 
in the Jira, but here is where the script is being called from in metadata.py...


File 
"/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
 line 51, in configure
  metadata()
File 
"/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py",
 line 113, in metadata
  upload_conf_set('basic_configs', random_num)
File 
"/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py",
 line 135, in upload_conf_set
  group=params.user_group)
  
Line 113 in metadata.py is where I added the if check to make sure that the 
configuration was set for Solr and that the LogSearch Solr is actually 
installed.

if type == 'server' and params.search_backend_solr and 
params.has_logsearch_solr:


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47967/#review135302
---


On May 27, 2016, 5 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47967/
> ---
> 
> (Updated May 27, 2016, 5 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Levas.
> 
> 
> Bugs: AMBARI-16932
> https://issues.apache.org/jira/browse/AMBARI-16932
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps
> 
> 1.Deploy HDP-2.4.2.0 cluster with Ambari 2.2.2.0 (including Atlas)
> 2.Upgrade Ambari to 2.4.0.0
> 3.Stop and start all services
> 
> Result
> 
> Atlas Metadata server start fails with below error:
>   Traceback (most recent call last):
> File 
> "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
>  line 165, in 
>   MetadataServer().execute()
>   raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'export 
> JAVA_HOME=/usr/jdk64/jdk1.7.0_67 ; 
> /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh -z 
> os-r6-tgvuks-dgm10toeriedwngdha-r6-4.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-3.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-2.openstacklocal:2181None
>  --upload-config -d 
> /usr/lib/ambari-logsearch-solr/server/solr/configsets/basic_configs/conf -cs 
> basic_configs -rt 5 -i 10' returned 127. -bash: 
> /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh: No such file or 
> directory
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  6f287dc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3a9c614 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json ef04248 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 166fd6f 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 0077280 
> 
> Diff: https://reviews.apache.org/r/47967/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> 
> Adjust unit tests
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



Re: Review Request 47967: Atlas server start failed after Ambari upgrade due to missing solrCloudCli.sh script

2016-05-27 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47967/#review135302
---



Its not clear how the patch helps to prevent:

```
  Traceback (most recent call last):
File 
"/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
 line 165, in 
  MetadataServer().execute()
  raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'export 
JAVA_HOME=/usr/jdk64/jdk1.7.0_67 ; 
/usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh -z 
os-r6-tgvuks-dgm10toeriedwngdha-r6-4.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-3.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-2.openstacklocal:2181None
 --upload-config -d 
/usr/lib/ambari-logsearch-solr/server/solr/configsets/basic_configs/conf -cs 
basic_configs -rt 5 -i 10' returned 127. -bash: 
/usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh: No such file or directory
```

- Robert Levas


On May 27, 2016, 1 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47967/
> ---
> 
> (Updated May 27, 2016, 1 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Levas.
> 
> 
> Bugs: AMBARI-16932
> https://issues.apache.org/jira/browse/AMBARI-16932
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps
> 
> 1.Deploy HDP-2.4.2.0 cluster with Ambari 2.2.2.0 (including Atlas)
> 2.Upgrade Ambari to 2.4.0.0
> 3.Stop and start all services
> 
> Result
> 
> Atlas Metadata server start fails with below error:
>   Traceback (most recent call last):
> File 
> "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
>  line 165, in 
>   MetadataServer().execute()
>   raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'export 
> JAVA_HOME=/usr/jdk64/jdk1.7.0_67 ; 
> /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh -z 
> os-r6-tgvuks-dgm10toeriedwngdha-r6-4.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-3.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-2.openstacklocal:2181None
>  --upload-config -d 
> /usr/lib/ambari-logsearch-solr/server/solr/configsets/basic_configs/conf -cs 
> basic_configs -rt 5 -i 10' returned 127. -bash: 
> /usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh: No such file or 
> directory
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  6f287dc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3a9c614 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json ef04248 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 166fd6f 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 0077280 
> 
> Diff: https://reviews.apache.org/r/47967/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> 
> Adjust unit tests
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



Review Request 47967: Atlas server start failed after Ambari upgrade due to missing solrCloudCli.sh script

2016-05-27 Thread Tom Beerbower

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47967/
---

Review request for Ambari, John Speidel and Robert Levas.


Bugs: AMBARI-16932
https://issues.apache.org/jira/browse/AMBARI-16932


Repository: ambari


Description
---

Steps

1.Deploy HDP-2.4.2.0 cluster with Ambari 2.2.2.0 (including Atlas)
2.Upgrade Ambari to 2.4.0.0
3.Stop and start all services

Result

Atlas Metadata server start fails with below error:
  Traceback (most recent call last):
File 
"/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
 line 165, in 
  MetadataServer().execute()
  raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'export 
JAVA_HOME=/usr/jdk64/jdk1.7.0_67 ; 
/usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh -z 
os-r6-tgvuks-dgm10toeriedwngdha-r6-4.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-3.openstacklocal:2181,os-r6-tgvuks-dgm10toeriedwngdha-r6-2.openstacklocal:2181None
 --upload-config -d 
/usr/lib/ambari-logsearch-solr/server/solr/configsets/basic_configs/conf -cs 
basic_configs -rt 5 -i 10' returned 127. -bash: 
/usr/lib/ambari-logsearch-solr-client/solrCloudCli.sh: No such file or directory


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 6f287dc 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 3a9c614 
  ambari-server/src/test/python/stacks/2.3/configs/default.json ef04248 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 166fd6f 
  ambari-server/src/test/python/stacks/2.5/configs/default.json 0077280 

Diff: https://reviews.apache.org/r/47967/diff/


Testing
---

Manual test

Adjust unit tests

mvn clean test


Thanks,

Tom Beerbower