Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Jayush Luniya]

> On June 15, 2016, 5:51 p.m., Jayush Luniya wrote:
> > Ship It!

For 2.4 and trunk, we should not have any hdp-select and hdp hardcodings. 
Everything should be stack config driven.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review137780
---


On June 13, 2016, 9:22 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 13, 2016, 9:22 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installation related information.
> 
> The patch only applies for 2.2-next versions.
> Based on the git logs the affected codebase has been refactored as part of 
> AMBARI-15329.
> (This addition should be ported to the newer versions isf applicable)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Alejandro Fernandez]

> On June 7, 2016, 6:49 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py,
> >  line 130
> > 
> >
> > Please consult with Jayush Luniya.
> > The stack already has a config for the stack root, so hdp_select (or 
> > distro select as it should be called) shouldn't be hardcoding paths.
> 
> Laszlo Puskas wrote:
> This patch is for 2.2-next branch that doesn't have those improvements. 
> (Tried to do this following one of your previous notes - seems that those 
> weren't backported to this branch)

Does this patch also need to go into trunk?


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136517
---


On June 13, 2016, 9:22 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 13, 2016, 9:22 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installation related information.
> 
> The patch only applies for 2.2-next versions.
> Based on the git logs the affected codebase has been refactored as part of 
> AMBARI-15329.
> (This addition should be ported to the newer versions isf applicable)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 13, 2016, 9:22 a.m.)


Review request for Ambari, Andrew Onischuk, Jayush Luniya, Sandor Magyari, 
Sumit Mohanty, and Sebastian Toader.


Changes
---

Added Jayush.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description (updated)
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installation related information.

The patch only applies for 2.2-next versions.
Based on the git logs the affected codebase has been refactored as part of 
AMBARI-15329.
(This addition should be ported to the newer versions isf applicable)


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing
---

Unit tests passed.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

> On June 7, 2016, 6:49 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py,
> >  line 130
> > 
> >
> > Please consult with Jayush Luniya.
> > The stack already has a config for the stack root, so hdp_select (or 
> > distro select as it should be called) shouldn't be hardcoding paths.

This patch is for 2.2-next branch that doesn't have those improvements. (Tried 
to do this following one of your previous notes - seems that those weren't 
backported to this branch)


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136517
---


On June 13, 2016, 8:28 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 13, 2016, 8:28 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Daniel Gergely, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installation related information.
> 
> The patch only applies for 2.2-next versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 13, 2016, 8:28 a.m.)


Review request for Ambari, Andrew Onischuk, Daniel Gergely, Oliver Szabo, 
Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

Applied review notes.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installation related information.

The patch only applies for 2.2-next versions.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing
---

Unit tests passed.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136615
---




ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 (line 129)


The tuple of one items should have trailing comma, or else python 
interprets as a single value.

>>> ('item')
'item'
>>> ('item',)
('item',)


- Andrew Onischuk


On June 7, 2016, 12:56 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 7, 2016, 12:56 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Daniel Gergely, Oliver Szabo, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installation related information.
> 
> The patch only applies for 2.2-next versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136517
---




ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 (line 128)


Please consult with Jayush Luniya.
The stack already has a config for the stack root, so hdp_select (or distro 
select as it should be called) shouldn't be hardcoding paths.



ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 (line 129)


Change this to hdp-select status to make it evident what it is doing.


- Alejandro Fernandez


On June 7, 2016, 12:56 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 7, 2016, 12:56 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Daniel Gergely, Oliver Szabo, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installation related information.
> 
> The patch only applies for 2.2-next versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 7, 2016, 12:15 p.m.)


Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
Sebastian Toader.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installationrelated information.

The patch only applies for 2.2-next versions.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing (updated)
---

Unit tests passed.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 7, 2016, 12:14 p.m.)


Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

Removed sudo from ls command executions.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installationrelated information.

The patch only applies for 2.2-next versions.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing
---

Unit tests passed.
Manual testing underway.
// need to verify if ls is configured with sudo on agents.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 7, 2016, 9:18 a.m.)


Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

Applied review notes.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installationrelated information.

The patch only applies for 2.2-next versions.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing (updated)
---

Unit tests passed.
Manual testing underway.
// need to verify if ls is configured with sudo on agents.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136439
---




ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 (line 128)


Instead of using {sudo} param. Can we use something like this:

Execute(('ls','-la','/usr/hdp', sudo=True)

This will ensure that we add specific flags for older sudo packages.


- Andrew Onischuk


On June 7, 2016, 8:17 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 7, 2016, 8:17 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> The patch only applies for 2.2-next versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Andrew Onischuk]

> On June 7, 2016, 8:53 a.m., Andrew Onischuk wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py,
> >  line 130
> > 
> >
> > I don't think we have ts in sudo permissions. Can we use test here?
> 
> Andrew Onischuk wrote:
> ls not ts.

For the reference 
https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.2.1/bk_Ambari_Security_Guide/content/_commands.html


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136436
---


On June 7, 2016, 8:17 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 7, 2016, 8:17 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> The patch only applies for 2.2-next versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Andrew Onischuk]

> On June 7, 2016, 8:53 a.m., Andrew Onischuk wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py,
> >  line 130
> > 
> >
> > I don't think we have ts in sudo permissions. Can we use test here?

ls not ts.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136436
---


On June 7, 2016, 8:17 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 7, 2016, 8:17 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> The patch only applies for 2.2-next versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 7, 2016, 8:17 a.m.)


Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

Reverted the last version of the patch.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description (updated)
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installationrelated information.

The patch only applies for 2.2-next versions.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing
---

Unit tests passed.
Manual testing underway.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 7, 2016, 8:03 a.m.)


Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
Sebastian Toader.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installationrelated information.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing
---

Unit tests passed.
Manual testing underway.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 7, 2016, 8:02 a.m.)


Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
Sebastian Toader.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installationrelated information.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing (updated)
---

Unit tests passed.
Manual testing underway.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136336
---


Fix it, then Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 (line 136)


Please add a comment as to why this was done.


- Alejandro Fernandez


On June 6, 2016, 3:15 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 6, 2016, 3:15 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> Manual testing underway please don't commit yet.
> // found some major differences between the branches / investigating it
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 6, 2016, 3:15 p.m.)


Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
Sebastian Toader.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installationrelated information.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing (updated)
---

Unit tests passed.
Manual testing underway please don't commit yet.
// found some major differences between the branches / investigating it


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 6, 2016, 3:01 p.m.)


Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
Sebastian Toader.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installationrelated information.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing (updated)
---

Unit tests passed.
Manual testing underway please don't commit yet.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 6, 2016, 3 p.m.)


Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
Sebastian Toader.


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installationrelated information.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing (updated)
---

Unit tests passed.
Manual testing underway.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

> On June 2, 2016, 4:23 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py,
> >  line 129
> > 
> >
> > This cannot assume the directory will be /usr/hdp, instead use 
> > stack_root variable.
> 
> Sumit Mohanty wrote:
> Looks like different patches are needed for branch-2.4 and branch-2.2. 
> Starting 2.4 {stack_root}/{version_to_select} can be used and for the older 
> version it can be /usr/hdp.

Using the stack_root to the log commands.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review135943
---


On June 6, 2016, 2:48 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 6, 2016, 2:48 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/
---

(Updated June 6, 2016, 2:48 p.m.)


Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

Added stack_root variable


Bugs: AMBARI-16952
https://issues.apache.org/jira/browse/AMBARI-16952


Repository: ambari


Description
---

In case the hdp-select command fails during a service / component installation 
there's no contextual information about the cause of the failure.
This issue is for logging information about the machine on which the hdp-select 
command fails.
This solution wraps hdp-select command calls in a try/catch block and logs 
failure / hdp installationrelated information.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 9a3201e 

Diff: https://reviews.apache.org/r/48044/diff/


Testing
---

Manual testing underway.


Thanks,

Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Sumit Mohanty]

> On June 2, 2016, 4:23 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py,
> >  line 129
> > 
> >
> > This cannot assume the directory will be /usr/hdp, instead use 
> > stack_root variable.

Looks like different patches are needed for branch-2.4 and branch-2.2. Starting 
2.4 {stack_root}/{version_to_select} can be used and for the older version it 
can be /usr/hdp.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review135943
---


On June 2, 2016, 12:55 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 2, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review135943
---




ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 (line 129)


This cannot assume the directory will be /usr/hdp, instead use stack_root 
variable.


- Alejandro Fernandez


On June 2, 2016, 12:55 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 2, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Laszlo Puskas]

> On May 31, 2016, 12:37 a.m., Sumit Mohanty wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py,
> >  line 129
> > 
> >
> > We should also add the following commands:
> > 
> > ls -la /usr/hdp/current
> > hdp-select

Added requested commands.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review135565
---


On June 2, 2016, 12:55 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 2, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review135919
---


Ship it!




Ship It!

- Oliver Szabo


On May 30, 2016, 2:34 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated May 30, 2016, 2:34 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review135565
---




ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 (line 129)


We should also add the following commands:

ls -la /usr/hdp/current
hdp-select


- Sumit Mohanty


On May 30, 2016, 2:34 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated May 30, 2016, 2:34 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>