Re: Review Request 48063: Redundant info under config tab for falcon

2016-06-01 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48063/#review135796
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Червень 1, 2016, 11:27 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48063/
> ---
> 
> (Updated Червень 1, 2016, 11:27 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16959
> https://issues.apache.org/jira/browse/AMBARI-16959
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While configuring Falcon, there is an option to set the store for the entity
> definition. This updates the property "*.config.store.uri". On the Ambari UI
> there is an option to set this property under "Falcon Startup Properties" and
> "Falcon Server". The later one has not effect on the config files and should
> be removed from here.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  949e4d7 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  45cd9a7 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  6e2e678 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  8e666ac 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  f8510c2 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 298480c 
>   ambari-web/app/data/HDP2/site_properties.js beb420d 
> 
> Diff: https://reviews.apache.org/r/48063/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Re: Review Request 48063: Redundant info under config tab for falcon

2016-06-01 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48063/
---

(Updated June 1, 2016, 11:27 a.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-16959
https://issues.apache.org/jira/browse/AMBARI-16959


Repository: ambari


Description
---

While configuring Falcon, there is an option to set the store for the entity
definition. This updates the property "*.config.store.uri". On the Ambari UI
there is an option to set this property under "Falcon Startup Properties" and
"Falcon Server". The later one has not effect on the config files and should
be removed from here.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 949e4d7 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
 45cd9a7 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 6e2e678 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 8e666ac 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 f8510c2 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 298480c 
  ambari-web/app/data/HDP2/site_properties.js beb420d 

Diff: https://reviews.apache.org/r/48063/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk



Re: Review Request 48063: Redundant info under config tab for falcon

2016-05-31 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48063/#review135616
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Травень 31, 2016, 8:23 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48063/
> ---
> 
> (Updated Травень 31, 2016, 8:23 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16959
> https://issues.apache.org/jira/browse/AMBARI-16959
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While configuring Falcon, there is an option to set the store for the entity
> definition. This updates the property "*.config.store.uri". On the Ambari UI
> there is an option to set this property under "Falcon Startup Properties" and
> "Falcon Server". The later one has not effect on the config files and should
> be removed from here.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  408df4f 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  45cd9a7 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  6e2e678 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  8e666ac 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  56e8a8a 
>   ambari-web/app/data/HDP2/site_properties.js beb420d 
> 
> Diff: https://reviews.apache.org/r/48063/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Review Request 48063: Redundant info under config tab for falcon

2016-05-31 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48063/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-16959
https://issues.apache.org/jira/browse/AMBARI-16959


Repository: ambari


Description
---

While configuring Falcon, there is an option to set the store for the entity
definition. This updates the property "*.config.store.uri". On the Ambari UI
there is an option to set this property under "Falcon Startup Properties" and
"Falcon Server". The later one has not effect on the config files and should
be removed from here.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 408df4f 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
 45cd9a7 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 6e2e678 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 8e666ac 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 56e8a8a 
  ambari-web/app/data/HDP2/site_properties.js beb420d 

Diff: https://reviews.apache.org/r/48063/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk