Re: Review Request 48072: Upgrade Catalog 2.4 is not idempotent

2016-05-31 Thread Myroslav Papirkovskyy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48072/#review135629
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Травень 31, 2016, 2:12 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48072/
> ---
> 
> (Updated Травень 31, 2016, 2:12 після полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-16964
> https://issues.apache.org/jira/browse/AMBARI-16964
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **STR:**  
> Run ambrai-server upgrade twice (a with metainfo change).  
> **Result:**
> 
> 
> 30 May 2016 14:21:20,392 ERROR [main] DBAccessorImpl:803 - Error 
> executing query: UPDATE viewinstance SET cluster_handle_dummy = 2 WHERE 
> cluster_handle = 'cl1'
> org.postgresql.util.PSQLException: ERROR: invalid input syntax for 
> integer: "cl1"
>   Position: 73
> at 
> org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
> at 
> org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
> at 
> org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:403)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:395)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:800)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:792)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog240.updateViewInstanceTable(UpgradeCatalog240.java:2352)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog240.executeDDLUpdates(UpgradeCatalog240.java:277)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:699)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:201)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:302)
> 30 May 2016 14:21:20,424 ERROR [main] SchemaUpgradeHelper:203 - Upgrade 
> failed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  b817a15 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  56e8a8a 
> 
> Diff: https://reviews.apache.org/r/48072/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Review Request 48072: Upgrade Catalog 2.4 is not idempotent

2016-05-31 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48072/
---

Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-16964
https://issues.apache.org/jira/browse/AMBARI-16964


Repository: ambari


Description
---

**STR:**  
Run ambrai-server upgrade twice (a with metainfo change).  
**Result:**


30 May 2016 14:21:20,392 ERROR [main] DBAccessorImpl:803 - Error executing 
query: UPDATE viewinstance SET cluster_handle_dummy = 2 WHERE cluster_handle = 
'cl1'
org.postgresql.util.PSQLException: ERROR: invalid input syntax for integer: 
"cl1"
  Position: 73
at 
org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
at 
org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
at 
org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
at 
org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
at 
org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:403)
at 
org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:395)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:800)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:792)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog240.updateViewInstanceTable(UpgradeCatalog240.java:2352)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog240.executeDDLUpdates(UpgradeCatalog240.java:277)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:699)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:201)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:302)
30 May 2016 14:21:20,424 ERROR [main] SchemaUpgradeHelper:203 - Upgrade 
failed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 b817a15 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 56e8a8a 

Diff: https://reviews.apache.org/r/48072/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk