Re: Review Request 48081: Prefix command execution log lines in agent log

2016-05-31 Thread Sandor Magyari

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48081/#review135767
---


Ship it!




Ship It!

- Sandor Magyari


On May 31, 2016, 7:29 p.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48081/
> ---
> 
> (Updated May 31, 2016, 7:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sandor Magyari.
> 
> 
> Bugs: AMBARI-16958
> https://issues.apache.org/jira/browse/AMBARI-16958
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If parallel execution is enabled, log lines of different components may 
> interfere, especially if they are split in more lines, a prefix for each log 
> containing component ROLE, task ID would be useful to be able to co-relate 
> these.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 5c9189c 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 0fd3bff 
> 
> Diff: https://reviews.apache.org/r/48081/diff/
> 
> 
> Testing
> ---
> 
> Test run manually and also via hadoop-qa
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>



Re: Review Request 48081: Prefix command execution log lines in agent log

2016-05-31 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48081/#review135682
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 31, 2016, 7:29 p.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48081/
> ---
> 
> (Updated May 31, 2016, 7:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sandor Magyari.
> 
> 
> Bugs: AMBARI-16958
> https://issues.apache.org/jira/browse/AMBARI-16958
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If parallel execution is enabled, log lines of different components may 
> interfere, especially if they are split in more lines, a prefix for each log 
> containing component ROLE, task ID would be useful to be able to co-relate 
> these.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 5c9189c 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 0fd3bff 
> 
> Diff: https://reviews.apache.org/r/48081/diff/
> 
> 
> Testing
> ---
> 
> Test run manually and also via hadoop-qa
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>



Review Request 48081: Prefix command execution log lines in agent log

2016-05-31 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48081/
---

Review request for Ambari, Alejandro Fernandez and Sandor Magyari.


Bugs: AMBARI-16958
https://issues.apache.org/jira/browse/AMBARI-16958


Repository: ambari


Description
---

If parallel execution is enabled, log lines of different components may 
interfere, especially if they are split in more lines, a prefix for each log 
containing component ROLE, task ID would be useful to be able to co-relate 
these.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 5c9189c 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 0fd3bff 

Diff: https://reviews.apache.org/r/48081/diff/


Testing
---

Test run manually and also via hadoop-qa


Thanks,

Sumit Mohanty