Re: Review Request 48154: Incorrect ports in WebHDFS HA config in Knox

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48154/#review135860
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 (line 128)


Indentation of 2 spaces



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 (line 131)


This is accessing index 1 without first checking the length


- Alejandro Fernandez


On June 1, 2016, 8:49 p.m., Sumit Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48154/
> ---
> 
> (Updated June 1, 2016, 8:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmytro Sen.
> 
> 
> Bugs: AMBARI-13820
> https://issues.apache.org/jira/browse/AMBARI-13820
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The default topology file in Knox's config contains a template for webhdfs 
> service hosts and ports that gets incorrectly populated when in HA mode.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  cba388b 
> 
> Diff: https://reviews.apache.org/r/48154/diff/
> 
> 
> Testing
> ---
> 
> Tested end to end with a 3 node cluster that had webhdfs setup for HA and 
> Knox setup for proxying those services in HA. The configuration was incorrect 
> before applying the changes in the patch and correct after applying the 
> changes and restarting the server and agent.
> 
> 
> Thanks,
> 
> Sumit Gupta
> 
>

Review Request 48154: Incorrect ports in WebHDFS HA config in Knox

[Sumit Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48154/
---

Review request for Ambari, Alejandro Fernandez and Dmytro Sen.


Bugs: AMBARI-13820
https://issues.apache.org/jira/browse/AMBARI-13820


Repository: ambari


Description
---

The default topology file in Knox's config contains a template for webhdfs 
service hosts and ports that gets incorrectly populated when in HA mode.


Diffs
-

  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 cba388b 

Diff: https://reviews.apache.org/r/48154/diff/


Testing
---

Tested end to end with a 3 node cluster that had webhdfs setup for HA and Knox 
setup for proxying those services in HA. The configuration was incorrect before 
applying the changes in the patch and correct after applying the changes and 
restarting the server and agent.


Thanks,

Sumit Gupta