Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135880
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

[Jaimin Jetly]

> On June 1, 2016, 9:40 p.m., Zhe (Joe) Wang wrote:
> > ambari-web/app/controllers/wizard/step7/assign_master_controller.js, line 
> > 161
> > 
> >
> > Typo?
> 
> Jaimin Jetly wrote:
> This is intended change to address scenario 1 stated in description. The 
> change makes an explicit recommendation call when interactive query is again 
> disabled which is needed.

I suppose you were pointing towards the name of the funcion 
sendRequestRorDependentConfigs. It seems to be a typo but its an existing 
function and is being used at many places. I will kep an eye on it and will fix 
the function name in a refactoring task


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135867
---


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

[Jaimin Jetly]

> On June 1, 2016, 9:41 p.m., Zhe (Joe) Wang wrote:
> > ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js, 
> > line 152
> > 
> >
> > Typo?

unit test change needed to accomodate the change made in the corresponding part 
of application code.


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135868
---


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

[Jaimin Jetly]

> On June 1, 2016, 9:40 p.m., Zhe (Joe) Wang wrote:
> > ambari-web/app/controllers/wizard/step7/assign_master_controller.js, line 
> > 161
> > 
> >
> > Typo?

This is intended change to address scenario 1 stated in description. The change 
makes an explicit recommendation call when interactive query is again disabled 
which is needed.


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135867
---


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Review Request 48156: Misc fixes related to slider while enabling interactive query

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/
---

Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-16993
https://issues.apache.org/jira/browse/AMBARI-16993


Repository: ambari


Description
---

*Scenario 1:*
# Install a Ambari-2.2.2 cluster with hive service
# Upgrade to Ambari-2.4.0
# Enable interactive query. A popup asking to install slider service first will 
be shown. Also recommendations for enable interactive query are shown in the bg 
# Dismiss the popup. This again disables interactive query

*Actual behavior:* Recommendations for enabled interactive query remains
*Expected behavior:* Since interactive query is again disabled, recommendations 
for enabled interactive query should go away.


*Scenario 2:*
# Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
client on 2 out of 3 hosts.
# Enable interactive query. Select a host on which slider client is absent for 
HS2 interactive.
#  Save configurations

*Actual behavior:* Install components request has tasks to installs Slider 
client on all 3 hosts
*Expected behavior:* Install components request should install Slider client 
only on 1 host (HS2 interactive host)


Diffs
-

  ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
0907aa7 
  ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
df2f70b 

Diff: https://reviews.apache.org/r/48156/diff/


Testing
---

Verifies that the patch resolves both the stated issues
ambari-web unit tests with the patch:
28524 tests complete (28 seconds)
154 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135868
---




ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js (line 
152)


Typo?


- Zhe (Joe) Wang


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135867
---




ambari-web/app/controllers/wizard/step7/assign_master_controller.js (line 161)


Typo?


- Zhe (Joe) Wang


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>