Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services
> On June 7, 2016, 6:45 p.m., Alejandro Fernandez wrote: > > Ship It! > > Juanjo Marron wrote: > I dont have privileges to commit. Could someone deliver it to trunk so I > can mark the JIRA https://issues.apache.org/jira/browse/AMBARI-16101 as > complete, please? > Thanks > > Jayush Luniya wrote: > Will commit Thanks Jayush! - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136516 --- On June 7, 2016, 4:09 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48184/ > --- > > (Updated June 7, 2016, 4:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16916 > https://issues.apache.org/jira/browse/AMBARI-16916 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK2 service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py > b3720f0 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 3316f78 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py > 9316ba9 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py > 434b4b1 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py > 2eae3e7 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py > be65986 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py > 4196638 > > Diff: https://reviews.apache.org/r/48184/diff/ > > > Testing > --- > > added a comment - 7 minutes ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services
> On June 7, 2016, 6:45 p.m., Alejandro Fernandez wrote: > > Ship It! > > Juanjo Marron wrote: > I dont have privileges to commit. Could someone deliver it to trunk so I > can mark the JIRA https://issues.apache.org/jira/browse/AMBARI-16101 as > complete, please? > Thanks Will commit - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136516 --- On June 7, 2016, 4:09 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48184/ > --- > > (Updated June 7, 2016, 4:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16916 > https://issues.apache.org/jira/browse/AMBARI-16916 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK2 service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py > b3720f0 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 3316f78 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py > 9316ba9 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py > 434b4b1 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py > 2eae3e7 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py > be65986 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py > 4196638 > > Diff: https://reviews.apache.org/r/48184/diff/ > > > Testing > --- > > added a comment - 7 minutes ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136845 --- Ship it! Ship It! - Jayush Luniya On June 7, 2016, 4:09 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48184/ > --- > > (Updated June 7, 2016, 4:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16916 > https://issues.apache.org/jira/browse/AMBARI-16916 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK2 service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py > b3720f0 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 3316f78 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py > 9316ba9 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py > 434b4b1 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py > 2eae3e7 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py > be65986 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py > 4196638 > > Diff: https://reviews.apache.org/r/48184/diff/ > > > Testing > --- > > added a comment - 7 minutes ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services
> On June 7, 2016, 6:45 p.m., Alejandro Fernandez wrote: > > Ship It! I dont have privileges to commit. Could someone deliver it to trunk so I can mark the JIRA https://issues.apache.org/jira/browse/AMBARI-16101 as complete, please? Thanks - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136516 --- On June 7, 2016, 4:09 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48184/ > --- > > (Updated June 7, 2016, 4:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16916 > https://issues.apache.org/jira/browse/AMBARI-16916 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK2 service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py > b3720f0 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 3316f78 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py > 9316ba9 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py > 434b4b1 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py > 2eae3e7 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py > be65986 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py > 4196638 > > Diff: https://reviews.apache.org/r/48184/diff/ > > > Testing > --- > > added a comment - 7 minutes ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136516 --- Ship it! Ship It! - Alejandro Fernandez On June 7, 2016, 4:09 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48184/ > --- > > (Updated June 7, 2016, 4:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16916 > https://issues.apache.org/jira/browse/AMBARI-16916 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK2 service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py > b3720f0 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 3316f78 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py > 9316ba9 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py > 434b4b1 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py > 2eae3e7 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py > be65986 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py > 4196638 > > Diff: https://reviews.apache.org/r/48184/diff/ > > > Testing > --- > > added a comment - 7 minutes ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136492 --- Ship it! Ship It! - Matt On June 7, 2016, 9:09 a.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48184/ > --- > > (Updated June 7, 2016, 9:09 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16916 > https://issues.apache.org/jira/browse/AMBARI-16916 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for SPARK2 service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py > b3720f0 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 3316f78 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py > 694f046 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py > 9316ba9 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py > 434b4b1 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py > 2eae3e7 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py > be65986 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py > 4196638 > > Diff: https://reviews.apache.org/r/48184/diff/ > > > Testing > --- > > added a comment - 7 minutes ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Review Request 48184: clean up import * for SPARK2 service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. Bugs: AMBARI-16916 https://issues.apache.org/jira/browse/AMBARI-16916 Repository: ambari Description --- Python code at at common-services level used generic imports form resource_management (from resource_management import *) Ideally, for easier code tracking and performance, these import should be more specific, such as: from resource_management.libraries.script.script import Script from resource_management.core.resources.system import Directory This patch cleans up import * from resource_management for SPARK2 service scripts in common-services Diffs - ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py b3720f0 ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 3316f78 ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py 694f046 ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py 9316ba9 ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py 434b4b1 ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py 2eae3e7 ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py be65986 ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py 4196638 Diff: https://reviews.apache.org/r/48184/diff/ Testing --- added a comment - 7 minutes ago -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console This message is automatically generated. Thanks, Juanjo Marron
