Re: Review Request 48258: Fix description of SERVICE.ADD_DELETE_SERVICES permission

2016-06-06 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48258/#review136359
---


Ship it!




Ship It!

- Nate Cole


On June 6, 2016, 3:54 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48258/
> ---
> 
> (Updated June 6, 2016, 3:54 p.m.)
> 
> 
> Review request for Ambari, Denys Buzhor, Jonathan Robie, Nate Cole, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-17043
> https://issues.apache.org/jira/browse/AMBARI-17043
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The description of the SERVICE.ADD_DELETE_SERVICES permission currently reads
> 
> ```
> Add Service to cluster
> ```
> 
> This should be changed to
> 
> ```
> Add/delete services
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  be9c2e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  01322b2 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 940542d 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql eb2b349 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql de8c2e6 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a8d6c9 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 4b65a69 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5ef07d0 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 0b5f3b8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  670200c 
> 
> Diff: https://reviews.apache.org/r/48258/diff/
> 
> 
> Testing
> ---
> 
> Manually tested new cluster and upgrade.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>



Review Request 48258: Fix description of SERVICE.ADD_DELETE_SERVICES permission

2016-06-05 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48258/
---

Review request for Ambari, Denys Buzhor and Yusaku Sako.


Bugs: AMBARI-17043
https://issues.apache.org/jira/browse/AMBARI-17043


Repository: ambari


Description
---

The description of the SERVICE.ADD_DELETE_SERVICES permission currently reads

```
Add Service to cluster
```

This should be changed to

```
Add/delete services
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
 be9c2e2 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 01322b2 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 940542d 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql eb2b349 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql de8c2e6 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a8d6c9 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
4b65a69 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5ef07d0 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 0b5f3b8 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 670200c 

Diff: https://reviews.apache.org/r/48258/diff/


Testing
---

Manually tested new cluster and upgrade.


Thanks,

Robert Levas