Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-07 Thread Richard Zang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48289/#review136512
---


Ship it!




Ship It!

- Richard Zang


On June 6, 2016, 6:22 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48289/
> ---
> 
> (Updated June 6, 2016, 6:22 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Jaimin Jetly, Richard Zang, Xi Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10908
> https://issues.apache.org/jira/browse/AMBARI-10908
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On Hosts page, provide ability to delete hosts in bulk.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/host/bulk_operations_controller.js 09d6a52 
>   ambari-web/app/messages.js e8ca9ae 
>   ambari-web/app/styles/application.less 5ee09cc 
>   ambari-web/app/templates/main/host/delete_hosts_dry_run_popup.hbs 
> PRE-CREATION 
>   ambari-web/app/templates/main/host/delete_hosts_popup.hbs PRE-CREATION 
>   ambari-web/app/templates/main/host/delete_hosts_result_popup.hbs 
> PRE-CREATION 
>   ambari-web/app/utils/ajax/ajax.js 195dab4 
>   ambari-web/app/views/main/host/hosts_table_menu_view.js 5e4b0e0 
> 
> Diff: https://reviews.apache.org/r/48289/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 28648 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-06 Thread Zhe (Joe) Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48289/
---

(Updated June 6, 2016, 6:22 p.m.)


Review request for Ambari, Ajit Kumar, Jaimin Jetly, Richard Zang, Xi Wang, and 
Yusaku Sako.


Bugs: AMBARI-10908
https://issues.apache.org/jira/browse/AMBARI-10908


Repository: ambari


Description
---

On Hosts page, provide ability to delete hosts in bulk.


Diffs (updated)
-

  ambari-web/app/controllers/main/host/bulk_operations_controller.js 09d6a52 
  ambari-web/app/messages.js e8ca9ae 
  ambari-web/app/styles/application.less 5ee09cc 
  ambari-web/app/templates/main/host/delete_hosts_dry_run_popup.hbs 
PRE-CREATION 
  ambari-web/app/templates/main/host/delete_hosts_popup.hbs PRE-CREATION 
  ambari-web/app/templates/main/host/delete_hosts_result_popup.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js 195dab4 
  ambari-web/app/views/main/host/hosts_table_menu_view.js 5e4b0e0 

Diff: https://reviews.apache.org/r/48289/diff/


Testing
---

Local ambari-web test passed.
28648 tests complete (24 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-06 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48289/#review136330
---


Fix it, then Ship it!




Any screenshots on the Jira?


ambari-web/app/messages.js (line 2403)


"that cannot be deleted ..."



ambari-web/app/messages.js (line 2407)


"Communication" is singular.


- Alejandro Fernandez


On June 6, 2016, 5:56 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48289/
> ---
> 
> (Updated June 6, 2016, 5:56 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Jaimin Jetly, Richard Zang, Xi Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10908
> https://issues.apache.org/jira/browse/AMBARI-10908
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On Hosts page, provide ability to delete hosts in bulk.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/host/bulk_operations_controller.js 09d6a52 
>   ambari-web/app/messages.js ffc6eb2 
>   ambari-web/app/styles/application.less 5ee09cc 
>   ambari-web/app/templates/main/host/delete_hosts_dry_run_popup.hbs 
> PRE-CREATION 
>   ambari-web/app/templates/main/host/delete_hosts_popup.hbs PRE-CREATION 
>   ambari-web/app/templates/main/host/delete_hosts_result_popup.hbs 
> PRE-CREATION 
>   ambari-web/app/utils/ajax/ajax.js 195dab4 
>   ambari-web/app/views/main/host/hosts_table_menu_view.js 5e4b0e0 
> 
> Diff: https://reviews.apache.org/r/48289/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 28648 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-06 Thread Zhe (Joe) Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48289/
---

Review request for Ambari, Ajit Kumar, Jaimin Jetly, Richard Zang, Xi Wang, and 
Yusaku Sako.


Bugs: AMBARI-10908
https://issues.apache.org/jira/browse/AMBARI-10908


Repository: ambari


Description
---

On Hosts page, provide ability to delete hosts in bulk.


Diffs
-

  ambari-web/app/controllers/main/host/bulk_operations_controller.js 09d6a52 
  ambari-web/app/messages.js ffc6eb2 
  ambari-web/app/styles/application.less 5ee09cc 
  ambari-web/app/templates/main/host/delete_hosts_dry_run_popup.hbs 
PRE-CREATION 
  ambari-web/app/templates/main/host/delete_hosts_popup.hbs PRE-CREATION 
  ambari-web/app/templates/main/host/delete_hosts_result_popup.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js 195dab4 
  ambari-web/app/views/main/host/hosts_table_menu_view.js 5e4b0e0 

Diff: https://reviews.apache.org/r/48289/diff/


Testing
---

Local ambari-web test passed.
28648 tests complete (24 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang