Re: Review Request 48296: AMBARI-17073 HDF Management install does not allow one to select public repo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48296/#review136493 --- Ship it! Ship It! - Richard Zang On June 7, 2016, 12:36 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48296/ > --- > > (Updated June 7, 2016, 12:36 a.m.) > > > Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, > and Yusaku Sako. > > > Bugs: AMBARI-17073 > https://issues.apache.org/jira/browse/AMBARI-17073 > > > Repository: ambari > > > Description > --- > > To fulfill the requirement of enforcing users to choose local repo when they > don’t have internet access, in FE we use the logic of checking whether all > versions are stack_default versions. That logic is true for HDP for now, but > not for HDF. > > > Diffs > - > > ambari-web/app/messages.js e8ca9ae > ambari-web/app/templates/wizard/step1.hbs 72a2099 > > ambari-web/app/templates/wizard/step1/public_option_disabled_window_body.hbs > 25cf49f > ambari-web/app/views/wizard/step1_view.js 503d5ef > > Diff: https://reviews.apache.org/r/48296/diff/ > > > Testing > --- > > Local ambari-web test passed. > 28646 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 48296: AMBARI-17073 HDF Management install does not allow one to select public repo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48296/ --- (Updated June 7, 2016, 12:36 a.m.) Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17073 https://issues.apache.org/jira/browse/AMBARI-17073 Repository: ambari Description --- To fulfill the requirement of enforcing users to choose local repo when they don’t have internet access, in FE we use the logic of checking whether all versions are stack_default versions. That logic is true for HDP for now, but not for HDF. Diffs (updated) - ambari-web/app/messages.js e8ca9ae ambari-web/app/templates/wizard/step1.hbs 72a2099 ambari-web/app/templates/wizard/step1/public_option_disabled_window_body.hbs 25cf49f ambari-web/app/views/wizard/step1_view.js 503d5ef Diff: https://reviews.apache.org/r/48296/diff/ Testing --- Local ambari-web test passed. 28646 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Review Request 48296: AMBARI-17073 HDF Management install does not allow one to select public repo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48296/ --- Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17073 https://issues.apache.org/jira/browse/AMBARI-17073 Repository: ambari Description --- To fulfill the requirement of enforcing users to choose local repo when they don’t have internet access, in FE we use the logic of checking whether all versions are stack_default versions. That logic is true for HDP for now, but not for HDF. Diffs - ambari-web/app/messages.js e8ca9ae ambari-web/app/templates/wizard/step1.hbs 72a2099 ambari-web/app/templates/wizard/step1/public_option_disabled_window_body.hbs 25cf49f ambari-web/app/views/wizard/step1_view.js 503d5ef Diff: https://reviews.apache.org/r/48296/diff/ Testing --- Local ambari-web test passed. 28646 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang