----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48382/ -----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17101 https://issues.apache.org/jira/browse/AMBARI-17101 Repository: ambari Description ------- 1. Provide better regex and checking. Make it more clear to handle blanks and bad URLs (missing protocol, etc) 2. Treat blank entries as removed, when the user hits Next, as long as they complete ONE OS (or choose Satellite). Diffs ----- ambari-web/app/controllers/installer.js 251daad ambari-web/app/messages.js 2ea1560 ambari-web/app/models/operating_system.js 31f8922 ambari-web/app/models/repository.js 6fc5731 ambari-web/app/templates/wizard/step1.hbs 4eaef8e ambari-web/app/utils/validator.js d29a6bb ambari-web/app/views/wizard/step1_view.js efdae76 ambari-web/test/controllers/installer_test.js e799467 ambari-web/test/utils/validator_test.js f70d1ba ambari-web/test/views/wizard/step1_view_test.js 3621aa9 Diff: https://reviews.apache.org/r/48382/diff/ Testing ------- Modified unit test. Local ambari-web test passed. 28665 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang