Re: Review Request 48794: Ambari Server setup of proxyuser should set default values

2016-06-16 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48794/#review137986
---


Ship it!




Ship It!

- Sebastian Toader


On June 16, 2016, 4:28 p.m., Sandor Magyari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48794/
> ---
> 
> (Updated June 16, 2016, 4:28 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Laszlo Puskas, Oliver Szabo, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17257
> https://issues.apache.org/jira/browse/AMBARI-17257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The resolution of RMP-4514 sets '*' for proxyuser.hosts settings. Stack 
> advisor should be modified to be more restrictive, instead of '*' set ambari 
> server host name in the following properties:
> 
> hadoop.proxyuser.${ambari_proxy_user}.hosts="{{ hostname of ambari server }}"
> webhcat.proxyuser.${ambari_proxy_user}.hosts="{{ hostname of ambari server }}"
> yarn.timeline-service.http-authentication.proxyuser.${ambari_proxy_user}.hosts="{{
>  hostname of ambari server }}"
> 
> 
> Also this setting below is not required, so it will be removed:
> 
> "yarn.timeline-service.http-authentication.proxyuser.ambari-server.users": "*"
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 4db39ce 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> 84a2476 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> d0a18fd 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f1c93ca 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 318f184 
> 
> Diff: https://reviews.apache.org/r/48794/diff/
> 
> 
> Testing
> ---
> 
> Tested with manual cluster deployment.
> 
> Ran 261 tests in 6.797s
> 
> OK
> --
> Total run:1062
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Sandor Magyari
> 
>



Re: Review Request 48794: Ambari Server setup of proxyuser should set default values

2016-06-16 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48794/#review137981
---


Ship it!




Ship It!

- Robert Levas


On June 16, 2016, 10:28 a.m., Sandor Magyari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48794/
> ---
> 
> (Updated June 16, 2016, 10:28 a.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Laszlo Puskas, Oliver Szabo, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17257
> https://issues.apache.org/jira/browse/AMBARI-17257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The resolution of RMP-4514 sets '*' for proxyuser.hosts settings. Stack 
> advisor should be modified to be more restrictive, instead of '*' set ambari 
> server host name in the following properties:
> 
> hadoop.proxyuser.${ambari_proxy_user}.hosts="{{ hostname of ambari server }}"
> webhcat.proxyuser.${ambari_proxy_user}.hosts="{{ hostname of ambari server }}"
> yarn.timeline-service.http-authentication.proxyuser.${ambari_proxy_user}.hosts="{{
>  hostname of ambari server }}"
> 
> 
> Also this setting below is not required, so it will be removed:
> 
> "yarn.timeline-service.http-authentication.proxyuser.ambari-server.users": "*"
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 4db39ce 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> 84a2476 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> d0a18fd 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f1c93ca 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 318f184 
> 
> Diff: https://reviews.apache.org/r/48794/diff/
> 
> 
> Testing
> ---
> 
> Tested with manual cluster deployment.
> 
> Ran 261 tests in 6.797s
> 
> OK
> --
> Total run:1062
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Sandor Magyari
> 
>



Re: Review Request 48794: Ambari Server setup of proxyuser should set default values

2016-06-16 Thread Sandor Magyari

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48794/
---

(Updated June 16, 2016, 2:28 p.m.)


Review request for Ambari, Daniel Gergely, Laszlo Puskas, Oliver Szabo, Robert 
Levas, and Sebastian Toader.


Bugs: AMBARI-17257
https://issues.apache.org/jira/browse/AMBARI-17257


Repository: ambari


Description (updated)
---

The resolution of RMP-4514 sets '*' for proxyuser.hosts settings. Stack advisor 
should be modified to be more restrictive, instead of '*' set ambari server 
host name in the following properties:

hadoop.proxyuser.${ambari_proxy_user}.hosts="{{ hostname of ambari server }}"
webhcat.proxyuser.${ambari_proxy_user}.hosts="{{ hostname of ambari server }}"
yarn.timeline-service.http-authentication.proxyuser.${ambari_proxy_user}.hosts="{{
 hostname of ambari server }}"


Also this setting below is not required, so it will be removed:

"yarn.timeline-service.http-authentication.proxyuser.ambari-server.users": "*"


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
4db39ce 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
84a2476 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
d0a18fd 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py f1c93ca 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 318f184 

Diff: https://reviews.apache.org/r/48794/diff/


Testing
---

Tested with manual cluster deployment.

Ran 261 tests in 6.797s

OK
--
Total run:1062
Total errors:0
Total failures:0


Thanks,

Sandor Magyari



Review Request 48794: Ambari Server setup of proxyuser should set default values

2016-06-16 Thread Sandor Magyari

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48794/
---

Review request for Ambari, Daniel Gergely, Laszlo Puskas, Oliver Szabo, Robert 
Levas, and Sebastian Toader.


Bugs: AMBARI-17257
https://issues.apache.org/jira/browse/AMBARI-17257


Repository: ambari


Description
---

The resolution of RMP-4514 sets '*' for proxyuser.hosts settings. Stack advisor 
should be modified to be more restrictive, instead of '*' set ambari server 
host name in the following properties:

{code}
hadoop.proxyuser.${ambari_proxy_user}.hosts="{{ hostname of ambari server }}"
webhcat.proxyuser.${ambari_proxy_user}.hosts="{{ hostname of ambari server }}"
yarn.timeline-service.http-authentication.proxyuser.${ambari_proxy_user}.hosts="{{
 hostname of ambari server }}"
{code}

Also this setting below is not required, so it will be removed:
{code}
"yarn.timeline-service.http-authentication.proxyuser.ambari-server.users": "*"
{code}


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
4db39ce 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
84a2476 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
d0a18fd 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py f1c93ca 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 318f184 

Diff: https://reviews.apache.org/r/48794/diff/


Testing
---

Tested with manual cluster deployment.

Ran 261 tests in 6.797s

OK
--
Total run:1062
Total errors:0
Total failures:0


Thanks,

Sandor Magyari