Re: Review Request 48967: Provide More Warnings and Messages About Hive's Port Change During Upgrade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48967/#review138808
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On June 21, 2016, 12:21 a.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48967/
> ---
>
> (Updated June 21, 2016, 12:21 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and
> Jayush Luniya.
>
>
> Bugs: AMBARI-17319
> https://issues.apache.org/jira/browse/AMBARI-17319
>
>
> Repository: ambari
>
>
> Description
> ---
>
> After upgrading from HDP 2.2.4.2 to HDP 2.3.2, the
> {{hive.server2.thrift.port}} changed from 1 to 10010.
>
> For users and applications which reference Hive via a direct URL/port
> combination instead of a discovery URL, they will no longer be able to
> contact Hive.
>
> Due to the timing of the next Ambari release, there is a risk of regression
> with any attempt to fix this issue. The best option is to provide a more
> wizard-like approach where Ambari can use the upgrade packs to ask questions
> pertaining to the upgrade. The results of those questions will be passed
> along with the upgrade pack when starting an upgrade so that rudimentary
> decision paths can be taken while performing orchestration. *However, this is
> out of scope for this release*.
>
> - A new pre-requisite check will be created which will determine if the
> upgrade is rolling and if Hive is installed. If both conditions are met, a
> {{WARNING}} will be triggered which will say something similar to:
> bq. You have chosen to perform a rolling upgrade and Hive is currently
> installed. Hive supports rolling upgrades, but its port will change as a
> result of the upgrade. If this is not the desired behavior, then the port can
> be changed back to its original value after the upgrade has completed.
>
> - A new message will be added and displayed to the user post-finalization.
> bq. The hive server port has changed as a result of this rolling upgrade. If
> this port change is not desired, then you can now use Ambari to return hive
> to its original port.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
> e3d70c9
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveRollingPortChangeWarning.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java
> 39ccb95
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
> d23c992
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
> b0cff68
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml
> 0b72254
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
> 712241b
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml
> 4187d64
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml
> 3461ad4
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml
> 4065e87
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml
> 426b452
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml
> 6ce4c81
>
> ambari-server/src/test/java/org/apache/ambari/server/checks/HiveRollingPortChangeWarningTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/48967/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 48967: Provide More Warnings and Messages About Hive's Port Change During Upgrade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48967/#review138684
---
Ship it!
Ship It!
- Alejandro Fernandez
On June 20, 2016, 9:21 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48967/
> ---
>
> (Updated June 20, 2016, 9:21 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and
> Jayush Luniya.
>
>
> Bugs: AMBARI-17319
> https://issues.apache.org/jira/browse/AMBARI-17319
>
>
> Repository: ambari
>
>
> Description
> ---
>
> After upgrading from HDP 2.2.4.2 to HDP 2.3.2, the
> {{hive.server2.thrift.port}} changed from 1 to 10010.
>
> For users and applications which reference Hive via a direct URL/port
> combination instead of a discovery URL, they will no longer be able to
> contact Hive.
>
> Due to the timing of the next Ambari release, there is a risk of regression
> with any attempt to fix this issue. The best option is to provide a more
> wizard-like approach where Ambari can use the upgrade packs to ask questions
> pertaining to the upgrade. The results of those questions will be passed
> along with the upgrade pack when starting an upgrade so that rudimentary
> decision paths can be taken while performing orchestration. *However, this is
> out of scope for this release*.
>
> - A new pre-requisite check will be created which will determine if the
> upgrade is rolling and if Hive is installed. If both conditions are met, a
> {{WARNING}} will be triggered which will say something similar to:
> bq. You have chosen to perform a rolling upgrade and Hive is currently
> installed. Hive supports rolling upgrades, but its port will change as a
> result of the upgrade. If this is not the desired behavior, then the port can
> be changed back to its original value after the upgrade has completed.
>
> - A new message will be added and displayed to the user post-finalization.
> bq. The hive server port has changed as a result of this rolling upgrade. If
> this port change is not desired, then you can now use Ambari to return hive
> to its original port.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
> e3d70c9
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveRollingPortChangeWarning.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java
> 39ccb95
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
> d23c992
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
> b0cff68
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml
> 0b72254
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
> 712241b
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml
> 4187d64
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml
> 3461ad4
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml
> 4065e87
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml
> 426b452
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml
> 6ce4c81
>
> ambari-server/src/test/java/org/apache/ambari/server/checks/HiveRollingPortChangeWarningTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/48967/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Review Request 48967: Provide More Warnings and Messages About Hive's Port Change During Upgrade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48967/
---
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jayush
Luniya.
Bugs: AMBARI-17319
https://issues.apache.org/jira/browse/AMBARI-17319
Repository: ambari
Description
---
After upgrading from HDP 2.2.4.2 to HDP 2.3.2, the {{hive.server2.thrift.port}}
changed from 1 to 10010.
For users and applications which reference Hive via a direct URL/port
combination instead of a discovery URL, they will no longer be able to contact
Hive.
Due to the timing of the next Ambari release, there is a risk of regression
with any attempt to fix this issue. The best option is to provide a more
wizard-like approach where Ambari can use the upgrade packs to ask questions
pertaining to the upgrade. The results of those questions will be passed along
with the upgrade pack when starting an upgrade so that rudimentary decision
paths can be taken while performing orchestration. *However, this is out of
scope for this release*.
- A new pre-requisite check will be created which will determine if the upgrade
is rolling and if Hive is installed. If both conditions are met, a {{WARNING}}
will be triggered which will say something similar to:
bq. You have chosen to perform a rolling upgrade and Hive is currently
installed. Hive supports rolling upgrades, but its port will change as a result
of the upgrade. If this is not the desired behavior, then the port can be
changed back to its original value after the upgrade has completed.
- A new message will be added and displayed to the user post-finalization.
bq. The hive server port has changed as a result of this rolling upgrade. If
this port change is not desired, then you can now use Ambari to return hive to
its original port.
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
e3d70c9
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveRollingPortChangeWarning.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java
39ccb95
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
d23c992
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
b0cff68
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml
0b72254
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
712241b
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml
4187d64
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml
3461ad4
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml
4065e87
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml
426b452
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml
6ce4c81
ambari-server/src/test/java/org/apache/ambari/server/checks/HiveRollingPortChangeWarningTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/48967/diff/
Testing
---
mvn clean test
Thanks,
Jonathan Hurley
