Re: Review Request 49030: Ambari agent log contains failures for AMS status commands

2016-06-21 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49030/#review138875
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 21, 2016, 4 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49030/
> ---
> 
> (Updated June 21, 2016, 4 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmitro Lisnichenko, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-17342
> https://issues.apache.org/jira/browse/AMBARI-17342
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari agent logs contain failures for status commands for AMS collector is 
> status command is executed before AMS collector is actually installed. 
> Reproduced on blueprint deployments
> INFO 2016-06-15 08:48:17,190 PythonReflectiveExecutor.py:65 - Reflective 
> command failed with exception:
> Traceback (most recent call last):
>   File 
> "/usr/lib/python2.6/site-packages/ambari_agent/PythonReflectiveExecutor.py", 
> line 57, in run_file
> imp.load_source('__main__', script)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py",
>  line 143, in 
> AmsCollector().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py",
>  line 98, in security_status
> is_hbase_distributed = 
> security_params['hbase-site']['hbase.cluster.distributed']
> KeyError: 'hbase.cluster.distributed'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  825a48e 
>   
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py
>  195d388 
> 
> Diff: https://reviews.apache.org/r/49030/diff/
> 
> 
> Testing
> ---
> 
> --
> Ran 261 tests in 6.512s
> 
> OK
> --
> Total run:1072
> Total errors:0
> Total failures:0
> OK
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [3.713s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.031s]
> [INFO] Ambari Views .. SUCCESS [3.690s]
> [INFO] ambari-metrics  SUCCESS [0.375s]
> [INFO] Ambari Metrics Common . SUCCESS [0.721s]
> [INFO] Ambari Server . SUCCESS [59.800s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:08.949s
> [INFO] Finished at: Tue Jun 21 18:52:10 EEST 2016
> [INFO] Final Memory: 70M/948M
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49030: Ambari agent log contains failures for AMS status commands

2016-06-21 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49030/#review138873
---


Ship it!




Ship It!

- Aravindan Vijayan


On June 21, 2016, 4 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49030/
> ---
> 
> (Updated June 21, 2016, 4 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmitro Lisnichenko, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-17342
> https://issues.apache.org/jira/browse/AMBARI-17342
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari agent logs contain failures for status commands for AMS collector is 
> status command is executed before AMS collector is actually installed. 
> Reproduced on blueprint deployments
> INFO 2016-06-15 08:48:17,190 PythonReflectiveExecutor.py:65 - Reflective 
> command failed with exception:
> Traceback (most recent call last):
>   File 
> "/usr/lib/python2.6/site-packages/ambari_agent/PythonReflectiveExecutor.py", 
> line 57, in run_file
> imp.load_source('__main__', script)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py",
>  line 143, in 
> AmsCollector().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py",
>  line 98, in security_status
> is_hbase_distributed = 
> security_params['hbase-site']['hbase.cluster.distributed']
> KeyError: 'hbase.cluster.distributed'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  825a48e 
>   
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py
>  195d388 
> 
> Diff: https://reviews.apache.org/r/49030/diff/
> 
> 
> Testing
> ---
> 
> --
> Ran 261 tests in 6.512s
> 
> OK
> --
> Total run:1072
> Total errors:0
> Total failures:0
> OK
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [3.713s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.031s]
> [INFO] Ambari Views .. SUCCESS [3.690s]
> [INFO] ambari-metrics  SUCCESS [0.375s]
> [INFO] Ambari Metrics Common . SUCCESS [0.721s]
> [INFO] Ambari Server . SUCCESS [59.800s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:08.949s
> [INFO] Finished at: Tue Jun 21 18:52:10 EEST 2016
> [INFO] Final Memory: 70M/948M
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 49030: Ambari agent log contains failures for AMS status commands

2016-06-21 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49030/
---

Review request for Ambari, Aravindan Vijayan, Dmitro Lisnichenko, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-17342
https://issues.apache.org/jira/browse/AMBARI-17342


Repository: ambari


Description
---

Ambari agent logs contain failures for status commands for AMS collector is 
status command is executed before AMS collector is actually installed. 
Reproduced on blueprint deployments
INFO 2016-06-15 08:48:17,190 PythonReflectiveExecutor.py:65 - Reflective 
command failed with exception:
Traceback (most recent call last):
  File 
"/usr/lib/python2.6/site-packages/ambari_agent/PythonReflectiveExecutor.py", 
line 57, in run_file
imp.load_source('__main__', script)
  File 
"/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py",
 line 143, in 
AmsCollector().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 257, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py",
 line 98, in security_status
is_hbase_distributed = 
security_params['hbase-site']['hbase.cluster.distributed']
KeyError: 'hbase.cluster.distributed'


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
 825a48e 
  
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py
 195d388 

Diff: https://reviews.apache.org/r/49030/diff/


Testing
---

--
Ran 261 tests in 6.512s

OK
--
Total run:1072
Total errors:0
Total failures:0
OK

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [3.713s]
[INFO] Apache Ambari Project POM . SUCCESS [0.031s]
[INFO] Ambari Views .. SUCCESS [3.690s]
[INFO] ambari-metrics  SUCCESS [0.375s]
[INFO] Ambari Metrics Common . SUCCESS [0.721s]
[INFO] Ambari Server . SUCCESS [59.800s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:08.949s
[INFO] Finished at: Tue Jun 21 18:52:10 EEST 2016
[INFO] Final Memory: 70M/948M


Thanks,

Dmytro Sen