Re: Review Request 49114: AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's alert_llap_app_status.py and KNOX's upgrade.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49114/#review139167 --- Ship it! Ship It! - Alejandro Fernandez On June 22, 2016, 10:51 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49114/ > --- > > (Updated June 22, 2016, 10:51 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-17384 > https://issues.apache.org/jira/browse/AMBARI-17384 > > > Repository: ambari > > > Description > --- > > AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's > alert_llap_app_status.py and KNOX's upgrade.py > - Use 'Script.get_stack_root()'. > > Also adding check for trimming the 'llapstatus' o/p only if start of JSON > blob is > 0th line. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py > 33bf139 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > d1c8401 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py > 8c71260 > > Diff: https://reviews.apache.org/r/49114/diff/ > > > Testing > --- > > Python UT passes. > > > Thanks, > > Swapan Shridhar > >
Re: Review Request 49114: AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's alert_llap_app_status.py and KNOX's upgrade.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49114/#review139162 --- Ship it! Ship It! - Sumit Mohanty On June 22, 2016, 10:51 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49114/ > --- > > (Updated June 22, 2016, 10:51 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-17384 > https://issues.apache.org/jira/browse/AMBARI-17384 > > > Repository: ambari > > > Description > --- > > AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's > alert_llap_app_status.py and KNOX's upgrade.py > - Use 'Script.get_stack_root()'. > > Also adding check for trimming the 'llapstatus' o/p only if start of JSON > blob is > 0th line. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py > 33bf139 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > d1c8401 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py > 8c71260 > > Diff: https://reviews.apache.org/r/49114/diff/ > > > Testing > --- > > Python UT passes. > > > Thanks, > > Swapan Shridhar > >
Review Request 49114: AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's alert_llap_app_status.py and KNOX's upgrade.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49114/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-17384 https://issues.apache.org/jira/browse/AMBARI-17384 Repository: ambari Description --- AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's alert_llap_app_status.py and KNOX's upgrade.py - Use 'Script.get_stack_root()'. Also adding check for trimming the 'llapstatus' o/p only if start of JSON blob is > 0th line. Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py 33bf139 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py d1c8401 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py 8c71260 Diff: https://reviews.apache.org/r/49114/diff/ Testing --- Python UT passes. Thanks, Swapan Shridhar
