Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49429/#review140825 --- Ship it! Ship It! - Jayush Luniya On June 30, 2016, 11:48 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49429/ > --- > > (Updated June 30, 2016, 11:48 a.m.) > > > Review request for Ambari, Don Bosco Durai, Jayush Luniya, Oliver Szabo, > Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17492 > https://issues.apache.org/jira/browse/AMBARI-17492 > > > Repository: ambari > > > Description > --- > > Cluster with HDF stack should show only HDF services, HDP cluster should not > show NiFi > > > Diffs > - > > ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > bdb5fb1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 8bb6225 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > fe7e757 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > a89b3d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > bfab139 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2 > PRE-CREATION > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > 48e071d > ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 > > Diff: https://reviews.apache.org/r/49429/diff/ > > > Testing > --- > > Tested on local cluster. > > ambari-server: > OK > -- > Total run:1085 > Total errors:0 > Total failures:0 > > > Thanks, > > Miklos Gergely > >
Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49429/#review140771 --- Ship it! Ship It! - Sebastian Toader On June 30, 2016, 1:48 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49429/ > --- > > (Updated June 30, 2016, 1:48 p.m.) > > > Review request for Ambari, Don Bosco Durai, Jayush Luniya, Oliver Szabo, > Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17492 > https://issues.apache.org/jira/browse/AMBARI-17492 > > > Repository: ambari > > > Description > --- > > Cluster with HDF stack should show only HDF services, HDP cluster should not > show NiFi > > > Diffs > - > > ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > bdb5fb1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 8bb6225 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > fe7e757 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > a89b3d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > bfab139 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2 > PRE-CREATION > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > 48e071d > ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 > > Diff: https://reviews.apache.org/r/49429/diff/ > > > Testing > --- > > Tested on local cluster. > > ambari-server: > OK > -- > Total run:1085 > Total errors:0 > Total failures:0 > > > Thanks, > > Miklos Gergely > >
Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack
> On June 30, 2016, 9:55 p.m., Jayush Luniya wrote:
> > Can you add more details in the description on how this logic will work? I
> > dont have much insights into LogSearch.
> >
> > Instead of creating HadoopServiceConfig.json.j2 can we not add a
> > service_name property in the service templates? Example
> > ambari/ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2
> > could have service_name : "ACCUMULO" so that the list of templates can be
> > filtered based on service_names in the stack definition.
> >
> > Long term we should definitely push this down to the service-level. We wont
> > be able to support logsearch for custom services.
>
> Oliver Szabo wrote:
> we will push down to services, with logsearch.json in all services, we
> already designed that how we will do, but that will be a much bigger change
>
> Oliver Szabo wrote:
> HadoopServiceConfig.json is for logsearch portal UI itself, the input
> configs are for logfeeder. (thas why the mapping is not there)
>
> about our long term solution:
>
> we will have a logsearch.json, same as like kerberos.json, and we will do
> exactly that you described with service name mappings, templates etc. we will
> send the content with commandJsons (only with logsearch/logfeeder role)
> example content:
> "service": "ACCUMULO",
> "service_name": "Accumulo",
> "logs" : { ... }.
> ...
> "template" : {
>// input template with configuration references like: ${log.dir}
> }
The goal of this modification is to show a button on the main screen of the
LogSearch portal only for those services which are actually available in the
stack. This json describes which they are, so the services not present in the
stack must be filtered out.
- Miklos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49429/#review140243
---
On June 30, 2016, 11:48 a.m., Miklos Gergely wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49429/
> ---
>
> (Updated June 30, 2016, 11:48 a.m.)
>
>
> Review request for Ambari, Don Bosco Durai, Jayush Luniya, Oliver Szabo,
> Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-17492
> https://issues.apache.org/jira/browse/AMBARI-17492
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Cluster with HDF stack should show only HDF services, HDP cluster should not
> show NiFi
>
>
> Diffs
> -
>
> ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
> bdb5fb1
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> 8bb6225
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> fe7e757
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
> a89b3d6
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
> bfab139
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
> PRE-CREATION
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py
> 48e071d
> ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733
>
> Diff: https://reviews.apache.org/r/49429/diff/
>
>
> Testing
> ---
>
> Tested on local cluster.
>
> ambari-server:
> OK
> --
> Total run:1085
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack
> On June 30, 2016, 9:55 p.m., Jayush Luniya wrote:
> > Can you add more details in the description on how this logic will work? I
> > dont have much insights into LogSearch.
> >
> > Instead of creating HadoopServiceConfig.json.j2 can we not add a
> > service_name property in the service templates? Example
> > ambari/ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2
> > could have service_name : "ACCUMULO" so that the list of templates can be
> > filtered based on service_names in the stack definition.
> >
> > Long term we should definitely push this down to the service-level. We wont
> > be able to support logsearch for custom services.
>
> Oliver Szabo wrote:
> we will push down to services, with logsearch.json in all services, we
> already designed that how we will do, but that will be a much bigger change
HadoopServiceConfig.json is for logsearch portal UI itself, the input configs
are for logfeeder. (thas why the mapping is not there)
about our long term solution:
we will have a logsearch.json, same as like kerberos.json, and we will do
exactly that you described with service name mappings, templates etc. we will
send the content with commandJsons (only with logsearch/logfeeder role)
example content:
"service": "ACCUMULO",
"service_name": "Accumulo",
"logs" : { ... }.
...
"template" : {
// input template with configuration references like: ${log.dir}
}
- Oliver
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49429/#review140243
---
On June 30, 2016, 11:48 a.m., Miklos Gergely wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49429/
> ---
>
> (Updated June 30, 2016, 11:48 a.m.)
>
>
> Review request for Ambari, Don Bosco Durai, Jayush Luniya, Oliver Szabo,
> Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-17492
> https://issues.apache.org/jira/browse/AMBARI-17492
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Cluster with HDF stack should show only HDF services, HDP cluster should not
> show NiFi
>
>
> Diffs
> -
>
> ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
> bdb5fb1
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> 8bb6225
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> fe7e757
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
> a89b3d6
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
> bfab139
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
> PRE-CREATION
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py
> 48e071d
> ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733
>
> Diff: https://reviews.apache.org/r/49429/diff/
>
>
> Testing
> ---
>
> Tested on local cluster.
>
> ambari-server:
> OK
> --
> Total run:1085
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack
> On June 30, 2016, 9:55 p.m., Jayush Luniya wrote: > > Can you add more details in the description on how this logic will work? I > > dont have much insights into LogSearch. > > > > Instead of creating HadoopServiceConfig.json.j2 can we not add a > > service_name property in the service templates? Example > > ambari/ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2 > > could have service_name : "ACCUMULO" so that the list of templates can be > > filtered based on service_names in the stack definition. > > > > Long term we should definitely push this down to the service-level. We wont > > be able to support logsearch for custom services. we will push down to services, with logsearch.json in all services, we already designed that how we will do, but that will be a much bigger change - Oliver --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49429/#review140243 --- On June 30, 2016, 11:48 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49429/ > --- > > (Updated June 30, 2016, 11:48 a.m.) > > > Review request for Ambari, Don Bosco Durai, Jayush Luniya, Oliver Szabo, > Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17492 > https://issues.apache.org/jira/browse/AMBARI-17492 > > > Repository: ambari > > > Description > --- > > Cluster with HDF stack should show only HDF services, HDP cluster should not > show NiFi > > > Diffs > - > > ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > bdb5fb1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 8bb6225 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > fe7e757 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > a89b3d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > bfab139 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2 > PRE-CREATION > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > 48e071d > ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 > > Diff: https://reviews.apache.org/r/49429/diff/ > > > Testing > --- > > Tested on local cluster. > > ambari-server: > OK > -- > Total run:1085 > Total errors:0 > Total failures:0 > > > Thanks, > > Miklos Gergely > >
Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49429/#review140243 --- Can you add more details in the description on how this logic will work? I dont have much insights into LogSearch. Instead of creating HadoopServiceConfig.json.j2 can we not add a service_name property in the service templates? Example ambari/ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2 could have service_name : "ACCUMULO" so that the list of templates can be filtered based on service_names in the stack definition. Long term we should definitely push this down to the service-level. We wont be able to support logsearch for custom services. - Jayush Luniya On June 30, 2016, 11:48 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49429/ > --- > > (Updated June 30, 2016, 11:48 a.m.) > > > Review request for Ambari, Don Bosco Durai, Jayush Luniya, Oliver Szabo, > Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17492 > https://issues.apache.org/jira/browse/AMBARI-17492 > > > Repository: ambari > > > Description > --- > > Cluster with HDF stack should show only HDF services, HDP cluster should not > show NiFi > > > Diffs > - > > ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > bdb5fb1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 8bb6225 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > fe7e757 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > a89b3d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > bfab139 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2 > PRE-CREATION > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > 48e071d > ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 > > Diff: https://reviews.apache.org/r/49429/diff/ > > > Testing > --- > > Tested on local cluster. > > ambari-server: > OK > -- > Total run:1085 > Total errors:0 > Total failures:0 > > > Thanks, > > Miklos Gergely > >
Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49429/ --- (Updated June 30, 2016, 10:33 a.m.) Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. Changes --- Remove HadoopServiceConfig.json from the rpm Bugs: AMBARI-17492 https://issues.apache.org/jira/browse/AMBARI-17492 Repository: ambari Description --- Cluster with HDF stack should show only HDF services, HDP cluster should not show NiFi Diffs (updated) - ambari-logsearch/ambari-logsearch-assembly/pom.xml 958232e ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java bdb5fb1 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 8bb6225 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java fe7e757 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py a89b3d6 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py bfab139 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2 PRE-CREATION ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 48e071d ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 Diff: https://reviews.apache.org/r/49429/diff/ Testing --- Tested on local cluster. ambari-server: OK -- Total run:1085 Total errors:0 Total failures:0 Thanks, Miklos Gergely
Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49429/#review140125 --- Ship it! Ship It! note: exclude HadoopServices.json from the deb/rpm build - Oliver Szabo On June 30, 2016, 8:42 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49429/ > --- > > (Updated June 30, 2016, 8:42 a.m.) > > > Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, > and Sumit Mohanty. > > > Bugs: AMBARI-17492 > https://issues.apache.org/jira/browse/AMBARI-17492 > > > Repository: ambari > > > Description > --- > > Cluster with HDF stack should show only HDF services, HDP cluster should not > show NiFi > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > bdb5fb1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 8bb6225 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > fe7e757 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > a89b3d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > bfab139 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2 > PRE-CREATION > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > 48e071d > ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 > > Diff: https://reviews.apache.org/r/49429/diff/ > > > Testing > --- > > Tested on local cluster. > > ambari-server: > OK > -- > Total run:1085 > Total errors:0 > Total failures:0 > > > Thanks, > > Miklos Gergely > >
Review Request 49429: Logsearch shows all the services not only those which are available in the stack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49429/ --- Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. Bugs: AMBARI-17492 https://issues.apache.org/jira/browse/AMBARI-17492 Repository: ambari Description --- Cluster with HDF stack should show only HDF services, HDP cluster should not show NiFi Diffs - ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java bdb5fb1 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 8bb6225 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java fe7e757 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py a89b3d6 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py bfab139 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2 PRE-CREATION ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 48e071d ambari-server/src/test/python/stacks/2.4/configs/default.json 233a733 Diff: https://reviews.apache.org/r/49429/diff/ Testing --- Tested on local cluster. ambari-server: OK -- Total run:1085 Total errors:0 Total failures:0 Thanks, Miklos Gergely
