Re: Review Request 49431: Falcon start fails non-root + umask 027

2016-06-30 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49431/#review140131
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Червень 30, 2016, 10:01 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49431/
> ---
> 
> (Updated Червень 30, 2016, 10:01 до полудня)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17494
> https://issues.apache.org/jira/browse/AMBARI-17494
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
>  line 177, in 
> FalconServer().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 280, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
>  line 49, in start
> self.configure(env, upgrade_type=upgrade_type)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
>  line 44, in configure
> falcon('server', action='config', upgrade_type=upgrade_type)
>   File 
> "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, 
> in thunk
> return fn(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py",
>  line 163, in falcon
> source = params.falcon_extensions_source_dir)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 
> 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 458, in action_create_on_execute
> self.action_delayed("create")
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 455, in action_delayed
> self.get_hdfs_resource_executor().action_delayed(action_name, self)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 254, in action_delayed
> self._create_resource()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 271, in _create_resource
> self._copy_from_local_directory(self.main_resource.resource.target, 
> self.main_resource.resource.source)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 280, in _copy_from_local_directory
> self._copy_from_local_directory(new_target, new_source)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 274, in _copy_from_local_directory
> for next_path_part in os.listdir(source):
> OSError: [Errno 13] Permission denied: 
> '/usr/hdp/current/falcon-server/extensions/mirroring'
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/resource_management/core/sudo.py 4ea44bc 
>   
> ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
>  12d9ee4 
> 
> Diff: https://reviews.apache.org/r/49431/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Review Request 49431: Falcon start fails non-root + umask 027

2016-06-30 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49431/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17494
https://issues.apache.org/jira/browse/AMBARI-17494


Repository: ambari


Description
---

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
 line 177, in 
FalconServer().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 280, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
 line 49, in start
self.configure(env, upgrade_type=upgrade_type)
  File 
"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py",
 line 44, in configure
falcon('server', action='config', upgrade_type=upgrade_type)
  File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
line 89, in thunk
return fn(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py",
 line 163, in falcon
source = params.falcon_extensions_source_dir)
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 458, in action_create_on_execute
self.action_delayed("create")
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 455, in action_delayed
self.get_hdfs_resource_executor().action_delayed(action_name, self)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 254, in action_delayed
self._create_resource()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 271, in _create_resource
self._copy_from_local_directory(self.main_resource.resource.target, 
self.main_resource.resource.source)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 280, in _copy_from_local_directory
self._copy_from_local_directory(new_target, new_source)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 274, in _copy_from_local_directory
for next_path_part in os.listdir(source):
OSError: [Errno 13] Permission denied: 
'/usr/hdp/current/falcon-server/extensions/mirroring'


Diffs
-

  ambari-common/src/main/python/resource_management/core/sudo.py 4ea44bc 
  
ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
 12d9ee4 

Diff: https://reviews.apache.org/r/49431/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk