Re: Review Request 49439: porting changes of AMBARI-17081 and AMBARI-16427 in hive2 view

2016-06-30 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49439/#review140149
---


Ship it!




Ship It!

- Gaurav Nagar


On June 30, 2016, 12:11 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49439/
> ---
> 
> (Updated June 30, 2016, 12:11 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17487
> https://issues.apache.org/jira/browse/AMBARI-17487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> patches added and conflicts resolved
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java
>  d00dc24 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
>  847a4b8 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js
>  50cea36 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  84637e5 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  578101f 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
> d72ae8c 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  f334a3d 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/ParseUtilsTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49439/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 49439: porting changes of AMBARI-17081 and AMBARI-16427 in hive2 view

2016-06-30 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49439/#review140145
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 30, 2016, 12:11 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49439/
> ---
> 
> (Updated June 30, 2016, 12:11 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17487
> https://issues.apache.org/jira/browse/AMBARI-17487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> patches added and conflicts resolved
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java
>  d00dc24 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
>  847a4b8 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js
>  50cea36 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  84637e5 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  578101f 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
> d72ae8c 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  f334a3d 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/ParseUtilsTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49439/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Review Request 49439: porting changes of AMBARI-17081 and AMBARI-16427 in hive2 view

2016-06-30 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49439/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17487
https://issues.apache.org/jira/browse/AMBARI-17487


Repository: ambari


Description
---

patches added and conflicts resolved


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java
 d00dc24 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java
 847a4b8 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js
 50cea36 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 84637e5 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js 
578101f 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss 
d72ae8c 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 f334a3d 
  
contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/ParseUtilsTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/49439/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore