Re: Review Request 49618: Hive WebHCat Service Check Fails During Upgrade Due To Missing Configurations Files

2016-07-05 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49618/#review140812
---


Ship it!




Ship It!

- Nate Cole


On July 4, 2016, 9:02 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49618/
> ---
> 
> (Updated July 4, 2016, 9:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-17557
> https://issues.apache.org/jira/browse/AMBARI-17557
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A leftover variable from a prior loop was causing problems for 
> WebHCat/HCatalog symlinking from HDP 2.2 - Other components didn't have a 
> problem since they only have 1 directory to worry about correcting per 
> component. But Hive has two:
> 
> ```
>   "hive-hcatalog": [
> {
>   "conf_dir": "/etc/hive-webhcat/conf",
>   "prefix": "/etc/hive-webhcat",
>   "current_dir": 
> "{0}/current/hive-webhcat/etc/webhcat".format(STACK_ROOT_PATTERN)
> },
> {
>   "conf_dir": "/etc/hive-hcatalog/conf",
>   "prefix": "/etc/hive-hcatalog",
>   "current_dir": 
> "{0}/current/hive-webhcat/etc/hcatalog".format(STACK_ROOT_PATTERN)
> }
>   ]
> ```
> 
> As a result, we had a wrong symlink:
> ```
> [root@c6402 hive-webhcat]# ll /etc/hive-webhcat/
> total 8
> drwxr-xr-x 3 root root   4096 Jul  5 00:49 2.4.2.0-236
> lrwxrwxrwx 1 root root 29 Jul  5 00:49 conf -> 
> /etc/hive-hcatalog/conf.backup
> drwxr-xr-x 2 hcat hadoop 4096 Jul  4 23:25 conf.backup
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  c810438 
> 
> Diff: https://reviews.apache.org/r/49618/diff/
> 
> 
> Testing
> ---
> 
> --
> Total run:1095
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>



Review Request 49618: Hive WebHCat Service Check Fails During Upgrade Due To Missing Configurations Files

2016-07-04 Thread Jonathan Hurley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49618/
---

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-17557
https://issues.apache.org/jira/browse/AMBARI-17557


Repository: ambari


Description
---

A leftover variable from a prior loop was causing problems for WebHCat/HCatalog 
symlinking from HDP 2.2 - Other components didn't have a problem since they 
only have 1 directory to worry about correcting per component. But Hive has two:

```
  "hive-hcatalog": [
{
  "conf_dir": "/etc/hive-webhcat/conf",
  "prefix": "/etc/hive-webhcat",
  "current_dir": 
"{0}/current/hive-webhcat/etc/webhcat".format(STACK_ROOT_PATTERN)
},
{
  "conf_dir": "/etc/hive-hcatalog/conf",
  "prefix": "/etc/hive-hcatalog",
  "current_dir": 
"{0}/current/hive-webhcat/etc/hcatalog".format(STACK_ROOT_PATTERN)
}
  ]
```

As a result, we had a wrong symlink:
```
[root@c6402 hive-webhcat]# ll /etc/hive-webhcat/
total 8
drwxr-xr-x 3 root root   4096 Jul  5 00:49 2.4.2.0-236
lrwxrwxrwx 1 root root 29 Jul  5 00:49 conf -> 
/etc/hive-hcatalog/conf.backup
drwxr-xr-x 2 hcat hadoop 4096 Jul  4 23:25 conf.backup
```


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 c810438 

Diff: https://reviews.apache.org/r/49618/diff/


Testing
---

--
Total run:1095
Total errors:0
Total failures:0
OK


Thanks,

Jonathan Hurley