Re: Review Request 49727: AMBARI-17598 Permission mismatch b/w 'Cluster user' and 'read only user' from older ambari

2016-07-06 Thread Yusaku Sako

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49727/#review141110
---


Ship it!




Ship It!

- Yusaku Sako


On July 6, 2016, 9:27 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49727/
> ---
> 
> (Updated July 6, 2016, 9:27 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17598
> https://issues.apache.org/jira/browse/AMBARI-17598
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In ambari 2.2.2 "Show only my widgets" check box was not shown for 'read 
> only' user.
> But in ambari-2.4.0, cluster user is being shown with this particular 
> checkbox.
> Steps to reproduce :
> 1) Create a cluster user.
> 2) Login as cluster user.
> 3) Go to browse widget.
> 4) Check that "Show only my widgets" is not shown for cluster user.
> Since 'read only user' in ambari 2.2.2 corresponds to the cluster user in 
> 2.4.0, even the permissions should remain intact.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/templates/common/modal_popups/widget_browser_footer.hbs 
> 3d58948 
>   ambari-web/app/templates/common/modal_popups/widget_browser_popup.hbs 
> 2b94e9d 
> 
> Diff: https://reviews.apache.org/r/49727/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 28944 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>



Review Request 49727: AMBARI-17598 Permission mismatch b/w 'Cluster user' and 'read only user' from older ambari

2016-07-06 Thread Zhe (Joe) Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49727/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-17598
https://issues.apache.org/jira/browse/AMBARI-17598


Repository: ambari


Description
---

In ambari 2.2.2 "Show only my widgets" check box was not shown for 'read only' 
user.
But in ambari-2.4.0, cluster user is being shown with this particular checkbox.
Steps to reproduce :
1) Create a cluster user.
2) Login as cluster user.
3) Go to browse widget.
4) Check that "Show only my widgets" is not shown for cluster user.
Since 'read only user' in ambari 2.2.2 corresponds to the cluster user in 
2.4.0, even the permissions should remain intact.


Diffs
-

  ambari-web/app/templates/common/modal_popups/widget_browser_footer.hbs 
3d58948 
  ambari-web/app/templates/common/modal_popups/widget_browser_popup.hbs 2b94e9d 

Diff: https://reviews.apache.org/r/49727/diff/


Testing
---

Local ambari-web test passed.
28944 tests complete (24 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang