Re: Review Request 49861: Changes to stack advisor framework to help with service advisors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49861/#review141670 --- Ship it! Ship It! - Tim Thorpe On July 9, 2016, 9:22 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49861/ > --- > > (Updated July 9, 2016, 9:22 p.m.) > > > Review request for Ambari, Dmytro Sen, Jayush Luniya, Matt, Srimanth Gunturi, > and Tim Thorpe. > > > Bugs: AMBARI-17642 > https://issues.apache.org/jira/browse/AMBARI-17642 > > > Repository: ambari > > > Description > --- > > The following changes are needed in the stack advisor framework to help with > service advisors: > > - Add additional logging to show why a service advisor implementation was not > loaded > - Move `isSecurityEnabled` from `stacks/HDP/2.0.6/services/stack_advisor.py` > to a class member of `DefaultStackAdvisor` in `stacks/stack_advisor.py` so > that all stack and service advisors may be able to use it > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 3f66216 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 990c314 > ambari-server/src/main/resources/stacks/stack_advisor.py 23c0320 > > Diff: https://reviews.apache.org/r/49861/diff/ > > > Testing > --- > > Manually tested > > # Local test results (python only): > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 2:56.308s > [INFO] Finished at: Sat Jul 09 16:12:31 EDT 2016 > [INFO] Final Memory: 65M/1700M > [INFO] > > > #Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
Re: Review Request 49861: Changes to stack advisor framework to help with service advisors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49861/#review141634 --- Ship it! Ship It! - Matt On July 9, 2016, 2:22 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49861/ > --- > > (Updated July 9, 2016, 2:22 p.m.) > > > Review request for Ambari, Dmytro Sen, Jayush Luniya, Matt, Srimanth Gunturi, > and Tim Thorpe. > > > Bugs: AMBARI-17642 > https://issues.apache.org/jira/browse/AMBARI-17642 > > > Repository: ambari > > > Description > --- > > The following changes are needed in the stack advisor framework to help with > service advisors: > > - Add additional logging to show why a service advisor implementation was not > loaded > - Move `isSecurityEnabled` from `stacks/HDP/2.0.6/services/stack_advisor.py` > to a class member of `DefaultStackAdvisor` in `stacks/stack_advisor.py` so > that all stack and service advisors may be able to use it > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 3f66216 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 990c314 > ambari-server/src/main/resources/stacks/stack_advisor.py 23c0320 > > Diff: https://reviews.apache.org/r/49861/diff/ > > > Testing > --- > > Manually tested > > # Local test results (python only): > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 2:56.308s > [INFO] Finished at: Sat Jul 09 16:12:31 EDT 2016 > [INFO] Final Memory: 65M/1700M > [INFO] > > > #Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
Re: Review Request 49861: Changes to stack advisor framework to help with service advisors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49861/#review141414 --- Ship it! Ship It! - Sumit Mohanty On July 9, 2016, 9:22 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49861/ > --- > > (Updated July 9, 2016, 9:22 p.m.) > > > Review request for Ambari, Dmytro Sen, Jayush Luniya, Matt, Srimanth Gunturi, > and Tim Thorpe. > > > Bugs: AMBARI-17642 > https://issues.apache.org/jira/browse/AMBARI-17642 > > > Repository: ambari > > > Description > --- > > The following changes are needed in the stack advisor framework to help with > service advisors: > > - Add additional logging to show why a service advisor implementation was not > loaded > - Move `isSecurityEnabled` from `stacks/HDP/2.0.6/services/stack_advisor.py` > to a class member of `DefaultStackAdvisor` in `stacks/stack_advisor.py` so > that all stack and service advisors may be able to use it > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 3f66216 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 990c314 > ambari-server/src/main/resources/stacks/stack_advisor.py 23c0320 > > Diff: https://reviews.apache.org/r/49861/diff/ > > > Testing > --- > > Manually tested > > # Local test results (python only): > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 2:56.308s > [INFO] Finished at: Sat Jul 09 16:12:31 EDT 2016 > [INFO] Final Memory: 65M/1700M > [INFO] > > > #Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
Review Request 49861: Changes to stack advisor framework to help with service advisors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49861/ --- Review request for Ambari, Dmytro Sen, Jayush Luniya, Matt, Srimanth Gunturi, and Tim Thorpe. Bugs: AMBARI-17642 https://issues.apache.org/jira/browse/AMBARI-17642 Repository: ambari Description --- The following changes are needed in the stack advisor framework to help with service advisors: - Add additional logging to show why a service advisor implementation was not loaded - Move `isSecurityEnabled` from `stacks/HDP/2.0.6/services/stack_advisor.py` to a class member of `DefaultStackAdvisor` in `stacks/stack_advisor.py` so that all stack and service advisors may be able to use it Diffs - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 3f66216 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 990c314 ambari-server/src/main/resources/stacks/stack_advisor.py 23c0320 Diff: https://reviews.apache.org/r/49861/diff/ Testing --- Manually tested # Local test results (python only): [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 2:56.308s [INFO] Finished at: Sat Jul 09 16:12:31 EDT 2016 [INFO] Final Memory: 65M/1700M [INFO] #Jenkins test results: PENDING Thanks, Robert Levas
