Re: Review Request 49972: Check znode exits with retry during logsearch server setup too (for blueprints)

2016-07-13 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49972/#review142064
---


Ship it!




Ship It!

- Robert Nettleton


On July 12, 2016, 11:57 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49972/
> ---
> 
> (Updated July 12, 2016, 11:57 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17680
> https://issues.apache.org/jira/browse/AMBARI-17680
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> if logsearch and solr on different nodes, the first operation for logsearch 
> is upload configurations to zookeeper into /configs -> that is not 
> exists, so the IOEexception error is a bit misleading, better to check znode 
> first.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  af762ec 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> b53943f 
> 
> Diff: https://reviews.apache.org/r/49972/diff/
> 
> 
> Testing
> ---
> 
> Total run:1018
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>



Re: Review Request 49972: Check znode exits with retry during logsearch server setup too (for blueprints)

2016-07-12 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49972/#review142020
---


Ship it!




Ship It!

- Sebastian Toader


On July 13, 2016, 1:57 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49972/
> ---
> 
> (Updated July 13, 2016, 1:57 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17680
> https://issues.apache.org/jira/browse/AMBARI-17680
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> if logsearch and solr on different nodes, the first operation for logsearch 
> is upload configurations to zookeeper into /configs -> that is not 
> exists, so the IOEexception error is a bit misleading, better to check znode 
> first.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  af762ec 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> b53943f 
> 
> Diff: https://reviews.apache.org/r/49972/diff/
> 
> 
> Testing
> ---
> 
> Total run:1018
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>



Review Request 49972: Check znode exits with retry during logsearch server setup too (for blueprints)

2016-07-12 Thread Oliver Szabo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49972/
---

Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, and 
Sebastian Toader.


Bugs: AMBARI-17680
https://issues.apache.org/jira/browse/AMBARI-17680


Repository: ambari


Description
---

if logsearch and solr on different nodes, the first operation for logsearch is 
upload configurations to zookeeper into /configs -> that is not exists, 
so the IOEexception error is a bit misleading, better to check znode first.


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 af762ec 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py b53943f 

Diff: https://reviews.apache.org/r/49972/diff/


Testing
---

Total run:1018
Total errors:0
Total failures:0


Thanks,

Oliver Szabo