Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-15 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142413
---


Ship it!




Ship It!

- Jayush Luniya


On July 14, 2016, 2:23 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
> 
> (Updated July 14, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful 
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  0df8270 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  145c216 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f24bd83 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  63a1100 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  f47eee4 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  7e0477f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  fad4b9b 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  dfcad32 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  5941ca1 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  44a0446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
> 
> Diff: https://reviews.apache.org/r/49987/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger Downgrade from stack 2.5 to 2.4
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-14 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142266
---



Can we add any unit tests to cover these cases?

- Jayush Luniya


On July 14, 2016, 2:23 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
> 
> (Updated July 14, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful 
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  0df8270 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  145c216 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f24bd83 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  63a1100 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  f47eee4 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  7e0477f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  fad4b9b 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  dfcad32 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  5941ca1 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  44a0446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
> 
> Diff: https://reviews.apache.org/r/49987/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger Downgrade from stack 2.5 to 2.4
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-14 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142242
---


Ship it!




Ship It!

- Jonathan Hurley


On July 14, 2016, 10:23 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
> 
> (Updated July 14, 2016, 10:23 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful 
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  0df8270 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  145c216 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f24bd83 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  63a1100 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  f47eee4 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  7e0477f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  fad4b9b 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  dfcad32 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  5941ca1 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  44a0446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
> 
> Diff: https://reviews.apache.org/r/49987/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger Downgrade from stack 2.5 to 2.4
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-14 Thread Mugdha Varadkar 


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > I'm curious if you can make this simply by only using the 
> > `commandParams/version` property when calculating what to do. Here's an 
> > example of the various values during normal commands, upgrades, and 
> > downgrades. `version` seems to always be what you want, no?
> > 
> > ```
> > NORMAL COMMANDS
> >   hostLevelParams
> > stack_name = HDP
> > stack_version = 2.3
> > current_version = 2.3.4.0-1234
> > 
> >   commandParams
> > version = 2.3.4.0-1234
> > 
> > 
> > UPGRADE
> >   hostLevelParams
> > stack_name = HDP
> > stack_version = 2.3
> > current_version = 2.3.4.0-1234
> > 
> >   commandParams
> > original_stack = 2.3
> > target_stack = 2.5  
> > upgrade_direction = UPGRADE
> > version = 2.5.0.0-
> > 
> > 
> > DOWNGRADE
> >   hostLevelParams
> > stack_name = HDP
> > stack_version = 2.5
> > current_version = 2.3.4.0-1234
> > 
> >   commandParams
> > original_stack = 2.3
> > target_stack = 2.5  
> > upgrade_direction = DOWNGRADE
> > version = 2.3.4.0-1234
> > downgrade_from_version = 2.5.0.0-
> > ```
> 
> Mugdha Varadkar wrote:
> Thanks Jonathan Hurley. Actually this was done by taking reference from 
> similar code from 
> Ambari.(https://github.com/apache/ambari/commit/63f8d74f806aa55fcbb4e51b2c84a3fd0146c062#diff-a9a4cbc8111690ebc76b1e83491d2dba)
> 
> @Jayush Luniya, can we use version in NORMAL COMMANDS/UPGRADE/DOWNGRADE 
> scenarios?
> 
> Jonathan Hurley wrote:
> Actually, an even better option is this:
> 
> ```
> # determine which version to use for checking stack features; version is 
> the most accurate but
> # may not always be available (especially on first install of the cluster)
> version_for_stack_feature_checks = version if not None else 
> stack_version_unformatted
> ```
> 
> It's possible that on initial install, `version` isn't defined since we 
> haven't calculated it yet. So, the above defaults to the stack version in 
> that case. Now, version covers all 3 of your scenarios.

Updated in latest patch


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py,
> >  line 60
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.
> 
> Mugdha Varadkar wrote:
> @Jonathan Hurley, am directly using check_stack_feature here because even 
> if we pass version as ---> 2.3.4.0-1234, the code has format flag as true, 
> which calls format_stack_version() function which can be used for comparision.
> "compare_versions(stack_version, min_version, format = True) < 0"
> 
> Also I have added the check for "version" in this way "if 
> upgrade_direction == Direction.DOWNGRADE and version"
> 
> Jonathan Hurley wrote:
> My point was that the code was originally:
> `foo and check_stack_feature(feature, foo) `
> 
> You don't need the "foo and" part since the check_stack_feature is 
> checking it for None anyway.

Updated in latest patch


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py,
> >  line 61
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.
> 
> Mugdha Varadkar wrote:
> Same as above

Updated in latest patch


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py,
> >  line 58
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.
> 
> Mugdha Varadkar wrote:
> Same as above

Updated in latest patch


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py,
> >  line 57
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.
> 
> Mugdha Varadkar wrote:
> Same as above

Updated in latest patch


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py,
> >  line 47
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.
> 
> Mugdha Varadkar wrote:
> Same as above

Updated in latest patch


- Mugdha

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-14 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/
---

(Updated July 14, 2016, 2:23 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.


Changes
---

Handle Jonathan Hurley comments


Bugs: AMBARI-17687
https://issues.apache.org/jira/browse/AMBARI-17687


Repository: ambari


Description
---

Scenario:
1. install ranger with stack 2.4 and ambari-2.4.0
2. register the version of stack 2.5
3. perform the upgrade
at the step where it where zookeepers are upgraded , just downgraded.
4. downgrade was successful 
5. check ranger service status , it was down
try to restart the ranger but ranger startup is failing


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 0df8270 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 145c216 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 f24bd83 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 63a1100 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 f47eee4 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 7e0477f 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 fad4b9b 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 dfcad32 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 5941ca1 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 44a0446 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
4c122e9 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
bbd0fe4 

Diff: https://reviews.apache.org/r/49987/diff/


Testing
---

Test Ranger Downgrade from stack 2.5 to 2.4


Thanks,

Mugdha Varadkar

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-14 Thread Jonathan Hurley 


> On July 13, 2016, 1:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml, 
> > line 529
> > 
> >
> > Why is this needed exactly? Does Ranger not support a downgrade from 
> > HDP 2.5 to an earlier stack with the earlier configs?
> 
> Mugdha Varadkar wrote:
> upgrade to 2.5 needs config changes which are added inside 
> . During downgrade all the tasks under 
> 
>id="hdp_2_5_0_0_remove_audit_db_flag" />
>id="hdp_2_5_0_0_remove_audit_db_admin_properties" />
>id="hdp_2_5_0_0_remove_audit_db_ranger_admin_site" />
>/>
>  
> 
> gets executed. This leads to below failure:
> 
> Fail("Configuration parameter '" + self.name + "' was not found in 
> configurations dictionary!")
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'audit_db_name' was not found in configurations dictionary!
> 
> To avoid that  tag is used. 
> Refer: 
> https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml#L606

Yes, it's something that is needed. It's not very intuitive, but  
runs on downgrade as well unless you override it with a blank  
element.

When we define out XSD for upgrades in the next version, we'll need to enforce 
that  exists even if it's the same work as  to 
avoid this weird side effects.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142084
---


On July 13, 2016, 8:25 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
> 
> (Updated July 13, 2016, 8:25 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful 
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  8445214 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  6d304d4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f24bd83 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  571eebd 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  f47eee4 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  7e0477f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  fad4b9b 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  dfcad32 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  2afb187 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  44a0446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
> 
> Diff: https://reviews.apache.org/r/49987/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger Downgrade from stack 2.5 to 2.4
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-14 Thread Jonathan Hurley 


> On July 13, 2016, 10:33 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py,
> >  line 60
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.
> 
> Mugdha Varadkar wrote:
> @Jonathan Hurley, am directly using check_stack_feature here because even 
> if we pass version as ---> 2.3.4.0-1234, the code has format flag as true, 
> which calls format_stack_version() function which can be used for comparision.
> "compare_versions(stack_version, min_version, format = True) < 0"
> 
> Also I have added the check for "version" in this way "if 
> upgrade_direction == Direction.DOWNGRADE and version"

My point was that the code was originally:
`foo and check_stack_feature(feature, foo) `

You don't need the "foo and" part since the check_stack_feature is checking it 
for None anyway.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142063
---


On July 13, 2016, 8:25 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
> 
> (Updated July 13, 2016, 8:25 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful 
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  8445214 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  6d304d4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f24bd83 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  571eebd 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  f47eee4 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  7e0477f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  fad4b9b 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  dfcad32 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  2afb187 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  44a0446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
> 
> Diff: https://reviews.apache.org/r/49987/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger Downgrade from stack 2.5 to 2.4
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-14 Thread Jonathan Hurley 


> On July 13, 2016, 10:33 a.m., Jonathan Hurley wrote:
> > I'm curious if you can make this simply by only using the 
> > `commandParams/version` property when calculating what to do. Here's an 
> > example of the various values during normal commands, upgrades, and 
> > downgrades. `version` seems to always be what you want, no?
> > 
> > ```
> > NORMAL COMMANDS
> >   hostLevelParams
> > stack_name = HDP
> > stack_version = 2.3
> > current_version = 2.3.4.0-1234
> > 
> >   commandParams
> > version = 2.3.4.0-1234
> > 
> > 
> > UPGRADE
> >   hostLevelParams
> > stack_name = HDP
> > stack_version = 2.3
> > current_version = 2.3.4.0-1234
> > 
> >   commandParams
> > original_stack = 2.3
> > target_stack = 2.5  
> > upgrade_direction = UPGRADE
> > version = 2.5.0.0-
> > 
> > 
> > DOWNGRADE
> >   hostLevelParams
> > stack_name = HDP
> > stack_version = 2.5
> > current_version = 2.3.4.0-1234
> > 
> >   commandParams
> > original_stack = 2.3
> > target_stack = 2.5  
> > upgrade_direction = DOWNGRADE
> > version = 2.3.4.0-1234
> > downgrade_from_version = 2.5.0.0-
> > ```
> 
> Mugdha Varadkar wrote:
> Thanks Jonathan Hurley. Actually this was done by taking reference from 
> similar code from 
> Ambari.(https://github.com/apache/ambari/commit/63f8d74f806aa55fcbb4e51b2c84a3fd0146c062#diff-a9a4cbc8111690ebc76b1e83491d2dba)
> 
> @Jayush Luniya, can we use version in NORMAL COMMANDS/UPGRADE/DOWNGRADE 
> scenarios?

Actually, an even better option is this:

```
# determine which version to use for checking stack features; version is the 
most accurate but
# may not always be available (especially on first install of the cluster)
version_for_stack_feature_checks = version if not None else 
stack_version_unformatted
```

It's possible that on initial install, `version` isn't defined since we haven't 
calculated it yet. So, the above defaults to the stack version in that case. 
Now, version covers all 3 of your scenarios.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142063
---


On July 13, 2016, 8:25 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
> 
> (Updated July 13, 2016, 8:25 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful 
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  8445214 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  6d304d4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f24bd83 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  571eebd 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  f47eee4 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  7e0477f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  fad4b9b 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  dfcad32 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  2afb187 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  44a0446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
> 
> Diff: https://reviews.apache.org/r/49987/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger Downgrade from stack 2.5 to 2.4
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-14 Thread Mugdha Varadkar 


> On July 13, 2016, 5:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml, 
> > line 529
> > 
> >
> > Why is this needed exactly? Does Ranger not support a downgrade from 
> > HDP 2.5 to an earlier stack with the earlier configs?

upgrade to 2.5 needs config changes which are added inside 
. During downgrade all the tasks under 

  
  
  
  
 

gets executed. This leads to below failure:

Fail("Configuration parameter '" + self.name + "' was not found in 
configurations dictionary!")
resource_management.core.exceptions.Fail: Configuration parameter 
'audit_db_name' was not found in configurations dictionary!

To avoid that  tag is used. 
Refer: 
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml#L606


> On July 13, 2016, 5:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py,
> >  line 214
> > 
> >
> > This is not needed since setting it to the same value under more 
> > conditions.

stack_supports_ranger_kerberos feature have min support version as 2.5

In normal case with 2.5 below code logic will be
stack_version_unformatted = config['hostLevelParams']['stack_version']  > 
2.5
stack_version_formatted = format_stack_version(stack_version_unformatted) > 
2.5.0.0
stack_supports_ranger_kerberos = stack_version_formatted and 
check_stack_feature(StackFeature.RANGER_KERBEROS_SUPPORT, 
stack_version_formatted)  ---> True

In Downgrade case from 2.5 to lower version
stack_version still points to 2.5, because of which 
stack_supports_ranger_kerberos flag becomes true which should be false.
That is the reason "if upgrade_direction == Direction.DOWNGRADE and version:" 
check was added. Using version = default("/commandParams/version", None) which 
gives downgrade version.


> On July 13, 2016, 5:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py,
> >  line 76
> > 
> >
> > No need to change stack_supports_ranger_kerberos

It is needed to be changed. Please see above comment


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142084
---


On July 13, 2016, 12:25 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
> 
> (Updated July 13, 2016, 12:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful 
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  8445214 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  6d304d4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f24bd83 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  571eebd 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  f47eee4 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  7e0477f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  fad4b9b 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  dfcad32 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  2afb187 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  44a0446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
>

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-14 Thread Mugdha Varadkar 


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > I'm curious if you can make this simply by only using the 
> > `commandParams/version` property when calculating what to do. Here's an 
> > example of the various values during normal commands, upgrades, and 
> > downgrades. `version` seems to always be what you want, no?
> > 
> > ```
> > NORMAL COMMANDS
> >   hostLevelParams
> > stack_name = HDP
> > stack_version = 2.3
> > current_version = 2.3.4.0-1234
> > 
> >   commandParams
> > version = 2.3.4.0-1234
> > 
> > 
> > UPGRADE
> >   hostLevelParams
> > stack_name = HDP
> > stack_version = 2.3
> > current_version = 2.3.4.0-1234
> > 
> >   commandParams
> > original_stack = 2.3
> > target_stack = 2.5  
> > upgrade_direction = UPGRADE
> > version = 2.5.0.0-
> > 
> > 
> > DOWNGRADE
> >   hostLevelParams
> > stack_name = HDP
> > stack_version = 2.5
> > current_version = 2.3.4.0-1234
> > 
> >   commandParams
> > original_stack = 2.3
> > target_stack = 2.5  
> > upgrade_direction = DOWNGRADE
> > version = 2.3.4.0-1234
> > downgrade_from_version = 2.5.0.0-
> > ```

Thanks Jonathan Hurley. Actually this was done by taking reference from similar 
code from 
Ambari.(https://github.com/apache/ambari/commit/63f8d74f806aa55fcbb4e51b2c84a3fd0146c062#diff-a9a4cbc8111690ebc76b1e83491d2dba)

@Jayush Luniya, can we use version in NORMAL COMMANDS/UPGRADE/DOWNGRADE 
scenarios?


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py,
> >  line 60
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.

@Jonathan Hurley, am directly using check_stack_feature here because even if we 
pass version as ---> 2.3.4.0-1234, the code has format flag as true, which 
calls format_stack_version() function which can be used for comparision.
"compare_versions(stack_version, min_version, format = True) < 0"

Also I have added the check for "version" in this way "if upgrade_direction == 
Direction.DOWNGRADE and version"


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py,
> >  line 61
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.

Same as above


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py,
> >  line 58
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.

Same as above


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py,
> >  line 57
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.

Same as above


> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py,
> >  line 47
> > 
> >
> > No need for `stack_version_formatted and` here ... just call 
> > `check_stack_feature` directly.

Same as above


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142063
---


On July 13, 2016, 12:25 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
> 
> (Updated July 13, 2016, 12:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful 
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
> 
> 
> Diffs
> -
> 
>   
>

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-13 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142084
---




ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 (line 214)


This is not needed since setting it to the same value under more conditions.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 (line 76)


No need to change stack_supports_ranger_kerberos



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml (line 
529)


Why is this needed exactly? Does Ranger not support a downgrade from HDP 
2.5 to an earlier stack with the earlier configs?


- Alejandro Fernandez


On July 13, 2016, 12:25 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
> 
> (Updated July 13, 2016, 12:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful 
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  8445214 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  6d304d4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f24bd83 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  571eebd 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  f47eee4 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  7e0477f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  fad4b9b 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  dfcad32 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  2afb187 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  44a0446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
> 
> Diff: https://reviews.apache.org/r/49987/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger Downgrade from stack 2.5 to 2.4
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-13 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142063
---



I'm curious if you can make this simply by only using the 
`commandParams/version` property when calculating what to do. Here's an example 
of the various values during normal commands, upgrades, and downgrades. 
`version` seems to always be what you want, no?

```
NORMAL COMMANDS
  hostLevelParams
stack_name = HDP
stack_version = 2.3
current_version = 2.3.4.0-1234

  commandParams
version = 2.3.4.0-1234


UPGRADE
  hostLevelParams
stack_name = HDP
stack_version = 2.3
current_version = 2.3.4.0-1234

  commandParams
original_stack = 2.3
target_stack = 2.5  
upgrade_direction = UPGRADE
version = 2.5.0.0-


DOWNGRADE
  hostLevelParams
stack_name = HDP
stack_version = 2.5
current_version = 2.3.4.0-1234

  commandParams
original_stack = 2.3
target_stack = 2.5  
upgrade_direction = DOWNGRADE
version = 2.3.4.0-1234
downgrade_from_version = 2.5.0.0-
```


ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 (line 60)


No need for `stack_version_formatted and` here ... just call 
`check_stack_feature` directly.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 (line 61)


No need for `stack_version_formatted and` here ... just call 
`check_stack_feature` directly.



ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 (line 58)


No need for `stack_version_formatted and` here ... just call 
`check_stack_feature` directly.



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 (line 57)


No need for `stack_version_formatted and` here ... just call 
`check_stack_feature` directly.



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 (line 47)


No need for `stack_version_formatted and` here ... just call 
`check_stack_feature` directly.


- Jonathan Hurley


On July 13, 2016, 8:25 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
> 
> (Updated July 13, 2016, 8:25 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful 
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  8445214 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  6d304d4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f24bd83 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  571eebd 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  f47eee4 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  7e0477f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  fad4b9b 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  dfcad32 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  2afb187 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  44a0446 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
> 
> Diff: https://reviews.apache.org/r/49987/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger Downgrade from stack 2.5 to 2.4
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-13 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17687
https://issues.apache.org/jira/browse/AMBARI-17687


Repository: ambari


Description
---

Scenario:
1. install ranger with stack 2.4 and ambari-2.4.0
2. register the version of stack 2.5
3. perform the upgrade
at the step where it where zookeepers are upgraded , just downgraded.
4. downgrade was successful 
5. check ranger service status , it was down
try to restart the ranger but ranger startup is failing


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 8445214 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 6d304d4 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 f24bd83 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 571eebd 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 f47eee4 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 7e0477f 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 fad4b9b 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 dfcad32 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 2afb187 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 44a0446 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
4c122e9 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
bbd0fe4 

Diff: https://reviews.apache.org/r/49987/diff/


Testing
---

Test Ranger Downgrade from stack 2.5 to 2.4


Thanks,

Mugdha Varadkar