Re: Review Request 50012: AMBARI-17702. Fix the stack_advisor so that LLAP can start when a nested queue is selected.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50012/#review142269 --- Ship it! Ship It! - Sumit Mohanty On July 14, 2016, 5:46 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50012/ > --- > > (Updated July 14, 2016, 5:46 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-17702 > https://issues.apache.org/jira/browse/AMBARI-17702 > > > Repository: ambari > > > Description > --- > > Earlier, we were putting the paths for the queues for selection. But YARN > needs the terminal queue name. > > FIX: Updated the code to put only the terminal leaf queue names, instead of > complete path. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > c2dfd88 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 0e455e9 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 40f3367 > > Diff: https://reviews.apache.org/r/50012/diff/ > > > Testing > --- > > Modified Python UT. > - Python UT passes. > > > Thanks, > > Swapan Shridhar > >
Re: Review Request 50012: AMBARI-17702. Fix the stack_advisor so that LLAP can start when a nested queue is selected.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50012/ --- (Updated July 14, 2016, 5:46 p.m.) Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Changes --- Changed the check 'from a subtring in a given string' to 'endswith' a given substring while looking for state and capacity keys. Bugs: AMBARI-17702 https://issues.apache.org/jira/browse/AMBARI-17702 Repository: ambari Description --- Earlier, we were putting the paths for the queues for selection. But YARN needs the terminal queue name. FIX: Updated the code to put only the terminal leaf queue names, instead of complete path. Diffs (updated) - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c2dfd88 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 0e455e9 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 40f3367 Diff: https://reviews.apache.org/r/50012/diff/ Testing --- Modified Python UT. - Python UT passes. Thanks, Swapan Shridhar
Re: Review Request 50012: AMBARI-17702. Fix the stack_advisor so that LLAP can start when a nested queue is selected.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50012/#review142182 --- Ship it! Ship It! - Sumit Mohanty On July 14, 2016, 12:12 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50012/ > --- > > (Updated July 14, 2016, 12:12 a.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-17702 > https://issues.apache.org/jira/browse/AMBARI-17702 > > > Repository: ambari > > > Description > --- > > Earlier, we were putting the paths for the queues for selection. But YARN > needs the terminal queue name. > > FIX: Updated the code to put only the terminal leaf queue names, instead of > complete path. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > c2dfd88 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 0e455e9 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 40f3367 > > Diff: https://reviews.apache.org/r/50012/diff/ > > > Testing > --- > > Modified Python UT. > - Python UT passes. > > > Thanks, > > Swapan Shridhar > >
Review Request 50012: AMBARI-17702. Fix the stack_advisor so that LLAP can start when a nested queue is selected.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50012/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-17702 https://issues.apache.org/jira/browse/AMBARI-17702 Repository: ambari Description --- Earlier, we were putting the paths for the queues for selection. But YARN needs the terminal queue name. FIX: Updated the code to put only the terminal leaf queue names, instead of complete path. Diffs - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c2dfd88 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 0e455e9 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 40f3367 Diff: https://reviews.apache.org/r/50012/diff/ Testing --- Modified Python UT. - Python UT passes. Thanks, Swapan Shridhar
