Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On Aug. 18, 2016, 9:11 p.m., Nate Cole wrote: > > What is the status of this review? If it has been pushed, please mark it > > as Submitted. The patch was reverted, I will close this review as discarded and open a new Review Request for the new patch. - Anita

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review144670 --- Ship it! Ship It! - Robert Levas On Aug. 3, 2016, 4:47

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/ --- (Updated Aug. 3, 2016, 8:47 p.m.) Review request for Ambari, Alejandro

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 4:41 p.m., Robert Levas wrote: > > Committed to trunk > > ``` > > commit 124f48ef899fddb6bdb96ebea9aa3a6a1a6adbca > > Author: Anita Jebaraj > > Date: Tue Jul 26 16:25:30 2016 -0400 > > ``` > > > > Committed to branch-2.4 > > ``` > > commit

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 8:41 p.m., Robert Levas wrote: > > Committed to trunk > > ``` > > commit 124f48ef899fddb6bdb96ebea9aa3a6a1a6adbca > > Author: Anita Jebaraj > > Date: Tue Jul 26 16:25:30 2016 -0400 > > ``` > > > > Committed to branch-2.4 > > ``` > > commit

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review143608 --- Committed to trunk ``` commit

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review143607 --- Ship it! Ship It! - Jonathan Hurley On July 26, 2016, 2:15

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 8:09 p.m., Nate Cole wrote: > > Ship It! Thank you Nate - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review143599

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 25, 2016, 10:21 p.m., Robert Levas wrote: > > Ship It! > > Robert Levas wrote: > Thanks for making those changes. > > Anita Jebaraj wrote: > can you please help in pushing the code > > Robert Levas wrote: > sure... working on it now. > > Robert Levas wrote: >

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 11:18 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 251 > > > > > > May want to try/catch around these

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review143599 --- Ship it! Ship It! - Nate Cole On July 26, 2016, 2:15 p.m.,

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 3:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 251 > > > > > > May want to try/catch around these

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 3:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 240 > > > > > > Should be ReplaceValue (capitalize

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 11:18 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 251 > > > > > > May want to try/catch around these

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 11:18 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 251 > > > > > > May want to try/catch around these

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 11:18 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 248 > > > > > > Use StringBuilder, which doesn't

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 3:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 248 > > > > > > Use StringBuilder, which doesn't

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 11:18 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 248 > > > > > > Use StringBuilder, which doesn't

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 26, 2016, 11:18 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 248 > > > > > > Use StringBuilder, which doesn't

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review143538 ---

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 25, 2016, 10:21 p.m., Robert Levas wrote: > > Ship It! > > Robert Levas wrote: > Thanks for making those changes. > > Anita Jebaraj wrote: > can you please help in pushing the code > > Robert Levas wrote: > sure... working on it now. > > Robert Levas wrote: >

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 25, 2016, 6:21 p.m., Robert Levas wrote: > > Ship It! > > Robert Levas wrote: > Thanks for making those changes. > > Anita Jebaraj wrote: > can you please help in pushing the code > > Robert Levas wrote: > sure... working on it now. Actually, we only have 1 +1. Can you

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 25, 2016, 10:21 p.m., Robert Levas wrote: > > Ship It! > > Robert Levas wrote: > Thanks for making those changes. can you please help in pushing the code - Anita --- This is an automatically generated e-mail. To reply,

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 25, 2016, 6:21 p.m., Robert Levas wrote: > > Ship It! Thanks for making those changes. - Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review143440

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review143440 --- Ship it! Ship It! - Robert Levas On July 25, 2016, 5:12

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 21, 2016, 6:30 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 242 > > > > > > Why is 'SASL' hardcoded here? > >

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/ --- (Updated July 25, 2016, 9:12 p.m.) Review request for Ambari, Di Li and Robert

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 21, 2016, 2:30 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 242 > > > > > > Why is 'SASL' hardcoded here? > >

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 21, 2016, 2:30 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 242 > > > > > > Why is 'SASL' hardcoded here? > >

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 21, 2016, 6:30 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 242 > > > > > > Why is 'SASL' hardcoded here?

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 18, 2016, 10:58 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, > > line 18 > > > > > > This is redundant... > > > >

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/ --- (Updated July 20, 2016, 10:01 p.m.) Review request for Ambari, Di Li and

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 18, 2016, 10:58 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, > > line 18 > > > > > > This is redundant... > > > >

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 18, 2016, 6:58 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, > > line 18 > > > > > > This is redundant... > > > >

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On July 18, 2016, 10:58 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, > > line 18 > > > > > > This is redundant... > > > >

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review142546 ---

Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/ --- Review request for Ambari, Di Li and Robert Levas. Bugs: AMBARI-17694