Re: Review Request 50091: EU/RU Kafka should come right after ZK instead of before Atlas, fix role command order

2016-07-18 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50091/#review142594
---


Ship it!




Ship It!

- Nate Cole


On July 18, 2016, 2:04 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50091/
> ---
> 
> (Updated July 18, 2016, 2:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17747
> https://issues.apache.org/jira/browse/AMBARI-17747
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas has a dependency on Kafka, yet EU/EU upgrades Atlas and then Kafka.
> We should move Kafka right after ZK.
> Also check role command order so that Atlas starts after HBASE and Kafka have 
> been started.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  ef8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  3e46276 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a19 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 4f5778b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 46cda9b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 47d9fdb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  c9326aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 78d22ab 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> dd7a87f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 64a77e2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  8c35210 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d365f79 
> 
> Diff: https://reviews.apache.org/r/50091/diff/
> 
> 
> Testing
> ---
> 
> Visual inspection since moving code around.
> 
> --
> Total run:1018
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50091: EU/RU Kafka should come right after ZK instead of before Atlas, fix role command order

2016-07-18 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50091/
---

(Updated July 18, 2016, 6:04 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Changes
---

Rebased


Bugs: AMBARI-17747
https://issues.apache.org/jira/browse/AMBARI-17747


Repository: ambari


Description
---

Atlas has a dependency on Kafka, yet EU/EU upgrades Atlas and then Kafka.
We should move Kafka right after ZK.
Also check role command order so that Atlas starts after HBASE and Kafka have 
been started.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 ef8 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 3e46276 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7be5a19 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
4f5778b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
46cda9b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
47d9fdb 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 c9326aa 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 2daa9b8 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
78d22ab 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
dd7a87f 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
64a77e2 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 8c35210 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
d365f79 

Diff: https://reviews.apache.org/r/50091/diff/


Testing
---

Visual inspection since moving code around.

--
Total run:1018
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 50091: EU/RU Kafka should come right after ZK instead of before Atlas, fix role command order

2016-07-18 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50091/#review142586
---


Ship it!




Ship It!

- Nate Cole


On July 15, 2016, 7:09 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50091/
> ---
> 
> (Updated July 15, 2016, 7:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17747
> https://issues.apache.org/jira/browse/AMBARI-17747
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas has a dependency on Kafka, yet EU/EU upgrades Atlas and then Kafka.
> We should move Kafka right after ZK.
> Also check role command order so that Atlas starts after HBASE and Kafka have 
> been started.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  ef8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  3e46276 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a19 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 4f5778b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> ea365e1 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  c9326aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 78d22ab 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 64a77e2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  5267727 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 1faf6f9 
> 
> Diff: https://reviews.apache.org/r/50091/diff/
> 
> 
> Testing
> ---
> 
> Visual inspection since moving code around.
> 
> --
> Total run:1018
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50091: EU/RU Kafka should come right after ZK instead of before Atlas, fix role command order

2016-07-15 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50091/#review142464
---




ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 


Atlas does not support EU/RU in HDP 2.3 and 2.4



ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json (line 
17)


Fix role command order


- Alejandro Fernandez


On July 15, 2016, 11:09 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50091/
> ---
> 
> (Updated July 15, 2016, 11:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17747
> https://issues.apache.org/jira/browse/AMBARI-17747
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas has a dependency on Kafka, yet EU/EU upgrades Atlas and then Kafka.
> We should move Kafka right after ZK.
> Also check role command order so that Atlas starts after HBASE and Kafka have 
> been started.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  ef8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  3e46276 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a19 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 4f5778b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> ea365e1 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4c122e9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  c9326aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 78d22ab 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bbd0fe4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 64a77e2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  5267727 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 1faf6f9 
> 
> Diff: https://reviews.apache.org/r/50091/diff/
> 
> 
> Testing
> ---
> 
> Visual inspection since moving code around.
> 
> --
> Total run:1018
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 50091: EU/RU Kafka should come right after ZK instead of before Atlas, fix role command order

2016-07-15 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50091/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-17747
https://issues.apache.org/jira/browse/AMBARI-17747


Repository: ambari


Description
---

Atlas has a dependency on Kafka, yet EU/EU upgrades Atlas and then Kafka.
We should move Kafka right after ZK.
Also check role command order so that Atlas starts after HBASE and Kafka have 
been started.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 ef8 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 3e46276 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7be5a19 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
4f5778b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
ea365e1 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
4c122e9 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 c9326aa 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 2daa9b8 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
78d22ab 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
bbd0fe4 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
64a77e2 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 5267727 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
1faf6f9 

Diff: https://reviews.apache.org/r/50091/diff/


Testing
---

Visual inspection since moving code around.

--
Total run:1018
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez