Re: Review Request 50150: Kerberos-related configs are not applied before INSTALL command is built on add service

2016-07-18 Thread Jonathan Hurley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50150/#review142685
---


Ship it!




Ship It!

- Jonathan Hurley


On July 18, 2016, 8:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50150/
> ---
> 
> (Updated July 18, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-17772
> https://issues.apache.org/jira/browse/AMBARI-17772
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kerberos-related configs are not applied before INSTALL command is built on 
> add service.  
> 
> This occurs when new services and components are added to an existing cluster 
> where Kerberos is enabled. Due to the order of when command detail (JSON) 
> structures are built and when service configurations are set, 
> Kerberos-related configurations will not be available for new services.  This 
> is a regression created by the patch for AMBARI-17629.
> 
> *Solution*
> Ensure that Kerberos-related configuration updates are applied before the 
> INSTALL command details are created.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  b2a3761 
> 
> Diff: https://reviews.apache.org/r/50150/diff/
> 
> 
> Testing
> ---
> 
> Manually tested in UI and Blueprint installations
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>



Re: Review Request 50150: Kerberos-related configs are not applied before INSTALL command is built on add service

2016-07-18 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50150/
---

(Updated July 18, 2016, 8:09 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-17772
https://issues.apache.org/jira/browse/AMBARI-17772


Repository: ambari


Description
---

Kerberos-related configs are not applied before INSTALL command is built on add 
service.  

This occurs when new services and components are added to an existing cluster 
where Kerberos is enabled. Due to the order of when command detail (JSON) 
structures are built and when service configurations are set, Kerberos-related 
configurations will not be available for new services.  This is a regression 
created by the patch for AMBARI-17629.

*Solution*
Ensure that Kerberos-related configuration updates are applied before the 
INSTALL command details are created.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 b2a3761 

Diff: https://reviews.apache.org/r/50150/diff/


Testing
---

Manually tested in UI and Blueprint installations

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas